Initial planning session for a bu_parallel rework

CMakeLists.txt

@@ -231,7 +231,7 @@ set(CMAKE_FIND_USE_PACKAGE_REGISTRY FALSE)
 # Prepare to manage and build BRL-CAD's external dependencies. Specifies a
 # specific commit hash to use in the 'bext' repository.
 include(BRLCAD_ExternalDeps)
-brlcad_bext_init(0682795bcfe34644c17e5a4bdd0225c76f6bdc98)
+brlcad_bext_init(12115e6c5922e2db27a9b88e00dd714af5315f69)
 
 #---------------------------------------------------------------------
 # Define various utilities.
@@ -678,13 +678,8 @@ endif(MSVC)
 # before use so platforms without GNU/LLVM-style linker options are skipped.
 brlcad_check_linker_flag(C "LINKER:--no-undefined" BRLCAD_LINKER_NO_UNDEFINED_C_FLAG_FOUND)
 brlcad_check_linker_flag(CXX "LINKER:--no-undefined" BRLCAD_LINKER_NO_UNDEFINED_CXX_FLAG_FOUND)
-if(BRLCAD_LINKER_NO_UNDEFINED_C_FLAG_FOUND AND BRLCAD_LINKER_NO_UNDEFINED_CXX_FLAG_FOUND
-   AND NOT BRLCAD_ENABLE_ADDRESS_SANITIZER)
+if(BRLCAD_LINKER_NO_UNDEFINED_C_FLAG_FOUND AND BRLCAD_LINKER_NO_UNDEFINED_CXX_FLAG_FOUND)
   set(BRLCAD_LINKER_NO_UNDEFINED_FLAG "LINKER:--no-undefined" CACHE STRING "Linker flag requiring resolved shared library symbols" FORCE)
-else()
-  # Clang links the AddressSanitizer runtime into executables, leaving its
-  # shared-library instrumentation symbols unresolved until then.
-  set(BRLCAD_LINKER_NO_UNDEFINED_FLAG "" CACHE STRING "Linker flag requiring resolved shared library symbols" FORCE)
 endif()
 brlcad_check_linker_flags(C BRLCAD_LINKER_WHOLE_ARCHIVE_GROUP_C_FLAG_FOUND "LINKER:--whole-archive" "LINKER:--no-whole-archive")
 brlcad_check_linker_flags(CXX BRLCAD_LINKER_WHOLE_ARCHIVE_GROUP_CXX_FLAG_FOUND "LINKER:--whole-archive" "LINKER:--no-whole-archive")
@@ -1647,31 +1642,21 @@ if(NOT MSVC)
   endif(BRLCAD_WARNINGS OR BRLCAD_ENABLE_STRICT)
 
   if(BRLCAD_ENABLE_COVERAGE)
-    if(CMAKE_C_COMPILER_ID MATCHES "Clang" AND CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-      check_c_flag(fprofile-instr-generate)
-      check_cxx_flag(fprofile-instr-generate)
-      check_c_flag(fcoverage-mapping)
-      check_cxx_flag(fcoverage-mapping)
-      if(NOT FPROFILE_INSTR_GENERATE_C_FLAG_FOUND OR
-         NOT FPROFILE_INSTR_GENERATE_CXX_FLAG_FOUND OR
-         NOT FCOVERAGE_MAPPING_C_FLAG_FOUND OR
-         NOT FCOVERAGE_MAPPING_CXX_FLAG_FOUND)
-        message(FATAL_ERROR "Clang source-based coverage is not supported by this toolchain.")
-      endif()
-      add_compile_options(-fprofile-instr-generate -fcoverage-mapping)
-      add_link_options(-fprofile-instr-generate)
-    else()
-      check_c_flag(ftest-coverage)
-      check_cxx_flag(ftest-coverage)
-      if(FTEST_COVERAGE_C_FLAG_FOUND AND FTEST_COVERAGE_CXX_FLAG_FOUND)
-        set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -ftest-coverage -fprofile-arcs -fprofile-update=atomic")
-        set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -ftest-coverage -fprofile-arcs -fprofile-update=atomic")
-        set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -lgcov -ftest-coverage -fprofile-arcs -fprofile-update=atomic")
-        set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -lgcov -ftest-coverage -fprofile-arcs -fprofile-update=atomic")
-      else()
-        message(FATAL_ERROR "GCC coverage is not supported by this toolchain.")
-      endif()
-    endif()
+    # TODO: These seem to GCC specific flags - should probably set up for clang
+    # as well if that's our compiler...
+    # https://clang.llvm.org/docs/SourceBasedCodeCoverage.html
+    # If we need different settings for different tools, should
+    # encapsulate each tool's setup in a function
+    check_c_flag(ftest-coverage)
+    check_cxx_flag(ftest-coverage)
+    if(FTEST_COVERAGE_C_FLAG_FOUND)
+      set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -ftest-coverage -fprofile-arcs -fprofile-update=atomic")
+      set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -ftest-coverage -fprofile-arcs -fprofile-update=atomic")
+      set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -lgcov -ftest-coverage -fprofile-arcs -fprofile-update=atomic")
+      set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} -lgcov -ftest-coverage -fprofile-arcs -fprofile-update=atomic")
+    else(FTEST_COVERAGE_C_FLAG_FOUND)
+      message(SEND_ERROR "Building with coverage is not supported by BRL-CAD on this platform.")
+    endif(FTEST_COVERAGE_C_FLAG_FOUND)
   endif(BRLCAD_ENABLE_COVERAGE)
 
   if(BRLCAD_ENABLE_STRICT)

NEWS

@@ -13,8 +13,6 @@ changes made.  See document footer for additional details.
 --- 20XX-XX-XX  Release 7.46.0                                     ---
 ----------------------------------------------------------------------
 
-* improved pixscale & bwscale scaling and image piping - Sean Morrison
-* restored pixdiff behavior on .pix, added -b for .bw - Sean Morrison
 * updated MGED and Archer for Tcl 8.6.18 and Itcl/Itk 4 - Cliff Yapp
 * fixed writes to fileless geometry databases - Cliff Yapp
 * fixed nastran-g handling of large property IDs - Rupesh, Cliff Yapp
@@ -61,8 +59,6 @@ changes made.  See document footer for additional details.
 * fixed embedded Archer display and mode menus - Cliff Yapp
 * added Archer -h and --help command-line options - Cliff Yapp
 * fixed Archer Help opening the documentation menu - Sean Morrison
-* improved fallback methodologies for facetize pipeline - Cliff Yapp
-* improved facetize pipeline robustness - Cliff Yapp
 * added arrange nest command for packing database objects - Sean Morrison
 * new mkbuilding tool for parametric/OSM/CityJSON models - Sean Morrison
 * cross-platform BINUNIF and DSP byte-order handling - Sean Morrison

README

@@ -1,6 +1,6 @@
-                          BRL-CAD
-                      Release 7.44.2
-                    http://brlcad.org/
+			    BRL-CAD
+			 Release 7.44.2
+		       http://brlcad.org/
 
 BRL-CAD is a powerful cross-platform open source combinatorial
 solid modeling system that includes an interactive 3D solid geometry

bu_parallel_upgrade.txt

@@ -0,0 +1,324 @@
+bu_parallel recursive scheduling upgrade
+========================================
+
+Status
+------
+
+This document proposes a replacement for the recursive scheduling and thread
+ID bookkeeping in src/libbu/parallel.c.  It records the constraints behind the
+current implementation, the recommended C++17 design, and an incremental plan
+for implementing and validating it.
+
+
+Confirmed source of the Valgrind warnings
+-----------------------------------------
+
+The following declaration is the source of both observed Valgrind messages:
+
+    static struct parallel_info mapping[MAX_PSW*MAX_PSW];
+
+MAX_PSW is currently 4096 and struct parallel_info is 32 bytes on this LP64
+build.  The array therefore contributes exactly 512 MiB to libbu's BSS.  The
+complete libbu BSS is 563,028,096 bytes in the observed build.
+
+Preloading only libbu.so.20 into /bin/true under Valgrind reproduces both
+"set address range perms: large range" warnings while reporting zero bytes in
+use at exit.  The dynamic loader emits the warnings while establishing memory
+permissions on libbu's unusually large RW ELF segment.  They are not reports
+of heap leaks.
+
+
+Why the array is squared
+------------------------
+
+Commit 145c80ce922fae38105c01aacae1da690e0955c1 deliberately changed the
+mapping from MAX_PSW entries to MAX_PSW*MAX_PSW entries.  It was an explicitly
+temporary attempt to accommodate recursive bu_parallel() calls.
+
+The present algorithm uses a parallel_info record both as a live thread record
+and as the concurrency scope for a nested invocation.  If an outer invocation
+starts N callbacks, each callback can call bu_parallel(..., 0) and inherit an
+independent limit of N.  The implementation can consequently create about N*N
+simultaneous parent and child records rather than sharing one limit of N.
+
+There are two additional historical constraints:
+
+* A parent ID cannot be released when a nested bu_parallel() returns if the
+  parent callback is still alive.  It may retain per-ID state and may invoke
+  bu_parallel() again.  Commit 988887e815 documents this case.
+
+* bu_parallel_id() values are used throughout BRL-CAD to index MAX_PSW-sized
+  lock-free resource arrays.  The value may be arbitrary, but it must remain in
+  the range [0, MAX_PSW).  Commit af04ca7bb4 documents this requirement.
+
+The squared mapping postpones exhaustion for one level of recursion, but it
+does not solve arbitrary nesting and it permits IDs that violate the public
+MAX_PSW array contract.  Increasing MAX_PSW from 1024 to 4096 in commit
+9aa03acf836 made the 48/64-core recursive test fit, but also increased the
+squared mapping from about 32 MiB to 512 MiB.
+
+Reducing the mapping to MAX_PSW without changing the scheduling model is not a
+valid fix.  It restores the failure that the 2016 change was trying to avoid.
+
+
+Required invariants
+-------------------
+
+The replacement must maintain the following invariants:
+
+1. Inside a callback, func_cpu_id and bu_parallel_id() identify the same
+   logical resource slot.
+
+2. Every live logical callback context has an ID in [0, MAX_PSW), and no two
+   simultaneously live contexts share an ID.
+
+3. A callback retains its logical ID across a nested bu_parallel() call and
+   until the callback itself returns.  Nested callbacks receive other IDs.
+
+4. bu_parallel() remains synchronous: it does not return until all callbacks
+   requested by that invocation have completed.
+
+5. ncpu == 0 inherits the enclosing executor's concurrency width instead of
+   multiplying it at every recursive level.
+
+6. Recursive fork/join cannot deadlock merely because all physical workers are
+   currently executing parent callbacks.
+
+7. Explicit requests are bounded by MAX_PSW.  Exhaustion must produce a clear,
+   deterministic failure before any out-of-range ID is exposed.
+
+8. Bookkeeping memory is proportional to actual workers, active calls, and
+   nesting depth.  It must not be proportional to MAX_PSW squared.
+
+9. Existing C callers and the exported C ABI remain compatible.
+
+
+Recommended design: a C++17 fork/join executor
+----------------------------------------------
+
+C++17 makes it practical to replace the platform-specific recursive thread
+creation and manual counters with a small fork/join executor using std::thread,
+std::mutex, std::condition_variable, atomics, and RAII.
+
+The preferred organization is to put the scheduler in a C++ implementation
+file and retain C-callable entry points.  It should not be necessary to convert
+all of parallel.c immediately.  CPU discovery and platform helpers can remain
+in C while the current parallel_cpp11thread.cpp is replaced or superseded by a
+new parallel_executor.cpp.  If moving bu_parallel() cleanly requires renaming
+parallel.c to parallel.cpp, its exported functions must retain C linkage.
+
+Do not enable the existing CPP11THREAD implementation as-is.  It does not
+implement BRL-CAD logical IDs, affinity behavior, recursive limits, nested
+fork/join progress, or the MAX_PSW resource contract.
+
+The executor should contain these conceptual components:
+
+1. Physical executor
+
+   An outermost bu_parallel() creates an executor with a bounded number of
+   physical workers.  An explicit ncpu selects the requested width, clamped to
+   MAX_PSW.  A zero value uses bu_avail_cpus().  A nested invocation reuses the
+   executor already recorded in thread-local state and never creates N more OS
+   threads for each parent callback.
+
+   Starting with an executor owned by each outermost call avoids introducing a
+   process-lifetime thread pool, complicated fork behavior, and new shutdown
+   ordering.  A persistent process-wide executor can be considered later if
+   measurements justify it.
+
+2. Logical ID pool
+
+   Maintain a process-wide pool of exactly MAX_PSW logical resource IDs.  IDs
+   are acquired immediately before a callback begins and released immediately
+   after that callback returns.  A free list or bitmap avoids scanning a large
+   mapping table.
+
+   A nested callback running on the same physical std::thread as its suspended
+   parent must acquire a different logical ID.  An RAII guard saves the
+   physical thread's previous thread-local ID, installs the child's ID, and
+   restores the parent ID when the child returns.  The parent ID remains
+   reserved for the lifetime of the suspended parent stack.
+
+   If nesting consumes all MAX_PSW logical IDs, bu_parallel() must fail with a
+   diagnostic rather than wait forever or index beyond a caller's resource
+   array.  The API currently returns void, so the existing bu_bomb-style hard
+   failure is the compatible behavior unless a future API adds error returns.
+
+3. Parallel call state
+
+   Each invocation has dynamically allocated call state containing at least:
+
+       callback and data
+       requested callback count
+       next unclaimed callback
+       number of incomplete callbacks
+       parent/root executor association
+       completion mutex/condition
+       failure state
+
+   Callback work should be claimed lazily.  Do not allocate or enqueue N*N job
+   objects for a recursive N-by-N call.  A bounded number of runnable tokens
+   can refer to one call state while workers atomically claim its remaining
+   callback invocations.  Memory then remains proportional to executor width
+   and the number of active calls.
+
+4. Helping wait
+
+   A non-worker caller may sleep on the call's completion condition.  A worker
+   making a nested bu_parallel() call must not simply block, since all workers
+   could otherwise block waiting for children that have no thread on which to
+   run.
+
+   Instead, a waiting worker repeatedly executes available work until its
+   nested call completes.  This is the standard fork/join "help while waiting"
+   rule.  It keeps the fixed worker set making progress at arbitrary nesting
+   depth and replaces the current one-second polling loop.
+
+   Every re-entered callback gets its own logical ID guard, even when it runs
+   on the same physical std::thread as a suspended parent.
+
+5. Affinity
+
+   Affinity belongs to physical workers, not logical callback IDs.  Set it once
+   when a worker starts, using a physical worker ordinal.  Logical IDs may be
+   larger than the available CPU count and may change as one worker helps
+   nested calls.
+
+6. Callback ID semantics
+
+   The callback's func_cpu_id remains a logical resource ID and must match
+   bu_parallel_id().  It is not a stable callback ordinal and is not guaranteed
+   to start at zero or be contiguous.  Documentation that promises increasing
+   callback numbers starting at zero should be corrected.  Code needing a work
+   ordinal should claim work from its shared data, as existing self-dispatching
+   callbacks generally do.
+
+
+Why this fixes the recursive case
+---------------------------------
+
+For an N-way outer call in which every callback makes an N-way nested call:
+
+* The executor still has N physical workers, not N*N workers.
+* All N*N nested callback invocations are performed, but workers claim them
+  incrementally while waiting for their own nested joins.
+* Each suspended outer callback retains its logical ID.
+* Each currently executing nested callback obtains another logical ID.
+* The usual two-level case needs on the order of 2*N live logical IDs rather
+  than N*N mapping entries.
+* Deeper nesting consumes logical IDs according to live stack depth.  The hard
+  MAX_PSW bound remains explicit and safe instead of silently corrupting a
+  per-ID array.
+
+
+Optional short-term containment
+-------------------------------
+
+If the loader warnings must be removed before the executor is ready, replace
+the monolithic squared array with stable, lazily allocated blocks while
+preserving its current logical capacity.  For example, a static top-level
+array of block pointers can address blocks of 1024 parallel_info records,
+allocating a block only when an ID in that block is first needed.  Individual
+blocks must never move because thread_context currently retains pointers to
+parallel_info records.
+
+A free list or high-water hint should accompany the blocks so ID allocation
+does not scan the entire MAX_PSW*MAX_PSW address space.  This would reduce
+libbu's initial BSS and eliminate the two Valgrind loader warnings without
+reintroducing the immediate recursive-capacity regression.
+
+This is containment only.  It retains the possibility of returning an ID
+greater than or equal to MAX_PSW and does not bound recursive thread creation.
+It must not be presented as the correctness fix or allowed to delay the ID and
+scheduler work above.
+
+
+Implementation plan
+-------------------
+
+Phase 1: characterize and strengthen tests
+
+* Add instrumentation available in test builds to report the maximum logical
+  ID, number of simultaneously live logical contexts, physical worker count,
+  and nesting depth.
+* Extend test_parallel with two- and three-level recursion.
+* Test repeated nested calls from one parent, preserving the case described by
+  commit 988887e815.
+* Exercise ncpu values 1, 2, the available CPU count, 48, and 64 where the host
+  permits them without making every test host create thousands of threads.
+* Add concurrent independent outermost bu_parallel() calls from ordinary
+  application threads.
+* Assert that every observed callback ID is less than MAX_PSW and that
+  func_cpu_id equals bu_parallel_id().
+
+Phase 2: implement the executor behind an internal switch
+
+* Add the C++17 executor and logical ID pool without deleting the legacy path.
+* Keep both implementations selectable at build time or by a test-only switch
+  so identical workloads can be compared.
+* Use RAII for logical IDs, TLS restoration, mutex ownership, worker joining,
+  and cleanup after thread creation failures.
+* Catch std::system_error from worker creation, stop accepting work, join all
+  workers already created, and issue the normal libbu fatal diagnostic.
+
+Phase 3: implement recursive helping and lazy work claims
+
+* Make nested calls reuse their current executor.
+* Implement help-while-waiting and completion notification.
+* Generate callback work lazily so recursive fan-out does not allocate a job
+  object per callback.
+* Confirm that nested explicit ncpu requests control the number of callback
+  invocations but do not create a second unbounded set of OS threads.
+
+Phase 4: switch the default and remove legacy mapping
+
+* Run the complete libbu, librt, MGED, and ray-tracing regression suites using
+  the new executor.
+* Stress under ThreadSanitizer and run the recursive tests repeatedly to expose
+  bookkeeping races.
+* Compare representative ray-tracing and BREP-preparation performance against
+  the legacy implementation.
+* Make the executor the default, then remove parallel_mapping(),
+  parallel_wait_for_slot(), the squared mapping, and obsolete platform thread
+  creation branches.
+* Remove the Valgrind warning FIXME once libbu's BSS no longer contains the
+  squared array, and verify by preloading libbu into /bin/true under Valgrind.
+
+Phase 5: documentation and cleanup
+
+* Update bu/parallel.h to describe arbitrary bounded logical IDs, executor
+  reuse during recursion, and explicit failure at MAX_PSW exhaustion.
+* Update the TODO item concerning recursive bu_parallel limits and known races.
+* Decide whether the old parallel_cpp11thread.cpp should be replaced, renamed,
+  or removed to avoid two competing implementations.
+* Consider a persistent executor only as a separate performance project after
+  fork behavior, library teardown, and application concurrency are specified.
+
+
+Validation checklist
+--------------------
+
+The upgrade is ready to replace the legacy path only when all of the following
+are true:
+
+* No callback observes an ID outside [0, MAX_PSW).
+* No simultaneously live callback contexts share an ID.
+* A parent retains its ID before and after every nested call.
+* Two- and three-level recursive tests complete without deadlock.
+* Recursive ncpu == 0 never increases the physical worker count.
+* Multiple independent outer calls complete without ID collisions.
+* Thread creation and logical ID exhaustion fail cleanly.
+* ThreadSanitizer reports no scheduler bookkeeping races.
+* Existing libbu and application regression tests pass.
+* Representative performance is not materially worse than the legacy path.
+* libbu no longer contains the 512 MiB mapping BSS.
+* Preloading libbu under Valgrind produces neither large-range warning.
+
+
+Non-goals
+---------
+
+This upgrade should not initially attempt to remove MAX_PSW-sized resource
+arrays throughout BRL-CAD, change the public callback signature, introduce a
+permanent global thread pool, or guarantee a callback ordinal through
+func_cpu_id.  Those are separate API and architecture projects.

doc/asciidoc/system/man1/pixdiff.adoc

@@ -4,54 +4,38 @@
 :manmanual: BRL-CAD
 
 == NAME
-pixdiff - highlight differences between two pix or bw images
+pixdiff - highlight samples which differ between two pix or bw files
 
 == SYNOPSIS
 
 [source]
 ----
 pixdiff _file1.pix_ _file2.pix_ > _out.pix_
-pixdiff -b _file1.bw_ _file2.bw_ > _out.bw_
+pixdiff _file1.bw_ _file2.bw_ > _out.bw_
 ----
 
 
 [[description]]
 == DESCRIPTION
 
-By default, *pixdiff* compares raw *pix*(5) images as RGB pixels and writes
-a PIX difference image to standard output. When all three channels of a
-pixel match, it writes a dim grayscale version of that pixel to all three
-output channels. When any channel differs, each matching channel is written
-as zero, each channel differing by one is written as 192, and each channel
-differing by more than one is written as 255.
+*pixdiff* compares two raw *pix*(5) or *bw*(5) images byte by byte and
+writes a difference image of the same size to standard output. Bytes that
+differ by +/-1 are written at intensity 192, while larger differences are
+written at full intensity 255. Matching bytes are written at half their
+original intensity, providing visual context for locating differences.
 
-With *-b*, *pixdiff* compares raw *bw*(5) images one byte at a time and
-writes a BW difference image. Differing samples use the same 192 and 255
-intensities; matching samples are written at half their original intensity.
-
-No image dimensions are needed. The two inputs must be the same size in
-bytes, and PIX input must contain complete three-byte pixels. Otherwise,
-*pixdiff* reports an error. Either input file may be given as
+Because the comparison does not interpret pixel structure, no format option
+is needed and *pixdiff* is independent of image resolution. The two inputs
+must be the same size in bytes; otherwise the program reports the mismatch
+and exits. Either input file may be given as
 *-* to read from standard input. Output must be redirected; *pixdiff*
 refuses to write a raw image stream to a terminal.
 
-Upon completion, *pixdiff* reports matching, off-by-one, and larger-difference
-channel or sample counts on standard error.
+Upon completion, the count of bytes that matched, that were off by 1, and
+that were off by many is reported on standard error.
 
-*bwdiff -n -b* produces a similar BW highlight image, but writes 255 rather
-than 192 for off-by-one differences. The default *bwdiff*(1) output instead
-shows signed differences around a neutral gray.
-
-
-[[options]]
-== OPTIONS
-
-*-b*::
-Treat both inputs and the output as one-byte-per-pixel BW images. Without
-this option, use three-byte-per-pixel PIX images.
-
-*-h*::
-Show usage information.
+Also see *bwdiff*(1), which can also operate on *pix*(5) files and can
+produce other kinds of difference output.
 
 
 [[examples]]
@@ -75,10 +59,10 @@ on standard error give a quick quantitative sense of how much changed.
 ====
 [source,bash]
 ----
-pixdiff -b depth_a.bw depth_b.bw > depth_diff.bw
+pixdiff depth_a.bw depth_b.bw > depth_diff.bw
 ----
-Writes a grayscale highlight image using byte-wise comparison. Matching
-samples retain half their input intensity as context.
+Writes a grayscale highlight image using the same byte comparison and
+statistics as the color example; no format option is needed.
 ====
 
 

doc/asciidoc/system/man3/libanalyze.adoc

@@ -18,8 +18,7 @@ Link with *-lanalyze*.
 The public interface is organized across the headers included by
 _analyze.h_, including _analyze/diff.h_, _analyze/density.h_,
 _analyze/grid.h_, _analyze/heal.h_, _analyze/info.h_, _analyze/pnts.h_,
-_analyze/contour.h_, _analyze/polygonize.h_, _analyze/nirt.h_,
-_analyze/voxelize.h_, and
+_analyze/polygonize.h_, _analyze/nirt.h_, _analyze/voxelize.h_, and
 _analyze/worker.h_.
 
 == DESCRIPTION
@@ -33,7 +32,7 @@ to gather the information they need.
 Facilities provided by the library include model differencing, material
 density and mass property analysis, ray-based gridding and sampling,
 geometry healing, model information queries, point-cloud generation and
-processing, manifold dual contouring and voxelization of geometry, and the
+processing, polygonization and voxelization of geometry, and the
 interactive ray-tracing engine used by the *nirt*(1) command. A parallel
 worker interface supports distributing analysis work across multiple
 threads.

doc/asciidoc/system/man3/librt.adoc

@@ -200,56 +200,6 @@ ____
 
 The LIBRT_DEBUG environment variable may be set to the hexadecimal bit vector as described by the DEBUG_* flags listed in the raytrace.h header. Similarly, many LIBRT applications provide a "-x #" command-line option which will take precedence over the environment variable.
 
-The RT_DEBUG_RTCMP flag (0x10000000) (set with LIBRT_DEBUG=10000000)
-sets up rtcmp capture, but recording starts disabled. Set
-LIBRT_RTCMP_FILE before enabling the flag, then call
-rt_rtcmp_capture_set_enabled(1) from the application or a debugger to
-record selected rays. Call rt_rtcmp_capture_set_enabled(0) to stop
-recording. Enabling returns -1 if the debug flag is unset or the output
-writer failed to initialize; disabling returns 0 even before setup. A
-ray must begin while recording is enabled, and leaving recording
-disabled when it finishes suppresses its record. The debug flag must be
-set before concurrent ray shooting; use the setter to change recording
-state while rays are running.
-
-Captured hits append one high-precision rtcmp JSON record per ray with
-final partitions. Misses produce no record. librt never clears the
-output file; the caller must clear or rotate it before a new comparison
-as needed. Separate processes must not write to the same file
-concurrently. Pending records are flushed within two seconds under
-normal operation and during normal process shutdown; call
-rt_rtcmp_capture_flush() to wait for pending records when using a
-debugger. Disabling recording does not discard records already queued. A
-process terminated abnormally may lose pending records. rtcmp comparison
-files should use the same hit-only capture mode on both sides; its
-generation mode also includes misses. The output can be expanded to also
-include primitive segments if LIBRT_RTCMP_PRIMITIVES is set to 1 before
-capture is set up.
-
-For example, run a single-threaded ray tracing application in a debugger
-and stop at `rt_shootray` for the suspect ray. Capture just that call,
-then compare it with a capture of the same ray from a reference build:
-
-[source,shell]
-----
-$ LIBRT_DEBUG=10000000 LIBRT_RTCMP_FILE=trial.json \
-    gdb --args ./ray_application model.g
-(gdb) break rt_shootray
-(gdb) run
-(gdb) call rt_rtcmp_capture_set_enabled(1)
-(gdb) finish
-(gdb) call rt_rtcmp_capture_set_enabled(0)
-(gdb) call rt_rtcmp_capture_flush()
-(gdb) quit
-$ rtcmp -c reference.json trial.json
-----
-
-Continue to the suspect ray before enabling capture if the breakpoint
-first stops on another ray. Produce `reference.json` with the same ray
-and the same capture mode; set LIBRT_RTCMP_PRIMITIVES=1 for both runs
-when primitive segments are needed to locate a difference before Boolean
-evaluation.
-
 The LIBRT_V4FLIP environment variable may be set to a true or false value to respectively force or disable endianness interpretation of v4 geometry database files. The default behavior is to automatically detect whether flipping the endian interpretation will help LIBRT read a binary-incompatible v4 geometry database file. Setting LIBRT_V4FLIP will override automatic detection.
 
 

doc/asciidoc/system/mann/facetize.adoc

@@ -10,7 +10,7 @@ facetize - Creates __new_object__ using __old_object__ as a guide, creating an e
 
 [source]
 ----
-facetize [-h] [-v] [-q] [-n] [-r] [-j jobs] [-s suffix] [-p prefix] [--in-place] [--max-time #] [--max-pnts #] [--resume] [--methods m1,m2,...] [--method-opts METHOD opt1=val opt2=val...] [--no-empty] [--log-file filename] [--nmg-booleval] [--disable-fixup] [--perturb] [--no-perturb] [--perturb-sa-tol #] [--perturb-vol-tol #] [--tolerate-failures] [-B -t threshold] {old_object new_object}
+facetize [-h] [-v] [-q] [-n] [-r] [-s suffix] [-p prefix] [--in-place] [--max-time #] [--max-pnts #] [--resume] [--methods m1,m2,...] [--method-opts METHOD opt1=val opt2=val...] [--no-empty] [--log-file filename] [--nmg-booleval] [--disable-fixup] [--perturb] [--no-perturb] [--perturb-sa-tol #] [--perturb-vol-tol #] [--tolerate-failures] [-B -t threshold] {old_object new_object}
 ----
 
 
@@ -45,8 +45,6 @@ By default, the Manifold BoT path can make use of a coplanarity-avoidance pertur
 
 When the perturbation step is active, per-region *facetize* validates the initial Boolean output against the original CSG geometry using a Crofton stochastic raytrace. The default tolerance thresholds that trigger a perturb retry are 10% for both surface area and volume; these can be adjusted with *--perturb-sa-tol* and *--perturb-vol-tol*. At the end of a per-region facetization run *facetize* prints a concise validation summary listing how many regions passed, triggered a perturb retry, or encountered one of the following noteworthy conditions:
 
-_Unbounded halfspace (validation unavailable)_: Crofton surface-area and volume comparisons require a finite sampling domain. A standalone halfspace, or another CSG result without finite bounds, is therefore not sampled and is counted as having validation unavailable. A bounded object intersected with or subtracted by a halfspace can still be validated because its finite operand supplies the sampling bounds.
-
 _Sub-mm / few-hit bypass (accepted with note)_: When the Crofton sampler finds only a very small number of ray-surface intersections (below an internal threshold of 50 crossings), the sampling noise alone would exceed 14% relative error, making any SA comparison meaningless. Geometry in this category is typically sub-millimetre in cross-section (e.g., a TGC with a radius under 0.2 mm) but the stochastic sampler has confirmed that some geometry is present. The BoT conversion is accepted and the region is counted separately in the summary. Users should verify that such extreme geometry reflects actual modeling intent rather than an accidental near-degenerate primitive.
 
 _Zero-hit replacement_: When the Crofton sampler fires rays but records zero intersections with the CSG geometry while the corresponding BoT is non-empty, *facetize* concludes that the Boolean evaluation most likely produces empty geometry (for example, a subtractor that fully engulfs the base object). In this case the non-empty BoT is discarded and replaced with an empty BoT to match the expected raytrace behavior. If this replacement appears unexpected for a given region, the *lint* command can be used to inspect the result.
@@ -63,21 +61,13 @@ Different tolerance settings will create finer or coarser meshes. See the *tol*
 
 Primitive tessellation is performed in a child process against a private working copy of the database in the BRL-CAD cache.  The original database is not modified as individual primitive meshes are generated.  Only after the conversion succeeds are the requested results transferred from the working database.  This separation also permits an interrupted conversion to retain its intermediate state for use with *--resume*.
 
-The parent command sends primitive names to a small pool of persistent tessellation processes.  Each child reports a result for every name, so a timeout, conversion failure, or child-process crash can be associated directly with the affected primitive.  A child is restarted when necessary and processing continues with the next name; the parent does not subdivide and retry the whole group to discover which object failed.  Unless output is suppressed with *--quiet*, long tessellation batches also report their completed-object count and active-worker state at approximately five-second intervals.
+The parent command sends primitive names to a persistent tessellation process one at a time.  The child reports a result for each name, so a timeout, conversion failure, or child-process crash that occurs before a database write can be associated directly with the affected primitive.  The child is restarted when necessary and processing continues with the next name; the parent does not subdivide and retry the whole group to discover which object failed.  Unless output is suppressed with *--quiet*, long tessellation batches also report their current object and completed-object count at approximately five-second intervals.
 
-By default, *facetize* uses at most two worker processes and only enables the second when both CPU and memory information indicate it is safe.  It reserves the larger of one GiB or one quarter of total physical memory for the rest of the system.  Starting another job also requires at least 512 MiB beyond that reserve, or the largest worker resident-memory measurement seen so far if that is greater.  If the platform cannot report the required memory information, *facetize* falls back to one worker.  The available CPU count is divided among worker processes and is also imposed as the thread limit inside each worker, preventing nested algorithms from independently using all CPUs.  *--jobs* changes the maximum process count; it does not bypass the memory admission checks.
-
-Per-region BoT conversion uses this worker policy for both independent CSG validation and initial Manifold Boolean evaluation.  When more than one worker is available, persistent validation processes each open their own read-only handle to the original database and compute Crofton surface-area and volume references for different regions.  Persistent Boolean processes then evaluate different region trees using independent read-only handles to one shared snapshot of the tessellated working database.  That snapshot also serves as the rollback checkpoint, so increasing *--jobs* does not create additional full database copies.  This process isolation avoids sharing mutable raytrace preparation or database state between concurrent evaluations.  Each result remains associated with the requested region name.  The parent commits completed BoTs through one writer and continues to perform hierarchy changes, validation decisions, and any perturb retries serially.  A one-worker run retains the established in-process order and avoids the snapshot phase.
-
-Validation and Boolean workers report their completed-region count and active-worker state approximately every five seconds.  When *--max-time* is specified, it also bounds each parallel CSG reference or Boolean request; a timed-out process is terminated, and the failure is associated with that region.  Failure or timeout of supplementary CSG validation does not cause unrelated regions to be retried.
-
-Database updates use a separate write handshake.  After preparing a mesh in memory, a child announces that it is ready to write and reports the approximate mesh size and its current resident memory, then waits.  The parent grants write permission, the child acknowledges when it is starting the write, and the child explicitly reports when the update is complete.  Consequently, the normal per-object tessellation limit, including *--max-time* and method-specific limits, applies to mesh preparation and does not interrupt an acknowledged write.
-
-With multiple workers, primitive tessellation children write to small staging databases rather than modifying the shared working database.  Region Boolean children read one immutable cache-local snapshot while completed results are committed to the working database.  The snapshot doubles as the recovery checkpoint and is opened independently by each worker; it is not duplicated per worker.  For very large files, snapshot preparation reports the amount copied and elapsed time at five-second intervals.  A region result is first completed in memory and enters the write handshake only when it is ready to replace the prior staged result.  After a child reports a completed staging write, the parent submits that result to a single persistent writer process.  The writer announces that it is ready, waits for the parent's permission, acknowledges that it is starting the write, transfers the result through one persistent working-database handle, and reports completion.  This permits tessellation and initial region Boolean evaluation to proceed in parallel without concurrent database allocation updates or repeated full directory scans, while allowing the parent to supervise the canonical database write itself.  With one worker, the established direct path avoids the extra staging I/O and database snapshot.
+Database updates use a separate write handshake.  After preparing a mesh in memory, the child announces that it is ready to write and reports the approximate mesh size, then waits.  The parent acknowledges that it is waiting for the write before the child may update the working database.  The child explicitly reports when the update is complete.  Consequently, the normal per-object tessellation limit, including *--max-time* and method-specific limits, applies to mesh preparation and does not interrupt an acknowledged database write.
 
 Before the first primitive conversion, the parent measures write throughput on the same cache filesystem as the working database.  It writes a temporary file in 1 MiB chunks until approximately one second has elapsed or 128 MiB has been written, then removes the file immediately.  Successful mesh writes of at least 1 MiB subsequently refine this profile.  For each database update, the parent allows ten times the projected write time, with a minimum of five seconds and a maximum of five minutes.  This measured allowance protects legitimate long writes on slow storage while still detecting a genuinely stalled update.
 
-If a child fails before acknowledging that its write has started, the working database is known to be unchanged and no rollback is needed.  In parallel mode, a failure during a child write affects only that worker's disposable staging database, so the failed object is reported and the worker can be restarted without replaying unrelated objects.  A serial child failure during a direct write, or a writer-process failure after acknowledging write start, is ambiguous because the working database may contain a partial update.  In those cases *facetize* restores its cache-local checkpoint and replays only the conversions not already tied to a specific failure.  The original database remains untouched during this recovery.
+If a child fails before write permission is granted, the working database is known to be unchanged and no rollback is needed.  A failure, crash, or write-deadline expiration after permission is granted but before completion is ambiguous: the working database may contain a partial update.  In that case *facetize* restores its cache-local checkpoint and replays only the primitive conversions already known to have succeeded.  The original database remains untouched during this recovery.
 
 
 [[facetize_options]]
@@ -104,10 +94,6 @@ Instructs *facetize* to produce NMG solids rather than BoT solids.
 Rather than converting all specified inputs to one top level object, walk specified trees and individually convert regions to facetized objects. This mode is useful when wanting to display models in shaded mode while preserving color and region ID properties. If no regions are present a normal conversion is performed instead.
 
 
-*-j, --jobs #*::
-Set the maximum number of facetize worker processes. A value of 1 forces serial processing. The default value of 0 selects a conservative automatic limit based on available CPUs and memory. Memory checks may delay or reduce parallel work even when a larger value is requested. In per-region BoT mode the same limit controls parallel CSG reference sampling and initial Manifold Boolean evaluation.
-
-
 *-s, --suffix*::
 User specified suffix to use avoiding naming conflicts (naming conflict avoidance is needed when creating objects in *-r* mode.)
 
@@ -133,7 +119,7 @@ Resume an incomplete facetization process (will utilize cached data from a previ
 
 
 *--methods*::
-Accepts a comma separated list of one or more facetization methods to use. The default tries NMG tessellation first, Manifold Dual Contouring (MDC) second, and SPSR as a final fallback. Other listed methods may be selected explicitly if a user wants to try a specific methodology.
+Accepts a comma separated list of one or more facetization methods to use. The default is to try all algorithms available as needed, but if a user knows they want to try a specific methodology they can call it out using this option.
 
 
 *--method-opts*::
@@ -245,15 +231,21 @@ mged>**facetize --tolerate-failures large_model large_model.partial.bot**
 
 ====
 
-.Refine a Manifold Dual Contouring conversion
+.Increase Decimation in CM Mode
 [example]
 ====
-This selects MDC directly and requests a finer cell size with a larger ray
-budget than the default:
+mged>**facetize --methods CM --method-opts feature_size=0.06 d_feature_size=2.0 ellipse.r ell.bot**
 
-mged>**facetize --methods MDC --method-opts "MDC feature_size=0.1 max_rays=400000" ellipse.r ell.bot**
+The default settings on this object in CM mode will produce a little over 8000 faces in the final bot, but the addition of the *d_feature_size* option with a >1.5 value has dramatically reduced the count to 104.
 
-Smaller feature sizes increase mesh detail, ray count, memory use, and runtime.
+====
+
+.Decrease Decimation in CM Mode
+[example]
+====
+mged>**facetize --methods CM --method-opts feature_size=0.06 d_feature_size=0.01 ellipse.r ell.bot**
+
+If the intent is preserve a more detailed mesh, reducing *decimation-feature-size* will keep more of the original triangles - in the above example, almost 250 thousand of the original 6.9 million faces were retained. NOTE: use lower values here cautiously, as extremely large meshes can be very difficult for many tools to deal with.
 
 ====
 

doc/inventory.adoc

@@ -679,21 +679,23 @@ Convert CSG geometry to a 3D voxel grid by:
 fill fraction
 * Level-of-detail parameter controls sub-voxel sampling
 
-==== 7.5 Manifold Dual Contouring
+==== 7.5 Implicit Surface Polygonizer (Marching Cubes / Tetrahedral)
 
-`contour.cpp` evaluates CSG geometry directly with `librt` and constructs
-closed, oriented triangle meshes:
+An implicit surface polygonizer (Bloomenthal tetrahedral marching) for
+converting any inside/outside function to a triangle mesh.
 
-* Recursively refines an implicit octree using cached axis-aligned rays along
-node box edges and interior quarter- and center-lines
-* Reuses complete ray partitions at the conforming finest grid and retains
-evaluated boundary points with analytic surface normals
-* Resolves ambiguous faces consistently and permits multiple vertices in a
-cell to preserve local topology
-* Places vertices with bounded quadratic-error minimization
-* Validates the resulting indexed mesh before returning it
-* Backs the legacy `analyze_polygonize` interface without retaining the old
-  seed-driven marching-tetrahedra implementation
+`polygonizer.c` (based on Jules Bloomenthal’s "`An Implicit Surface
+Polygonizer,`" Graphics Gems IV, 1994) converts any implicit function
+(inside/outside test) to a triangle mesh:
+
+* Maintains a hash table of evaluated lattice corners and edges
+* Expanding front: starts at a seed point and spreads outward, testing
+adjacent cube faces
+* Each transitive cube is optionally decomposed into 6 tetrahedra for
+sub-cube accuracy
+* Edge-surface crossing is found by bisection (`converge`) then the
+vertex normal is estimated from finite differences
+* Used in `libanalyze` for converting CSG regions to faceted form
 
 ==== 7.6 Geometry Differencing (raydiff)
 
@@ -1710,6 +1712,7 @@ import
 runtime
 * *MT19937*: Mersenne Twister PRNG
 * *pbrt-v3* (derived): HLBVH construction algorithm
+* *Bloomenthal polygonizer*: implicit surface polygonization
 * *Screened Poisson Reconstruction* (Michael Kazhdan): surface
 reconstruction from point clouds
 * *Ball Pivoting Algorithm*: surface reconstruction

doc/legal/embedded/CMakeLists.txt

@@ -55,6 +55,7 @@ brlcad_manage_files(pbrt.txt                   ${DOC_DIR}/legal/embedded TRIGGER
 brlcad_manage_files(picohash.txt               ${DOC_DIR}/legal/embedded TRIGGER gist)
 brlcad_manage_files(pixcii.txt                 ${DOC_DIR}/legal/embedded TRIGGER libicv)
 brlcad_manage_files(point_in_polygon.txt       ${DOC_DIR}/legal/embedded TRIGGER libbg)
+brlcad_manage_files(polygonizer.txt            ${DOC_DIR}/legal/embedded TRIGGER libanalyze)
 brlcad_manage_files(predicates.txt             ${DOC_DIR}/legal/embedded TRIGGER libbg)
 brlcad_manage_files(profont.txt                ${DOC_DIR}/legal/embedded TRIGGER libbu)
 brlcad_manage_files(pstdint.txt                ${DOC_DIR}/legal/embedded TRIGGER libbu)

doc/legal/embedded/polygonizer.txt

@@ -0,0 +1,9 @@
+https://www.bloomenthal.com/JBloom/code/polygonizer.c
+
+Authored by Jules Bloomenthal, Xerox PARC.
+Copyright (c) Xerox Corporation, 1991.  All rights reserved.
+Permission is granted to reproduce, use and distribute this code for
+any and all purposes, provided that this notice appears in all copies.
+
+file:/src/libanalyze/polygonizer.c
+

doc/legal/embedded/tcl_code.txt

@@ -61,4 +61,5 @@ Author: Paul Mackerras (paulus@cs.anu.edu.au),
 
 file:/src/libtclcad/tkImgFmtPIX.c
 file:/src/tclscripts/cad_clrpick.tcl
+file:/src/tclscripts/html_library.tcl
 

include/analyze.h

@@ -31,7 +31,6 @@
 #include "common.h"
 
 #include "analyze/defines.h"
-#include "analyze/contour.h"
 #include "analyze/debug.h"
 #include "analyze/diff.h"
 #include "analyze/density.h"

include/analyze/CMakeLists.txt

@@ -1,6 +1,5 @@
 set(
   analyze_headers
-  contour.h
   debug.h
   defines.h
   density.h

include/analyze/contour.h

@@ -1,118 +0,0 @@
-/*                      C O N T O U R . H
- * BRL-CAD
- *
- * Copyright (c) 2026 United States Government as represented by
- * the U.S. Army Research Laboratory.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public License
- * version 2.1 as published by the Free Software Foundation.
- *
- * This library is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this file; see the file named COPYING for more
- * information.
- */
-/** @addtogroup libanalyze
- * @{ */
-/** @file analyze/contour.h
- *
- * Ray-driven manifold dual contouring of evaluated BRL-CAD geometry.
- */
-
-#ifndef ANALYZE_CONTOUR_H
-#define ANALYZE_CONTOUR_H
-
-#include "common.h"
-
-#include <stddef.h>
-
-#include "vmath.h"
-#include "analyze/defines.h"
-
-__BEGIN_DECLS
-
-#define ANALYZE_MDC_DEFAULT_MAX_RAYS 0
-#define ANALYZE_MDC_DEFAULT_MINIMUM_FREE_MEM 150000000
-#define ANALYZE_MDC_DEFAULT_MIN_DEPTH 2
-#define ANALYZE_MDC_DEFAULT_MAX_DEPTH 10
-#define ANALYZE_MDC_MAX_DEPTH 20
-#define ANALYZE_MDC_DEFAULT_MAX_TIME 600
-
-struct db_i;
-/** Resource and accuracy controls for analyze_mdc(). */
-struct analyze_mdc_params {
-    /** Requested maximum finest-cell edge length.  Zero selects an
-     * implementation default based on the model bounds. */
-    fastf_t feature_size;
-
-    /** Optional user ceiling for the automatically derived ray budget.
-     * Zero applies only geometry, depth, time, and memory limits. */
-    size_t max_rays;
-
-    /** Abort before available memory drops below this many bytes. */
-    size_t minimum_free_mem;
-
-    /** Minimum and maximum power-of-two grid depths. */
-    int min_depth;
-    int max_depth;
-
-    /** Maximum wall-clock processing time in seconds.  Zero is unlimited. */
-    int max_time;
-
-    /** Emit progress diagnostics when non-zero. */
-    int verbosity;
-};
-
-#define ANALYZE_MDC_PARAMS_DEFAULT { \
-    0.0, \
-    ANALYZE_MDC_DEFAULT_MAX_RAYS, \
-    ANALYZE_MDC_DEFAULT_MINIMUM_FREE_MEM, \
-    ANALYZE_MDC_DEFAULT_MIN_DEPTH, \
-    ANALYZE_MDC_DEFAULT_MAX_DEPTH, \
-    ANALYZE_MDC_DEFAULT_MAX_TIME, \
-    0 \
-}
-
-enum analyze_mdc_status {
-    ANALYZE_MDC_OK = 0,
-    ANALYZE_MDC_INVALID_INPUT = 1,
-    ANALYZE_MDC_PREP_FAILED = 2,
-    ANALYZE_MDC_NO_SURFACE = 3,
-    ANALYZE_MDC_RAY_LIMIT = 4,
-    ANALYZE_MDC_TIMEOUT = 5,
-    ANALYZE_MDC_MEMORY_LIMIT = 6,
-    ANALYZE_MDC_AMBIGUOUS = 7,
-    ANALYZE_MDC_NOT_MANIFOLD = 8
-};
-
-/**
- * Evaluate @p object with librt and construct an indexed triangle mesh.
- *
- * On success, the caller owns @p faces and @p vertices and must release them
- * with bu_free().  Failure leaves all outputs empty.
- */
-ANALYZE_EXPORT extern enum analyze_mdc_status
-analyze_mdc(int **faces, size_t *num_faces, point_t **vertices,
-	    size_t *num_vertices, const char *object, struct db_i *dbip,
-	    const struct analyze_mdc_params *params);
-
-__END_DECLS
-
-#endif /* ANALYZE_CONTOUR_H */
-
-/** @} */
-
-/*
- * Local Variables:
- * mode: C
- * tab-width: 8
- * indent-tabs-mode: t
- * c-file-style: "stroustrup"
- * End:
- * ex: shiftwidth=4 tabstop=8
- */

include/analyze/polygonize.h

@@ -43,29 +43,9 @@ struct analyze_polygonize_params {
     size_t minimum_free_mem;
     int verbosity;
 };
-#define ANALYZE_POLYGONIZE_DEFAULT_MAX_CYCLE_TIME 30
-#define ANALYZE_POLYGONIZE_DEFAULT_MINIMUM_FREE_MEM 150000000
-#define ANALYZE_POLYGONIZE_PARAMS_DEFAULT { 0, 0, \
-    ANALYZE_POLYGONIZE_DEFAULT_MAX_CYCLE_TIME, \
-    ANALYZE_POLYGONIZE_DEFAULT_MINIMUM_FREE_MEM, 0 }
-
-/**
- * Legacy polygonization interface, implemented by analyze_mdc().
- *
- * @p size is the requested maximum cell edge length.  @p p_s is retained for
- * source and binary compatibility but is no longer used as a starting seed.
- * The caller owns successful output arrays and must release them with
- * bu_free().  Failure leaves all outputs empty.
- *
- * @return 0 on success
- * @return -1 on invalid input or polygonization failure
- * @return 2 when a time limit is reached
- * @return 3 when the minimum-free-memory limit is reached
- */
+#define ANALYZE_POLYGONIZE_PARAMS_DEFAULT { 0, 0, 30, 150000000, 0 }
 ANALYZE_EXPORT extern int
-analyze_polygonize(int **faces, int *num_faces, point_t **vertices,
-	int *num_vertices, fastf_t size, point_t p_s, const char *obj,
-	struct db_i *dbip, struct analyze_polygonize_params *p);
+analyze_polygonize(int **faces, int *num_faces, point_t **vertices, int *num_vertices, fastf_t size, point_t p_s, const char *obj, struct db_i *dbip, struct analyze_polygonize_params *p);
 
 __END_DECLS
 

include/bg.h

@@ -55,7 +55,6 @@
 #include "bg/clip.h"
 #include "bg/lseg.h"
 #include "bg/obr.h"
-#include "bg/pca.h"
 #include "bg/plane.h"
 #include "bg/polygon.h"
 #include "bg/sat.h"

include/bg/clip.h

@@ -50,12 +50,12 @@ BG_EXPORT extern int bg_lseg_clip(fastf_t *xp1, fastf_t *yp1, fastf_t *xp2, fast
  * The RPP has faces parallel to the coordinate planes and is defined
  * by a minimum point and a maximum point.
  *
- * Despite its historical name, this function clips the finite line segment
- * from a to b.
+ * FIXME: the function name implies this takes a point,dir for a,b but
+ * it actually takes a line segment going from points a to b!
  *
  * Returns -
- * 0 if the segment does not hit the RPP,
- * !0 if the segment hits the RPP.
+ * 0 if ray does not hit RPP,
+ * !0 if ray hits RPP.
  *
  * Implicit Return -
  * if !0 was returned, "a" and "b" have been clipped to the RPP.

include/bg/obr.h

@@ -126,12 +126,9 @@ BG_EXPORT extern int bg_3d_coplanar_obr(point_t *center,
  * \endverbatim
  *
  *
- * @param[out] pnts     eight non-NULL, caller-provided point_t storage
- *                       locations for the oriented bounding box vertices
- * @param[in] points_3d flat array containing 3 * pnt_cnt coordinate values
- * @param[in] pnt_cnt   number of points in points_3d
- *
- * @return 0 on success and -1 for invalid input or when no box can be fit
+ * @param[out] pnts     eight points of oriented bounding box
+ * @param points_3d	array of 3D points
+ * @param pnt_cnt	number of points in pnts array
  */
 BG_EXPORT extern int bg_3d_obb(point_t **pnts,
 			       const fastf_t *points_3d,

include/bg/pca.h

@@ -21,7 +21,7 @@
 /*----------------------------------------------------------------------*/
 /** @addtogroup bg_pca
  *
- * Principal Component Analysis
+ * Principle Component Analysis
  *
  * Calculates an XYZ coordinate system such that it aligns with the largest
  * variations in the supplied data.  Intuitively, it "aligns" with the
@@ -50,7 +50,7 @@
  * point_t p;
  * for (size_t i = 0; i < pntcnt; i++) {
  *     MAT4X3PNT(p, RT, pnts[i]);
- *     VMOVE(pnts[i], p);
+ *     VMOVE(pnts[i], v);
  * }
  * @endcode
  */
@@ -69,7 +69,7 @@ __BEGIN_DECLS
 
 /**
  * @brief
- * Perform a Principal Component Analysis on a set of points.
+ * Perform a Principle Component Analysis on a set of points.
  *
  * Outputs are a center point and XYZ vectors for the coordinate system.
  *
@@ -88,7 +88,7 @@ BG_EXPORT extern int bg_pca(point_t *c, vect_t *xaxis, vect_t *yaxis, vect_t *za
 
 __END_DECLS
 
-#endif  /* BG_PCA_H */
+#endif  /* BG_PLANE_H */
 /** @} */
 /*
  * Local Variables:

include/bg/plane.h

@@ -1171,10 +1171,9 @@ BG_EXPORT extern int bg_isect_planes(point_t pt,
 
 /**
  * @brief
- * Given an origin and a normal, create a plane_t with a unit normal.
- * The input point and normal are not modified.  A zero-length normal fails.
+ * Given an origin and a normal, create a plane_t.
  */
-BG_EXPORT extern int bg_plane_pt_nrml(plane_t *p, const point_t pt, const vect_t nrml);
+BG_EXPORT extern int bg_plane_pt_nrml(plane_t *p, point_t pt, vect_t nrml);
 
 /**
  * @brief
@@ -1189,15 +1188,13 @@ BG_EXPORT extern int bg_fit_plane(point_t *c, vect_t *n, size_t npnts, point_t *
 
 /**
  * @brief
- * Find the closest U,V point on the plane p to 3d point pt.  The plane normal
- * need not be unit length.
+ * Find the closest U,V point on the plane p to 3d point pt.
  */
 BG_EXPORT extern int bg_plane_closest_pt(fastf_t *u, fastf_t *v, plane_t *p, point_t *pt);
 
 /**
  * @brief
- * Return the 3D point on the plane at parametric coordinates u, v.  The plane
- * normal need not be unit length.
+ * Return the 3D point on the plane at parametric coordinates u, v.
  */
 BG_EXPORT extern int bg_plane_pt_at(point_t *pt, plane_t *p, fastf_t u, fastf_t v);
 

include/bg/polygon.h

@@ -293,7 +293,6 @@ BG_EXPORT extern int bg_3d_polygon_area(fastf_t *area, size_t npts, const point_
  * @param[in] npts Number of point_ts, stored in pts
  * @param[in] pts all points of the polygon, sorted counter-clockwise.
  * The array mustn't contain duplicated points or non-coplanar points.
- * A zero-area polygon fails.
  *
  * @return 0 if calculation was successful
  * @return 1 if calculation failed, e.g. because one in-parameter is a NULL-pointer
@@ -308,7 +307,7 @@ BG_EXPORT extern int bg_3d_polygon_centroid(point_t *cent, size_t npts, const po
  *@param[in] npts Number of points, pts contains
  *@param pts Array of point_ts, building a convex polygon. Duplicated points
  *aren't allowed. The points in the array will be sorted counter-clockwise.
- *@param[in] cmp Plane equation of the polygon.  Its normal must be nonzero.
+ *@param[in] cmp Plane equation of the polygon
  *
  *@return 0 if calculation was successful
  *@return 1 if calculation failed, e.g. because pts is a NULL-pointer

include/bg/sat.h

@@ -39,9 +39,7 @@
 __BEGIN_DECLS
 
 /**
- * Test for an intersection between an infinite line and an Axis-Aligned
- * Bounding Box (AABB).  ldir need not be unit length, but must be nonzero.
- * aabb_extent supplies the positive half extents along the coordinate axes.
+ * Test for an intersection between a line and an Axis-Aligned Bounding Box (AABB).
  *
  * Returns 1 if they intersect, 0 otherwise.
  */
@@ -52,10 +50,7 @@ bg_sat_line_aabb(
 	);
 
 /**
- * Test for an intersection between an infinite line and an Oriented Bounding
- * Box (OBB).  ldir need not be unit length, but must be nonzero.  Each OBB
- * extent vector points from the center to a face center; nonzero vectors must
- * be mutually perpendicular, and a zero vector represents a degenerate axis.
+ * Test for an intersection between a line and an Oriented Bounding Box (OBB).
  *
  * Returns 1 if they intersect, 0 otherwise.
  */
@@ -66,9 +61,7 @@ bg_sat_line_obb(
 	);
 
 /**
- * Test for an intersection between a triangle and an Axis-Aligned Bounding
- * Box (AABB).  extent supplies the positive half extents along the coordinate
- * axes.
+ * Test for an intersection between a triangle and an Axis-Aligned Bounding Box (AABB).
  *
  * Returns 1 if they intersect, 0 otherwise.
  */
@@ -79,10 +72,7 @@ bg_sat_tri_aabb(
 	);
 
 /**
- * Test for an intersection between a triangle and an Oriented Bounding Box
- * (OBB).  Each extent vector points from the center to a face center; nonzero
- * vectors must be mutually perpendicular, and a zero vector represents a
- * degenerate axis.
+ * Test for an intersection between a triangle and an Oriented Bounding Box (OBB).
  *
  * Returns 1 if they intersect, 0 otherwise.
  */
@@ -95,9 +85,8 @@ bg_sat_tri_obb(
 /**
  * Test for an intersection between an Axis-Aligned Bounding Box (AABB) and an
  * Oriented Bounding Box (OBB). The latter is defined by a center point and
- * three extent vectors from the center to the centers of the various faces.
- * Nonzero extent vectors must be mutually perpendicular; a zero vector
- * represents a degenerate axis.
+ * three perpendicular vectors from the center to the centers of the various
+ * faces.
  *
  * Returns 1 if they intersect, 0 otherwise.
  */
@@ -109,9 +98,8 @@ bg_sat_aabb_obb(
 
 /**
  * Test for an intersection between two Oriented Bounding Boxes (OBBs). The
- * boxes are defined by a center point and three extent vectors from the center
- * to the centers of the various faces.  Nonzero extent vectors must be
- * mutually perpendicular; a zero vector represents a degenerate axis.
+ * boxes are defined by a center point and three perpendicular vectors from the
+ * center to the centers of the various faces.
  *
  * Returns 1 if they intersect, 0 otherwise.
  */

include/bg/spsr.h

@@ -67,7 +67,6 @@
 #define BG_SPSR_H
 
 #include "common.h"
-#include <stdint.h>
 #include "vmath.h"
 #include "bg/defines.h"
 
@@ -110,7 +109,7 @@ struct bg_3d_spsr_opts {
 #define BG_3D_SPSR_BOUNDARY_DIRICHLET        3
 
 #define BG_3D_SPSR_DEFAULT_DEGREE            1     /* DEFAULT_FEM_DEGREE */
-#define BG_3D_SPSR_DEFAULT_DEPTH             8
+#define BG_3D_SPSR_DEFAULT_DEPTH             11
 #define BG_3D_SPSR_DEFAULT_KERNELDEPTH       0
 #define BG_3D_SPSR_DEFAULT_ITERATIONS        0
 #define BG_3D_SPSR_DEFAULT_FULL_DEPTH        0
@@ -118,13 +117,13 @@ struct bg_3d_spsr_opts {
 #define BG_3D_SPSR_DEFAULT_BASEVCYCLES       0
 #define BG_3D_SPSR_DEFAULT_MAX_MEM           0
 #define BG_3D_SPSR_DEFAULT_THREADS           0
-#define BG_3D_SPSR_DEFAULT_SAMPLES_PER_NODE  1.5
-#define BG_3D_SPSR_DEFAULT_SCALE             1.1
+#define BG_3D_SPSR_DEFAULT_SAMPLES_PER_NODE  1.1
+#define BG_3D_SPSR_DEFAULT_SCALE             1.0
 #define BG_3D_SPSR_DEFAULT_WIDTH             0.0
 #define BG_3D_SPSR_DEFAULT_CONFIDENCE        0.0
 #define BG_3D_SPSR_DEFAULT_CONFIDENCE_BIAS   0.0
 #define BG_3D_SPSR_DEFAULT_CGSOLVER_ACCURACY 1.0e-3
-#define BG_3D_SPSR_DEFAULT_POINT_WEIGHT      2.0
+#define BG_3D_SPSR_DEFAULT_POINT_WEIGHT      8.0    /* DefaultPointWeightMultiplier * Degree */
 #define BG_3D_SPSR_DEFAULT_NONMANIFOLD       0
 #define BG_3D_SPSR_DEFAULT_LINEARFIT         0
 #define BG_3D_SPSR_DEFAULT_EXACT             1
@@ -168,131 +167,10 @@ struct bg_3d_spsr_opts {
  * @return 0 if successful, else error
  *
  */
-DEPRECATED BG_EXPORT int bg_3d_spsr(int **faces, int *num_faces, point_t **vertices, int *num_vertices,
+BG_EXPORT int bg_3d_spsr(int **faces, int *num_faces, point_t **vertices, int *num_vertices,
 			 const point_t *input_points_3d, const vect_t *input_normals_3d,
 			 int num_input_pnts, struct bg_3d_spsr_opts *opts);
 
-/** Reasons the SPSR solver may request additional source samples. */
-#define BG_3D_SPSR_REFINE_RESIDUAL          0x01u
-#define BG_3D_SPSR_REFINE_NORMAL            0x02u
-#define BG_3D_SPSR_REFINE_DENSITY           0x04u
-#define BG_3D_SPSR_REFINE_SURFACE_VARIATION 0x08u
-
-/** Adaptive SPSR termination states. */
-#define BG_3D_SPSR_COMPLETE                 0
-#define BG_3D_SPSR_CALLBACK_STOP            1
-#define BG_3D_SPSR_POINT_LIMIT              2
-#define BG_3D_SPSR_TIME_LIMIT               3
-#define BG_3D_SPSR_NO_NEW_SAMPLES           4
-#define BG_3D_SPSR_SOLVER_ERROR              5
-
-/**
- * One oriented source sample.  A positive @p thickness records the length of
- * the solid ray partition that supplied the sample.  Non-zero equal pair IDs
- * identify the entry and exit samples of the same partition.
- */
-struct bg_3d_spsr_sample {
-    point_t point;
-    vect_t normal;
-    fastf_t thickness;
-    uint64_t pair_id;
-};
-
-/** A spatial location at which the solver would benefit from more samples. */
-struct bg_3d_spsr_refinement_hint {
-    point_t point;
-    vect_t normal;
-    fastf_t error;
-    unsigned int reasons;
-};
-
-/** Source-to-candidate measurements supplied by an adaptive callback. */
-struct bg_3d_spsr_validation {
-    size_t ray_count;
-    size_t source_hit_rays;
-    size_t partition_mismatch_rays;
-    size_t thin_partition_count;
-    size_t thin_partition_mismatches;
-    fastf_t endpoint_error_p95;
-    fastf_t endpoint_error_p99;
-    fastf_t chord_error_fraction;
-    fastf_t surface_area_error_fraction;
-    fastf_t volume_error_fraction;
-    int passed;
-};
-
-/** Information passed to an adaptive source-sampling callback. */
-struct bg_3d_spsr_refinement_request {
-    size_t pass;
-    fastf_t target_feature_size;
-    double remaining_time;
-    const point_t *vertices;
-    size_t vertex_count;
-    const int *faces;
-    size_t face_count;
-    const struct bg_3d_spsr_refinement_hint *hints;
-    size_t hint_count;
-};
-
-/**
- * Callback response.  Sample storage remains owned by the callback and need
- * only remain valid until the callback returns; libbg copies it immediately.
- */
-struct bg_3d_spsr_refinement_response {
-    const struct bg_3d_spsr_sample *samples;
-    size_t sample_count;
-    struct bg_3d_spsr_validation validation;
-    /** Non-zero asks the adaptive driver to stop after this candidate. */
-    int stop_refinement;
-};
-
-typedef int (*bg_3d_spsr_refinement_func_t)(
-    struct bg_3d_spsr_refinement_response *response,
-    const struct bg_3d_spsr_refinement_request *request,
-    void *client_data);
-
-/** Options controlling a bounded adaptive SPSR reconstruction. */
-struct bg_3d_spsr_adaptive_opts {
-    struct bg_3d_spsr_opts solver;
-    size_t max_refinement_passes;
-    size_t max_points;
-    fastf_t target_feature_size;
-    double max_time;
-};
-
-/** Last-resort solve budget; callbacks may stop earlier when progress stalls. */
-#define BG_3D_SPSR_DEFAULT_REFINEMENT_PASSES 8
-#define BG_3D_SPSR_ADAPTIVE_OPTS_DEFAULT { \
-	BG_3D_SPSR_OPTS_DEFAULT, \
-	BG_3D_SPSR_DEFAULT_REFINEMENT_PASSES, \
-	0, \
-	0.0, \
-	0.0 }
-
-/** Summary of an adaptive SPSR attempt. */
-struct bg_3d_spsr_report {
-    size_t solve_count;
-    size_t initial_sample_count;
-    size_t final_sample_count;
-    size_t requested_sample_count;
-    size_t accepted_sample_count;
-    double elapsed_time;
-    int termination;
-    struct bg_3d_spsr_validation validation;
-};
-
-/**
- * Reconstruct a surface and, when requested, obtain targeted additional
- * samples from @p refine.  A callback is required when refinement passes are
- * enabled.  The final candidate must be marked as passed by the callback.
- */
-BG_EXPORT int bg_3d_spsr_adaptive(int **faces, int *num_faces,
-        point_t **vertices, int *num_vertices,
-        const struct bg_3d_spsr_sample *input_samples, size_t sample_count,
-        const struct bg_3d_spsr_adaptive_opts *opts,
-        bg_3d_spsr_refinement_func_t refine, void *client_data,
-        struct bg_3d_spsr_report *report);
-
 __END_DECLS
 
 #endif  /* BG_SPSR_H */

include/bg/tri_pt.h

@@ -52,7 +52,7 @@ BG_EXPORT extern double bg_tri_closest_pt(
 
 __END_DECLS
 
-#endif  /* BG_TRI_PT_H */
+#endif  /* BG_TRI_TRI_H */
 /** @} */
 /*
  * Local Variables:

include/bg/tri_ray.h

@@ -54,7 +54,7 @@ BG_EXPORT extern int bg_isect_tri_line(point_t *isect,
  * If isect is non-NULL, it is written only when an intersection is found.
  */
 BG_EXPORT extern int bg_isect_tri_ray(const point_t orig,
-				      const vect_t dir,
+				      const point_t dir,
 				      const point_t vert0,
 				      const point_t vert1,
 				      const point_t vert2,

include/bg/trimesh.h

@@ -87,11 +87,7 @@ BG_EXPORT extern int bg_trimesh_oriented(int vcnt, int fcnt, fastf_t *v, int *f)
 /**
  * Check if a mesh is topologically solid. Returns 1 if the mesh is NOT SOLID
  * and 0 if the mesh is SOLID. A SOLID (0) outcome indicates the mesh satisfies
- * all three criteria:  Closed, Manifold, Oriented.  If @p bedges is non-NULL,
- * it is set to NULL when no edge diagnostics are present, or to a bu_calloc()
- * allocated array of vertex-index pairs for unmatched, misoriented, and excess
- * edges.  The caller must bu_free() a non-NULL result.  Use
- * bg_trimesh_solid2() when structured diagnostics and their counts are needed.
+ * all three criteria:  Closed, Manifold, Oriented
  */
 BG_EXPORT extern int bg_trimesh_solid(int vcnt, int fcnt, fastf_t *v, int *f, int **bedges);
 

include/bn/mat.h

@@ -214,8 +214,8 @@ BN_EXPORT extern void bn_mat_ae(mat_t m,
 				double elev);
 
 /**
- * Find the azimuth and elevation angles, in degrees, that correspond
- * to the direction (not including twist) given by a direction vector.
+ * Find the azimuth and elevation angles that correspond to the
+ * direction (not including twist) given by a direction vector.
  */
 BN_EXPORT extern void bn_ae_vec(fastf_t *azp,
 				fastf_t *elp,
@@ -236,16 +236,14 @@ BN_EXPORT extern void bn_aet_vec(fastf_t *az,
 				 fastf_t accuracy);
 
 /**
- * Find a unit vector from the origin given azimuth and elevation in
- * radians.
+ * Find a unit vector from the origin given azimuth and elevation.
  */
 BN_EXPORT extern void bn_vec_ae(vect_t vec,
 				fastf_t az,
 				fastf_t el);
 
 /**
- * Find a vector from the origin given azimuth and elevation in radians,
- * and distance.
+ * Find a vector from the origin given azimuth, elevation, and distance.
  */
 BN_EXPORT extern void bn_vec_aed(vect_t vec,
 				 fastf_t az,
@@ -312,10 +310,8 @@ BN_EXPORT extern void bn_vec_perp(vect_t new_vec,
  * space by the angle between the two.  There are many candidate
  * matrices.
  *
- * The input 'from' and 'to' vectors need not be unit length.  They are
- * normalized internally.  Near-parallel inputs are handled using the
- * angular tolerance in 'tol'.  If either input cannot be normalized,
- * the result is the identity matrix.
+ * The input 'from' and 'to' vectors need not be unit length.
+ * MAT4X3VEC(to, m, from) is the identity that is created.
  *
  */
 BN_EXPORT extern void bn_mat_fromto(mat_t m,
@@ -348,11 +344,12 @@ BN_EXPORT extern void bn_mat_zrot(mat_t m,
 				  double cosz);
 
 /**
- * Given a nonzero direction vector D, produce a matrix which
- * rotates D onto the -Z axis.  D is normalized internally.  Z-axis
- * directions use a deterministic roll, and a zero direction produces
- * the identity matrix.  This matrix will be suitable for use as a
- * model2view matrix.
+ * Given a direction vector D of unit length, product a matrix which
+ * rotates that vector D onto the -Z axis.  This matrix will be
+ * suitable for use as a "model2view" matrix.
+ *
+ * XXX This routine will fail if the vector is already more or less
+ * aligned with the Z axis.
  *
  * This is done in several steps.
  *

include/bn/multipoly.h

@@ -37,42 +37,11 @@ __BEGIN_DECLS
 
 typedef struct bn_multipoly {
     uint32_t magic;
-    /**< Number of coefficients in the first polynomial variable. */
     int dgrs;
-    /**< Number of coefficients in the second polynomial variable. */
     int dgrt;
-    /**< Coefficient of S^s * T^t is cf[s][t]. */
     double **cf;
 }  bn_multipoly_t;
 
-/**
- * Allocate a zero-valued bivariate polynomial with the specified
- * coefficient counts.  Both counts must be positive.
- */
-BN_EXPORT extern struct bn_multipoly *bn_multipoly_new(int dgrs, int dgrt);
-
-/** Release a bivariate polynomial allocated by bn_multipoly_new(). */
-BN_EXPORT extern void bn_multipoly_free(struct bn_multipoly *poly);
-
-/** Grow a polynomial to at least the specified coefficient counts. */
-BN_EXPORT extern struct bn_multipoly *bn_multipoly_grow(struct bn_multipoly *poly,
-							 int dgrs,
-							 int dgrt);
-
-/** Set the coefficient of S^s * T^t, growing the polynomial as needed. */
-BN_EXPORT extern struct bn_multipoly *bn_multipoly_set(struct bn_multipoly *poly,
-							int s,
-							int t,
-							double value);
-
-/** Return the sum of two bivariate polynomials. */
-BN_EXPORT extern struct bn_multipoly *bn_multipoly_add(const struct bn_multipoly *p1,
-							const struct bn_multipoly *p2);
-
-/** Return the product of two bivariate polynomials. */
-BN_EXPORT extern struct bn_multipoly *bn_multipoly_mul(const struct bn_multipoly *p1,
-							const struct bn_multipoly *p2);
-
 __END_DECLS
 
 #endif  /* BN_MULTIPOLY_H */

include/bn/poly.h

@@ -45,10 +45,7 @@ __BEGIN_DECLS
 
 /**
  * Polynomial data type
- *
- * Coefficients are stored from the highest to the lowest degree:
- * `cf[0]` is the coefficient of `X^dgr` and `cf[dgr]` is the
- * constant coefficient.
+ * bn_poly->cf[n] corresponds to X^n
  */
 typedef struct bn_poly {
     uint32_t magic;
@@ -66,9 +63,6 @@ typedef struct bn_poly {
  *
  * @brief
  * multiply two polynomials
- *
- * The output may alias either input.  If the result exceeds
- * BN_MAX_POLY_DEGREE, returns BN_POLY_NULL without modifying product.
  */
 BN_EXPORT extern struct bn_poly *bn_poly_mul(struct bn_poly *product,
 					     const struct bn_poly *m1,
@@ -87,8 +81,6 @@ BN_EXPORT extern struct bn_poly *bn_poly_scale(struct bn_poly *eqn,
  * bn_poly_add
  * @brief
  * add two polynomials
- *
- * The output may alias either input.
  */
 BN_EXPORT extern struct bn_poly *bn_poly_add(struct bn_poly *sum,
 					     const struct bn_poly *poly1,
@@ -98,8 +90,6 @@ BN_EXPORT extern struct bn_poly *bn_poly_add(struct bn_poly *sum,
  * bn_poly_sub
  * @brief
  * subtract two polynomials
- *
- * The output may alias either input.
  */
 BN_EXPORT extern struct bn_poly *bn_poly_sub(struct bn_poly *diff,
 					     const struct bn_poly *poly1,
@@ -108,10 +98,7 @@ BN_EXPORT extern struct bn_poly *bn_poly_sub(struct bn_poly *diff,
 /**
  * @brief
  * Divides any polynomial into any other polynomial using synthetic
- * division.  Both polynomials must have real coefficients and the
- * divisor's leading coefficient must be nonzero.  The quotient and
- * remainder outputs must be distinct; the quotient may alias the
- * dividend.  All other output/input pairs must be distinct.
+ * division.  Both polynomials must have real coefficients.
  */
 BN_EXPORT extern void bn_poly_synthetic_division(struct bn_poly *quo,
 						 struct bn_poly *rem,
@@ -121,8 +108,7 @@ BN_EXPORT extern void bn_poly_synthetic_division(struct bn_poly *quo,
 /**
  *@brief
  * Uses the quadratic formula to find the roots (in `complex' form) of
- * any quadratic equation with real coefficients.  A nonzero leading
- * coefficient need not be one.
+ * any quadratic equation with real coefficients.
  *
  *	@return 1 for success
  *	@return 0 for fail.
@@ -158,7 +144,6 @@ BN_EXPORT extern int bn_poly_quadratic_roots(struct bn_complex roots[],
  * If D < 0, there will be three unequal real roots.
  *
  * Returns 1 for success, 0 for fail.
- * A nonzero leading coefficient need not be one.
  */
 BN_EXPORT extern int bn_poly_cubic_roots(struct bn_complex roots[],
 					 const struct bn_poly *eqn);
@@ -166,8 +151,7 @@ BN_EXPORT extern int bn_poly_cubic_roots(struct bn_complex roots[],
 /**
  *@brief
  * Uses the quartic formula to find the roots (in `complex' form)
- * of any quartic equation with real coefficients.  A nonzero leading
- * coefficient need not be one.
+ * of any quartic equation with real coefficients.
  *
  *	@return 1 for success
  *	@return 0 for fail.

include/bn/qmath.h

@@ -100,8 +100,8 @@ BN_EXPORT extern void quat_double(quat_t qout,
 /**
  *@brief Gives the bisector of quaternions q1 and q2.
  *
- * Inputs must be unit quaternions.  Antipodal inputs use a valid
- * great-circle midpoint.
+ * (Could be done with quat_slerp and factor 0.5)
+ * [I believe they must be unit quaternions this to work]
  */
 BN_EXPORT extern void quat_bisect(quat_t qout,
 				  const quat_t q1,
@@ -161,8 +161,7 @@ BN_EXPORT extern void quat_exp(quat_t out,
 
 /**
  *@brief
- *  Take the natural logarithm of a unit quaternion.  The identity
- *  quaternion maps to the zero quaternion.
+ *  Take the natural logarithm of a unit quaternion.
  *  Code by Ken Shoemake.
  */
 BN_EXPORT extern void quat_log(quat_t out,

include/bu/log.h

@@ -205,30 +205,23 @@ BU_EXPORT extern int bu_sscanf(const char *src, const char *fmt, ...) _BU_ATTR_S
 /** Routines for scanning certain kinds of data. */
 
 /**
- * Scans a sequence of fastf_t numbers from a string or stdin.
+ * Scans a sequence of fastf_t numbers from a string or stdin
  *
  * Scanning fastf_t numbers with bu_sscanf() is difficult, because
  * doing so requires scanning to some intermediate type like double
  * and then assigning to the fastf_t variable to convert the value to
  * whatever type fastf_t really is.  This function makes it possible
- * to scan a series of fastf_t numbers easily, by doing the required
- * conversion internally.  Delimiters form a non-empty character set:
- * one or more delimiter characters must separate values, and repeated
- * delimiters are skipped.  Empty scan fields are therefore not
- * supported (e.g., "0.0,,0.0,1.0" scans as 3 fields, not 4 with the
- * second skipped).  A trailing delimiter is not consumed after the
- * final requested value.
+ * to scan a series of fastf_t numbers separated by some character(s)
+ * easily, by doing the required conversion internally to the
+ * functions.  As series of delimiter characters will be skipped,
+ * empty scan fields are not supported (e.g., "0.0,,0.0,1.0" will scan
+ * as 3 fields, not 4 with the 2nd skipped).
  *
- * @param[out] c Optional destination for the number of input characters
- *     consumed.  It is set to zero before scanning and remains zero for
- *     invalid arguments or when no value is scanned.
+ * @param[out] c Returns number of characters scanned by the function
  * @param[in] src A source string to scan from, or NULL to read from stdin
- * @param[in] delim Non-empty set of delimiter characters to skip between
- *     scan values
+ * @param[in] delim Any delimiter character(s) to skip between scan values
  * @param[in] n Number of fastf_t values to scan from the src input string
- * @param[out] ... Exactly n fastf_t pointers for storing scanned values;
- *     individual pointers may be NULL
- * @return Number of values scanned
+ * @param[out] ... Pointers to fastf_t for storing scanned values (optional)
  *
  */
 BU_EXPORT extern int bu_scan_fastf_t(int *c, const char *src, const char *delim, size_t n, ...);

include/bu/parallel.h

@@ -103,23 +103,10 @@ BU_EXPORT extern void bu_nice_set(int newnice);
 
 /**
  * Return the maximum number of physical CPUs that are considered to
- * be available to this process now, subject to any process-local limit set by
- * bu_avail_cpus_set().
+ * be available to this process now.
  */
 BU_EXPORT extern size_t bu_avail_cpus(void);
 
-/**
- * Limit the CPU count reported by bu_avail_cpus() and honored by subsequent
- * bu_parallel() calls in this process.  A value of zero removes the limit.
- * Call this before starting worker threads; changing the limit does not resize
- * work that is already running.
- *
- * This is useful when several independent processes share one machine and
- * each process contains code that selects its own parallelism with
- * bu_avail_cpus().
- */
-BU_EXPORT extern void bu_avail_cpus_set(size_t ncpu);
-
 
 /**
  * Create parallel threads of execution.

include/rt/debug.h

@@ -84,7 +84,7 @@ __BEGIN_DECLS
 #define RT_DEBUG_HF		0x04000000	/**< @brief 27 Height Field solids */
 
 #define RT_DEBUG_MESHING	0x08000000	/**< @brief 28 Print meshing/triangulation details */
-#define RT_DEBUG_RTCMP		0x10000000      /**< @brief 29 Set up rtcmp capture; recording uses a runtime toggle.  If LIBRT_RTCMP_PRIMITIVES=1 includes primitive segments. */
+#define RT_DEBUG_UNUSED_3	0x10000000	/**< @brief 29 Unassigned */
 #define RT_DEBUG_UNUSED_4	0x20000000	/**< @brief 30 Unassigned */
 
 /* Options which will cause the library to write binary debugging output */
@@ -96,7 +96,7 @@ __BEGIN_DECLS
     "\040PL_BOX" \
     "\037PL_SOLIDS" \
     "\036UNUSED_4" \
-    "\035RTCMP" \
+    "\035UNUSED_3" \
     "\034UNUSED_2" \
     "\033HF" \
     "\032EBM" \

include/rt/edit.h

@@ -465,17 +465,6 @@ rt_get_solid_keypoint(struct rt_edit *s, point_t *pt, const char **strp, fastf_t
 RT_EXPORT extern void
 rt_edit_set_edflag(struct rt_edit *s, int edflag);
 
-/**
- * Set a parameter-edit translation target expressed in model base units.
- *
- * rt_edit's parameter-edit handlers consume e_para in database local units,
- * while keypoints and edit axes are maintained in model base units.  This
- * helper performs the boundary conversion for callers that have computed a
- * target from a keypoint, axis, or view transform.
- */
-RT_EXPORT extern void
-rt_edit_set_translation_target(struct rt_edit *s, const point_t target);
-
 RT_EXPORT extern int
 rt_edit_knob_cmd_process(
 	struct rt_edit *s,
@@ -510,10 +499,8 @@ rt_knob_edit_sca(
 	int matrix_edit);
 
 /* Equivalent to sedit - run editing logic after input data is set in
- * rt_edit container.  Transient input flags are consumed whether the edit
- * succeeds or fails; parameter values remain available to the caller.
- * Returns BRLCAD_ERROR if the primitive edit fails. */
-RT_EXPORT extern int
+ * rt_edit container */
+RT_EXPORT extern void
 rt_edit_process(struct rt_edit *s);
 
 /**
@@ -534,7 +521,7 @@ rt_edit_snap_point(point2d_t pt, const struct rt_edit *s);
  * restored later with rt_edit_revert().
  *
  * The snapshot is stored inside the rt_edit struct.  Calling this
- * function again replaces the previous snapshot only on success.
+ * function again overwrites any previous snapshot (single-level undo).
  *
  * @return BRLCAD_OK on success, BRLCAD_ERROR if the export failed.
  */
@@ -545,8 +532,8 @@ rt_edit_checkpoint(struct rt_edit *s);
  * Restore primitive parameters from the snapshot saved by
  * rt_edit_checkpoint().
  *
- * The snapshot remains available for repeated restores.  If none has
- * been saved, this function logs a message and returns BRLCAD_ERROR.
+ * If no snapshot has been saved (or the last snapshot was already
+ * consumed) this function logs a message and returns BRLCAD_ERROR.
  *
  * @return BRLCAD_OK on success, BRLCAD_ERROR otherwise.
  */
@@ -710,11 +697,7 @@ enum rt_constraint_edit_op_kind {
     RT_CONSTRAINT_EDIT_OP_SET_BEND,
     RT_CONSTRAINT_EDIT_OP_SCALE_OD,
     RT_CONSTRAINT_EDIT_OP_SCALE_ID,
-    RT_CONSTRAINT_EDIT_OP_SCALE_BEND,
-    /* Set every point when an all-zero dimension has no scale reference. */
-    RT_CONSTRAINT_EDIT_OP_SET_ALL_OD,
-    RT_CONSTRAINT_EDIT_OP_SET_ALL_ID,
-    RT_CONSTRAINT_EDIT_OP_SET_ALL_BEND
+    RT_CONSTRAINT_EDIT_OP_SCALE_BEND
 };
 
 struct rt_constraint_edit_param_ref {

include/rt/func.h

@@ -227,32 +227,6 @@ struct rt_crofton_params {
     double time_ms;      /**< wall-clock time budget (ms); 0 = disabled */
 };
 
-/** One solid partition observed by a Crofton ray. */
-struct rt_crofton_segment {
-    point_t in_point;
-    vect_t in_normal;
-    point_t out_point;
-    vect_t out_normal;
-    fastf_t thickness;
-    size_t ray_id;
-};
-
-/**
- * Structured samples and estimates produced by rt_crofton_collect().
- * Release @p segments with rt_crofton_result_free().
- */
-struct rt_crofton_result {
-    struct rt_crofton_segment *segments;
-    size_t segment_count;
-    size_t ray_count;
-    size_t crossing_count;
-    double surface_area;
-    double volume;
-};
-
-/** Initialize an rt_crofton_result before first use. */
-#define RT_CROFTON_RESULT_INIT { NULL, 0, 0, 0, 0.0, 0.0 }
-
 
 /**
  * Run the Cauchy-Crofton ray-sampling estimator on an already-prepared
@@ -363,26 +337,6 @@ struct rt_crofton_result {
  */
 RT_EXPORT extern int rt_crofton_shoot(double *out_surf_area, double *out_volume, point_t *out_aabb_min, point_t *out_aabb_max, point_t out_obb[8], point_t **out_points, size_t *out_point_count, struct rt_i *rtip, const struct rt_crofton_params *params, const fastf_t *bbox_min, const fastf_t *bbox_max);
 
-/**
- * Run Crofton sampling while preserving oriented entry/exit pairs.
- *
- * @p result must be initialized with RT_CROFTON_RESULT_INIT.  On success it
- * owns the returned segment array.  @p rtip must already be prepared.
- * @p ray_offset skips that many samples in the deterministic sequence and
- * labels the returned rays starting at that value.  This lets successive
- * calls use disjoint validation streams.
- */
-RT_EXPORT extern int rt_crofton_collect(struct rt_crofton_result *result,
-					struct rt_i *rtip,
-					const struct rt_crofton_params *params,
-					size_t ray_offset,
-					const fastf_t *bbox_min,
-					const fastf_t *bbox_max);
-
-/** Release storage owned by a structured Crofton result. */
-RT_EXPORT extern void rt_crofton_result_free(
-					struct rt_crofton_result *result);
-
 
 /**
  * Cauchy-Crofton surface-area and/or volume estimator for a primitive.

include/rt/primitives/bot.h

@@ -55,11 +55,14 @@ struct clt_tri_specific {
 };
 #endif
 
+#define RT_BOT_SURFNO_INTERIOR (-1)
+
 /* Shared between bot and ars at the moment */
 struct bot_specific {
     unsigned char bot_mode;
     unsigned char bot_orientation;
     unsigned char bot_flags;
+    unsigned char bot_parity_shot;
     size_t bot_ntri;
     fastf_t *bot_thickness;
     struct bu_bitv *bot_facemode;

include/rt/primitives/nmg.h

@@ -41,7 +41,6 @@ struct rt_nmg_edit {
     struct loopuse *lu_copy;    /* copy of loop to be extruded */
     plane_t lu_pl;              /* plane equation for loop to be extruded */
     struct shell *es_s;         /* Shell where extrusion is to end up */
-    int es_s_from_extrusion;    /* Replace this edit's prior preview */
     point_t lu_keypoint;        /* keypoint of lu_copy for extrusion */
     struct vertex *es_v;        /* Currently selected NMG vertex (ECMD_NMG_VPICK) */
     struct faceuse *es_fu;      /* Currently selected NMG faceuse (ECMD_NMG_FPICK) */

include/rt/shoot.h

@@ -55,18 +55,6 @@
 
 __BEGIN_DECLS
 
-#define RT_RTCMP_CAPTURE_RUNTIME_TOGGLE 1
-
-/** Set RT_DEBUG_RTCMP recording: nonzero enables, zero disables.
- * Enabling requires the debug flag and a usable output writer.
- * Return 0 on success and -1 on failure. Disabling succeeds even
- * before setup.
- */
-RT_EXPORT extern int rt_rtcmp_capture_set_enabled(int enabled);
-
-/** Wait until pending RT_DEBUG_RTCMP records have reached the output file. */
-RT_EXPORT extern int rt_rtcmp_capture_flush(void);
-
 /**
  * @brief
  * Shoot a ray

misc/CMake/BRLCAD_ExternalDeps.cmake

@@ -2200,11 +2200,7 @@ macro(find_package_opencv)
   set(OpenCV_DIR_TMP "${OpenCV_DIR}")
   set(OpenCV_DIR "${CMAKE_BINARY_DIR}/${LIB_DIR}/cmake/opencv4")
   set(OpenCV_ROOT ${CMAKE_BINARY_DIR})
-  find_package(OpenCV CONFIG COMPONENTS core imgproc imgcodecs highgui)
-  if(OpenCV_FOUND AND OpenCV_VERSION_MAJOR GREATER_EQUAL 5)
-    # OpenCV 5 moved boundingRect from imgproc to geometry.
-    find_package(OpenCV CONFIG COMPONENTS geometry)
-  endif()
+  find_package(OpenCV COMPONENTS core features2d imgproc highgui)
   unset(OpenCV_ROOT)
 
   # If no bundled copy, see what the system has

regress/fuzz/CMakeLists.txt

@@ -117,20 +117,6 @@ if(TARGET libged)
 
 endif(TARGET libged)
 
-if(TARGET librt AND FUZZER_SUPPORTED)
-  set(RT_EDIT_FUZZ_DIR "${CMAKE_SOURCE_DIR}/src/librt/tests/edit")
-  brlcad_addexec(
-    fuzz_rt_edit_test
-    "${RT_EDIT_FUZZ_DIR}/fuzz.cpp;${RT_EDIT_FUZZ_DIR}/ars.cpp;${RT_EDIT_FUZZ_DIR}/bot.cpp"
-    "libbu;librt;libnmg;libwdb;libbrep"
-    TEST
-  )
-  set_target_properties(fuzz_rt_edit_test PROPERTIES UNITY_BUILD OFF)
-  target_compile_options(fuzz_rt_edit_test PRIVATE ${FUZZER_EXE_COMPILE_OPTIONS})
-  target_link_options(fuzz_rt_edit_test PRIVATE ${FUZZER_LINK_OPTIONS})
-  BRLCAD_ADD_TEST(NAME fuzz_rt_edit_smoke COMMAND fuzz_rt_edit_test -runs=1 -max_total_time=5)
-endif()
-
 cmakefiles(
   CMakeLists.txt
   fuzz_ged.cpp

regress/ged/regress_facetize.cpp

@@ -68,13 +68,6 @@
  *          ("/tc6_reg.c/sub6.s#sub"), so the lookup missed and no variant was
  *          applied, leaving the phantom face.  After the fix the plan is built
  *          from region roots so keys match and the phantom face is eliminated.
- *
- *   TC7  - NMG Boolean isolation and output modes: verifies that an interrupted
- *          worker cannot commit output, then exercises BoT, NMG, region, and
- *          in-place output paths.
- *
- *   TC8  - implicit solid roots survive the working-database close and remain
- *          valid members of the imported output hierarchy.
  */
 
 #include "common.h"
@@ -85,9 +78,7 @@
 #include <string>
 
 #include "bu/app.h"
-#include "bu/env.h"
 #include "bu/file.h"
-#include "bu/log.h"
 #include "bu/malloc.h"
 #include "bu/str.h"
 #include "bu/vls.h"
@@ -151,36 +142,6 @@ write_comb2(struct rt_wdb *wdbp,
    0, 0, 0, 0, 0, 0, 0);
 }
 
-static int
-write_comb1(struct rt_wdb *wdbp, const char *comb_name, const char *member, int is_region)
-{
-    struct bu_list head;
-    BU_LIST_INIT(&head);
-    mk_addmember(member, &head, NULL, WMOP_UNION);
-    return mk_comb(wdbp, comb_name, &head, is_region, NULL, NULL, NULL,
-	    0, 0, 0, 0, 0, 0, 0);
-}
-
-static int
-run_facetize_command(const char *gfile, int argc, const char **argv, int verbose)
-{
-    struct ged *gedp = ged_open("db", gfile, 1);
-    if (!gedp) {
-	bu_log("[regress_facetize] ged_open(%s) failed\n", gfile);
-	return BRLCAD_ERROR;
-    }
-
-    int ret = ged_exec(gedp, argc, argv);
-    if (verbose || ret != BRLCAD_OK) {
-	const char *log = bu_vls_cstr(gedp->ged_result_str);
-	if (log && log[0])
-	    bu_log("[facetize] %s\n", log);
-    }
-
-    ged_close(gedp);
-    return ret;
-}
-
 /**
  * Open @a gfile with ged_open and run "facetize @a input @a output".
  * Returns BRLCAD_OK on success, BRLCAD_ERROR otherwise.
@@ -188,8 +149,23 @@ run_facetize_command(const char *gfile, int argc, const char **argv, int verbose
 static int
 run_facetize(const char *gfile, const char *input, const char *output, int verbose)
 {
+    struct ged *gedp = ged_open("db", gfile, 1);
+    if (!gedp) {
+bu_log("[regress_facetize] ged_open(%s) failed\n", gfile);
+return BRLCAD_ERROR;
+    }
+
     const char *av[4] = {"facetize", input, output, NULL};
-    return run_facetize_command(gfile, 3, av, verbose);
+    int ret = ged_exec(gedp, 3, av);
+
+    if (verbose || ret != BRLCAD_OK) {
+const char *log = bu_vls_cstr(gedp->ged_result_str);
+if (log && log[0])
+    bu_log("[facetize] %s\n", log);
+    }
+
+    ged_close(gedp);
+    return ret;
 }
 
 /**
@@ -236,46 +212,6 @@ bu_log("[regress_facetize] check_bot: '%s' type %d is not a BoT\n",
     return ok;
 }
 
-static int
-check_object_type(const char *gfile, const char *object_name, int expected_type)
-{
-    struct db_i *dbip = db_open(gfile, DB_OPEN_READONLY);
-    if (!dbip || db_dirbuild(dbip) < 0) {
-	if (dbip)
-	    db_close(dbip);
-	return BRLCAD_ERROR;
-    }
-
-    struct directory *dp = db_lookup(dbip, object_name, LOOKUP_QUIET);
-    if (!dp) {
-	bu_log("[regress_facetize] '%s' does not exist\n", object_name);
-	db_close(dbip);
-	return BRLCAD_ERROR;
-    }
-
-    struct rt_db_internal intern;
-    RT_DB_INTERNAL_INIT(&intern);
-    if (rt_db_get_internal(&intern, dp, dbip, NULL) < 0) {
-	db_close(dbip);
-	return BRLCAD_ERROR;
-    }
-    int ret = (intern.idb_minor_type == expected_type) ? BRLCAD_OK : BRLCAD_ERROR;
-    if (ret != BRLCAD_OK)
-	bu_log("[regress_facetize] '%s' type %d, expected %d\n",
-		object_name, intern.idb_minor_type, expected_type);
-    rt_db_free_internal(&intern);
-    db_close(dbip);
-    return ret;
-}
-
-static int
-count_log_hook(void *data, void *UNUSED(message))
-{
-    int *count = (int *)data;
-    (*count)++;
-    return 0;
-}
-
 /**
  * Run rt_crofton_shoot on @a obj_name in @a gfile.
  * Stores SA (mm2) and VOL (mm3) in *sa / *vol.
@@ -1184,183 +1120,6 @@ tc6_havoc_wind9_pattern(const char *tmpdir, int verbose)
     return BRLCAD_OK;
 }
 
-static int
-tc7_nmg_modes(const char *tmpdir, int verbose)
-{
-    bu_log("[regress_facetize] TC7: NMG Boolean and output modes...\n");
-
-    struct bu_vls gpath = BU_VLS_INIT_ZERO;
-    bu_vls_printf(&gpath, "%s/tc7_nmg.g", tmpdir);
-    const char *gfile = bu_vls_cstr(&gpath);
-    if (bu_file_exists(gfile, NULL))
-	bu_file_delete(gfile);
-
-    struct db_i *dbip = db_create(gfile, 5);
-    if (!dbip) {
-	bu_vls_free(&gpath);
-	return BRLCAD_ERROR;
-    }
-    struct rt_wdb *wdbp = wdb_dbopen(dbip, RT_WDB_TYPE_DB_DEFAULT);
-    point_t box_pts[8] = {
-	{0.0,  0.0,  0.0}, {10.0, 0.0,  0.0},
-	{10.0, 10.0, 0.0}, {0.0,  10.0, 0.0},
-	{0.0,  0.0, 10.0}, {10.0, 0.0, 10.0},
-	{10.0, 10.0, 10.0}, {0.0, 10.0, 10.0}
-    };
-    if (write_arb8(wdbp, "box.s", box_pts) < 0 ||
-	    write_comb1(wdbp, "box.r", "box.s", 1) < 0 ||
-	    write_comb1(wdbp, "box.c", "box.s", 0) < 0) {
-	wdb_close(wdbp);
-	bu_vls_free(&gpath);
-	return BRLCAD_ERROR;
-    }
-    wdb_close(wdbp);
-
-    const char *bot_av[] = {"facetize", "--nmg-booleval", "box.r", "box.bot", NULL};
-    const char *fault_av[] = {"facetize", "--nmg-booleval", "box.r", "fault.bot", NULL};
-    const char *nmg_av[] = {"facetize", "-n", "box.r", "box.nmg", NULL};
-    const char *regions_av[] = {"facetize", "-r", "--nmg-booleval", "box.r", "box.regions", NULL};
-    const char *fallback_av[] = {"facetize", "-r", "--nmg-booleval", "box.c", "box-fallback.bot", NULL};
-    const char *object_in_place_av[] = {"facetize", "--in-place", "--nmg-booleval", "box.c", NULL};
-    const char *in_place_av[] = {"facetize", "-r", "--in-place", "--nmg-booleval", "box.r", NULL};
-
-    int ret = BRLCAD_OK;
-    auto check_tc7 = [&ret](bool passed, const char *description) {
-	if (passed)
-	    return;
-	bu_log("[regress_facetize] TC7: FAIL - %s\n", description);
-	ret = BRLCAD_ERROR;
-    };
-
-    struct bu_vls fault_path = BU_VLS_INIT_ZERO;
-    bu_vls_printf(&fault_path, "%s/tc7_nmg_worker.fault", tmpdir);
-    (void)bu_file_delete(bu_vls_cstr(&fault_path));
-    (void)bu_setenv("LIBGED_FACETIZE_TEST_FAULT",
-	    "nmg-before-ready:fault.bot", 1);
-    (void)bu_setenv("LIBGED_FACETIZE_TEST_FAULT_FILE",
-	    bu_vls_cstr(&fault_path), 1);
-    int fault_ret = run_facetize_command(gfile, 4, fault_av, verbose);
-    (void)bu_setenv("LIBGED_FACETIZE_TEST_FAULT", "", 1);
-    (void)bu_setenv("LIBGED_FACETIZE_TEST_FAULT_FILE", "", 1);
-    check_tc7(fault_ret == BRLCAD_ERROR,
-	    "an interrupted NMG Boolean worker did not report failure");
-    check_tc7(bu_file_exists(bu_vls_cstr(&fault_path), NULL),
-	    "NMG Boolean worker fault did not trigger");
-    check_tc7(check_object_type(gfile, "fault.bot", ID_BOT) != BRLCAD_OK,
-	    "an interrupted NMG Boolean worker committed an output");
-    (void)bu_file_delete(bu_vls_cstr(&fault_path));
-    bu_vls_free(&fault_path);
-
-    int hook_calls = 0;
-    bu_log_add_hook(count_log_hook, &hook_calls);
-    int bot_ret = run_facetize_command(gfile, 4, bot_av, verbose);
-    int hook_calls_before_probe = hook_calls;
-    bu_log("facetize NMG hook restoration probe\n");
-    bu_log_delete_hook(count_log_hook, &hook_calls);
-
-    check_tc7(bot_ret == BRLCAD_OK, "NMG Boolean BoT command failed");
-    check_tc7(hook_calls == hook_calls_before_probe + 1,
-	    "temporary log hook was not restored");
-    check_tc7(check_bot_exists(gfile, "box.bot") == BRLCAD_OK,
-	    "NMG Boolean BoT output is missing");
-
-    int nmg_ret = run_facetize_command(gfile, 4, nmg_av, verbose);
-    check_tc7(nmg_ret == BRLCAD_OK, "NMG output command failed");
-    check_tc7(check_object_type(gfile, "box.nmg", ID_NMG) == BRLCAD_OK,
-	    "NMG output has the wrong type");
-
-    int regions_ret = run_facetize_command(gfile, 5, regions_av, verbose);
-    check_tc7(regions_ret == BRLCAD_OK, "NMG Boolean region command failed");
-    check_tc7(check_object_type(gfile, "box.regions", ID_COMBINATION) == BRLCAD_OK,
-	    "NMG Boolean region output is missing");
-
-    int fallback_ret = run_facetize_command(gfile, 5, fallback_av, verbose);
-    check_tc7(fallback_ret == BRLCAD_OK,
-	    "region mode object fallback command failed");
-    check_tc7(check_bot_exists(gfile, "box-fallback.bot") == BRLCAD_OK,
-	    "region mode object fallback output is missing");
-
-    int object_in_place_ret = run_facetize_command(gfile, 4,
-	    object_in_place_av, verbose);
-    check_tc7(object_in_place_ret == BRLCAD_OK,
-	    "in-place NMG Boolean object command failed");
-    check_tc7(check_object_type(gfile, "box.c", ID_BOT) == BRLCAD_OK,
-	    "in-place NMG Boolean object has the wrong type");
-
-    int in_place_ret = run_facetize_command(gfile, 5, in_place_av, verbose);
-    check_tc7(in_place_ret == BRLCAD_OK,
-	    "in-place NMG Boolean region command failed");
-    check_tc7(check_object_type(gfile, "box.r", ID_COMBINATION) == BRLCAD_OK,
-	    "in-place region root has the wrong type");
-    check_tc7(check_bot_exists(gfile, "box.r.bot") == BRLCAD_OK,
-	    "in-place region BoT output is missing");
-
-    bu_log("[regress_facetize] TC7: %s\n", ret == BRLCAD_OK ? "PASS" : "FAIL");
-    bu_vls_free(&gpath);
-    return ret;
-}
-
-/* ------------------------------------------------------------------ */
-/* TC8: implicit root replacement persists across database reopen      */
-/* ------------------------------------------------------------------ */
-static int
-tc8_implicit_root_persistence(const char *tmpdir, int verbose)
-{
-    bu_log("[regress_facetize] TC8: implicit root persistence...\n");
-
-    struct bu_vls gpath = BU_VLS_INIT_ZERO;
-    bu_vls_printf(&gpath, "%s/tc8_implicit_root.g", tmpdir);
-    const char *gfile = bu_vls_cstr(&gpath);
-    if (bu_file_exists(gfile, NULL))
-	bu_file_delete(gfile);
-
-    struct db_i *dbip = db_create(gfile, 5);
-    if (!dbip) {
-	bu_vls_free(&gpath);
-	return BRLCAD_ERROR;
-    }
-    struct rt_wdb *wdbp = wdb_dbopen(dbip, RT_WDB_TYPE_DB_DEFAULT);
-    point_t region_points[8] = {
-	{0.0, 0.0, 0.0}, {10.0, 0.0, 0.0},
-	{10.0, 10.0, 0.0}, {0.0, 10.0, 0.0},
-	{0.0, 0.0, 10.0}, {10.0, 0.0, 10.0},
-	{10.0, 10.0, 10.0}, {0.0, 10.0, 10.0}
-    };
-    point_t loose_points[8] = {
-	{20.0, 0.0, 0.0}, {30.0, 0.0, 0.0},
-	{30.0, 10.0, 0.0}, {20.0, 10.0, 0.0},
-	{20.0, 0.0, 10.0}, {30.0, 0.0, 10.0},
-	{30.0, 10.0, 10.0}, {20.0, 10.0, 10.0}
-    };
-    if (!wdbp || write_arb8(wdbp, "region.s", region_points) < 0 ||
-	    write_arb8(wdbp, "loose.s", loose_points) < 0 ||
-	    write_comb1(wdbp, "box.r", "region.s", 1) < 0 ||
-	    write_comb2(wdbp, "assembly.c", "box.r", 'u',
-		    "loose.s", 'u') < 0) {
-	if (wdbp)
-	    wdb_close(wdbp);
-	bu_vls_free(&gpath);
-	return BRLCAD_ERROR;
-    }
-    wdb_close(wdbp);
-
-    const char *facetize_args[] = {
-	"facetize", "-r", "assembly.c", "assembly.regions", NULL
-    };
-    int ret = run_facetize_command(gfile, 4, facetize_args, verbose);
-    if (ret == BRLCAD_OK &&
-	    (check_object_type(gfile, "assembly.regions", ID_COMBINATION) != BRLCAD_OK ||
-	     check_object_type(gfile, "facetize_assembly.c", ID_COMBINATION) != BRLCAD_OK ||
-	     check_bot_exists(gfile, "box.r.bot") != BRLCAD_OK ||
-	     check_bot_exists(gfile, "facetize_loose.s") != BRLCAD_OK))
-	ret = BRLCAD_ERROR;
-
-    bu_log("[regress_facetize] TC8: %s\n",
-	    ret == BRLCAD_OK ? "PASS" : "FAIL");
-    bu_vls_free(&gpath);
-    return ret;
-}
-
 /* ------------------------------------------------------------------ */
 /* main                                                                 */
 /* ------------------------------------------------------------------ */
@@ -1392,8 +1151,6 @@ return 1;
     if (tc4_havoc_reuse(tmpdir, verbose)         != BRLCAD_OK) ret = 1;
     if (tc5_near_coplanar_subTOL(tmpdir, verbose) != BRLCAD_OK) ret = 1;
     if (tc6_havoc_wind9_pattern(tmpdir, verbose) != BRLCAD_OK) ret = 1;
-    if (tc7_nmg_modes(tmpdir, verbose)             != BRLCAD_OK) ret = 1;
-    if (tc8_implicit_root_persistence(tmpdir, verbose) != BRLCAD_OK) ret = 1;
 
     if (ret == 0)
 bu_log("[regress_facetize] All tests PASSED\n");

regress/gqa/CMakeLists.txt

@@ -23,7 +23,6 @@ set(
   gqa.mass_mix.am.out
   gqa.mass_mix.aw.out
   gqa.mass_mix.u0.out
-  gqa.missing_density.out
   gqa.mged
   gqa.overlaps.plot3
   gqa.sphere_adaptive.out

regress/gqa/gqa.sh

@@ -67,11 +67,6 @@ run_capture ( ) {
     return $ret
 }
 
-expect_failure ( ) {
-    "$@"
-    test $? -ne 0
-}
-
 extract_last_number ( ) {
     label="$1"
     file="$2"
@@ -106,19 +101,6 @@ assert_close ( ) {
     fi
 }
 
-assert_contains ( ) {
-    expected="$1"
-    file="$2"
-    desc="$3"
-
-    if grep -F -q "$expected" "$file" ; then
-	log "PASS: $desc"
-    else
-	log "FAIL: $desc"
-	STATUS="`expr $STATUS + 1`"
-    fi
-}
-
 MGED="`ensearch mged`"
 if test ! -f "$MGED" ; then
     log "Unable to find mged, aborting"
@@ -195,10 +177,6 @@ adjust mass_air.r GIFTmater 2
 g mass_air_only.g mass_air.r
 g mass_air_mix.g mass_solid.r mass_air.r
 
-in missing_density.s rpp 2 3 0 1 0 1
-r missing_density.r u missing_density.s
-adjust missing_density.r GIFTmater 123
-
 in sphere.s sph 0 0 0 1
 r sphere.r u sphere.s
 adjust sphere.r GIFTmater 5
@@ -265,7 +243,6 @@ run_capture gqa.mass_mix.aw.out $GQABIN -u m,m^3,kg -g 250mm-50mm -Aw gqa.g mass
 run_capture gqa.mass_mix.am.out $GQABIN -u m,m^3,kg -g 250mm-50mm -Am gqa.g mass_air_mix.g
 run_capture gqa.mass_mix.u0.out $GQABIN -u m,m^3,kg -g 250mm-50mm -U 0 -Aw gqa.g mass_air_mix.g
 run_capture gqa.sphere_adaptive.out $GQABIN -u m,m^3,kg -q -Av -g 0.05m gqa.g sphere.r
-run_capture gqa.missing_density.out expect_failure $GQABIN -u m,m^3,kg -g 250mm-50mm -f density_table.txt -Aw gqa.g missing_density.r
 
 MASS_AIR_AW="`extract_last_number 'Average total weight:' gqa.mass_air.aw.out`"
 MASS_AIR_AM="`extract_last_number 'Average total weight:' gqa.mass_air.am.out`"
@@ -280,7 +257,6 @@ assert_close 1001 "$MASS_MIX_AW" 0.001 "mixed solid+air modeled weight with -Aw"
 assert_close "$MASS_MIX_AW" "$MASS_MIX_AM" 0.001 "-Aw and -Am agree on mixed modeled air"
 assert_close 1000 "$MASS_MIX_U0" 0.001 "-U 0 excludes modeled air from weight"
 assert_close 4.18879 "$SPHERE_VOLUME" 0.01 "adaptive sphere volume refines beyond symmetric first pass"
-assert_contains "Density 123 on region /missing_density.r is not defined in the density table." gqa.missing_density.out "undefined density produces an error"
 
 
 if [ $STATUS = 0 ] ; then

regress/mged/CMakeLists.txt

@@ -68,7 +68,6 @@ set(
   sca_view.mged
   search_exec.mged
   sed.mged
-  sed_reset.mged
   set_perspective.mged
   setview.mged
   size.mged
@@ -101,7 +100,6 @@ if(TARGET mged)
       continue()
     endif(TNAME STREQUAL "")
 
-    set_property(DIRECTORY APPEND PROPERTY CMAKE_CONFIGURE_DEPENDS "${CMAKE_CURRENT_SOURCE_DIR}/${testfile}")
     file(READ "${CMAKE_CURRENT_SOURCE_DIR}/${testfile}" TEST_CONTENTS)
     if(TNAME STREQUAL "search_exec")
       string(CONFIGURE "${TEST_CONTENTS}" TEST_CONTENTS @ONLY)
@@ -128,12 +126,6 @@ if(TARGET mged)
     elseif(TNAME STREQUAL "arb")
       set(TEST_EXPECT "'arb' testing completed")
       set(TEST_SOURCE "${CMAKE_CURRENT_BINARY_DIR}/regress_${testfile}")
-    elseif(TNAME MATCHES "^(extrude|facedef|mirface|permute)$")
-      set(TEST_EXPECT "'${TNAME}' testing completed")
-      set(TEST_SOURCE "${CMAKE_CURRENT_BINARY_DIR}/regress_${testfile}")
-    elseif(TNAME STREQUAL "edgedir")
-      set(TEST_EXPECT "'edarb edgedir' testing completed")
-      set(TEST_SOURCE "${CMAKE_CURRENT_BINARY_DIR}/regress_${testfile}")
     elseif(TNAME STREQUAL "killtree")
       set(TEST_EXPECT "KILL Solid:  killtree_dup.s")
       set(TEST_REJECT "db_lookup(killtree_dup.s) failed")
@@ -146,10 +138,6 @@ if(TARGET mged)
     elseif(TNAME STREQUAL "prim_edit")
       set(TEST_EXPECT "Primitive parameter editing testing completed")
       set(TEST_REJECT "FAIL:")
-    elseif(TNAME STREQUAL "sed_reset")
-      set(TEST_EXPECT "PASS: 'sed_reset' testing completed")
-      set(TEST_REJECT "FAIL:")
-      set(TEST_SOURCE "${CMAKE_CURRENT_BINARY_DIR}/regress_${testfile}")
     elseif(TNAME STREQUAL "overlap_plotting")
       set(TEST_DB "${CMAKE_SOURCE_DIR}/src/libged/tests/ged_tests.g")
       set(TEST_EXPECT "PASS overlap plotting")
@@ -199,7 +187,6 @@ distclean(${mged_outfiles})
 
 cmakefiles(
   CMakeLists.txt
-  csg_edit.mged
   mged.tcl
   regression_resources.tcl
   search_exec_procs.tcl

regress/mged/arb.mged

@@ -119,35 +119,4 @@ if {![catch {get $invalid_inner}]} {
 }
 
 
-# ARBN uses one independent thickness per plane.  Exercise unequal offsets so
-# the test also verifies the plane ordering and inward normal convention.
-set arbn_outer inside_arbn_outer.s
-set arbn_inner inside_arbn_inner.s
-set arbn_thicknesses {1 2 3 4 1.5 0.5}
-in $arbn_outer arbn 6 \
-    1 0 0 10  -1 0 0 0 \
-    0 1 0 10   0 -1 0 0 \
-    0 0 1 10   0 0 -1 0
-if {[catch {inside $arbn_outer $arbn_inner {*}$arbn_thicknesses} result]} {
-    error "inside failed for ARBN: $result"
-}
-set arbn_definition [get $arbn_inner]
-set expected_offsets {9 -2 7 -4 8.5 -0.5}
-for {set plane 0} {$plane < 6} {incr plane} {
-    set equation [lindex $arbn_definition [expr {4 + 2 * $plane}]]
-    set actual_offset [lindex $equation 3]
-    if {abs($actual_offset - [lindex $expected_offsets $plane]) > $plane_tolerance} {
-	error "ARBN inside plane $plane has offset $actual_offset: $arbn_definition"
-    }
-}
-facetize -n inside_arbn_inner_nmg.s $arbn_inner
-
-set invalid_arbn_inner inside_arbn_invalid.s
-if {![catch {inside $arbn_outer $invalid_arbn_inner {*}[lrepeat 6 6]}]} {
-    error "ARBN inside accepted thicknesses that collapse the solid"
-}
-if {![catch {get $invalid_arbn_inner}]} {
-    error "ARBN inside wrote an invalid collapsed solid"
-}
-
 puts "*** 'arb' testing completed ***"

regress/mged/csg_edit.mged

@@ -962,140 +962,8 @@ foreach test [list \
     csg_matrix_mouse_check {*}$test
 }
 
-puts "--- Repeated graphical object transforms ---"
-proc csg_matrix_repeated_mouse_check {} {
-    global orig_gui transform csg_mouse_dm_pixels csg_mouse_view_size
-    global csg_drag_scale
-    set prim csg_matrix_repeat.s
-    set inner csg_matrix_repeat_inner.c
-    set outer csg_matrix_repeat_outer.c
-    set saved_orig_gui $orig_gui
-    set expected [csg_edit_identity_matrix]
-    set failed [catch {
-        in $prim sph 0 0 0 10
-        comb $inner u $prim
-        comb $outer u $inner
-        set orig_gui 0
-        for {set step 0} {$step < 16} {incr step} {
-            e $outer
-            center 0 0 0
-            size $csg_mouse_view_size
-            setview 0 0 0
-            dm size $csg_mouse_dm_pixels $csg_mouse_dm_pixels
-            _mged_press oill
-            _mged_ill -e -i 1 /$outer/$inner/$prim
-            _mged_matpick 2
-            if {[status state] ne "OBJ EDIT" || $transform ne "e"} {
-                error "step $step did not enter object editing"
-            }
-            set view_before [csg_edit_view_state]
-            if {$step % 2 == 0} {
-                press Rotate
-                dm con r z 100 100
-                set operation [csg_matrix_axis_rotation z 10]
-                set motion {dm motion 140 100}
-            } else {
-                press Scale
-                dm am s 100 100
-                set operation [csg_matrix_scale all $csg_drag_scale]
-                set motion {dm motion 164 100}
-            }
-            set motion_code [catch {uplevel #0 $motion} motion_result]
-            if {$motion_code != 0 && $motion_code != 2} {
-                error "step $step mouse motion failed: $motion_result"
-            }
-            dm idle
-            press accept
-            set expected [csg_matrix_multiply $operation $expected]
-            csg_edit_comb_leaf_matrix_at $inner $prim $expected
-            csg_edit_view_state_at $view_before
-            d $outer
-        }
-    } failure]
-    set orig_gui $saved_orig_gui
-    catch {press reject}
-    catch {Z}
-    foreach object [list $outer $inner $prim] {
-        catch {kill $object}
-    }
-    if {$failed} {
-        puts "  FAIL: repeated object mouse rotations/scales ($failure)"
-    } else {
-        puts "  PASS: repeated object mouse rotations/scales"
-    }
-}
-csg_matrix_repeated_mouse_check
-
 puts "--- All ARB point, edge, and face states ---"
 
-proc csg_edit_sed_point {attribute} {
-    set serialized [get_sed]
-    set index [lsearch -exact $serialized $attribute]
-    if {$index < 0 || $index + 1 >= [llength $serialized]} {
-        error "get_sed has no $attribute: $serialized"
-    }
-    return [lindex $serialized [expr {$index + 1}]]
-}
-
-proc csg_arb_repeated_mouse_check {} {
-    global orig_gui csg_bv_coord_half_range csg_mouse_dm_pixels
-    global csg_mouse_view_size
-    set source csg_lifecycle_arb5.s
-    set prim csg_arb_repeat.s
-    set saved_orig_gui $orig_gui
-    set expected {}
-    set failed [catch {
-        cp $source $prim
-        e $prim
-        center 0 0 0
-        size $csg_mouse_view_size
-        setview 0 0 0
-        dm size $csg_mouse_dm_pixels $csg_mouse_dm_pixels
-        set orig_gui 0
-        sed $prim
-        press {Move Edges}
-        press {Move Point 5}
-        set original_z [lindex [db get $source V5] 2]
-        for {set step 0} {$step < 64} {incr step} {
-            if {$step > 0 && $step % 8 == 0} {
-                press sedit
-                press {Move Edges}
-                press {Move Point 5}
-            }
-            set mouse_x [expr {150 + 2 * ($step % 5)}]
-            set mouse_y [expr {150 + 2 * (($step * 3) % 5)}]
-            M 1 $mouse_x $mouse_y
-            set expected [list \
-                [expr {$mouse_x / $csg_bv_coord_half_range * $csg_mouse_view_size / 2.0}] \
-                [expr {$mouse_y / $csg_bv_coord_half_range * $csg_mouse_view_size / 2.0}] \
-                $original_z]
-            set actual [csg_edit_sed_point V5]
-            if {[csg_edit_point_distance $actual $expected] > 0.000001} {
-                error "step $step expected V5 $expected, got $actual"
-            }
-        }
-        press accept
-        d $prim
-        if {[csg_edit_point_distance [db get $prim V5] $expected] > 0.000001} {
-            error "accepted V5 differs from the final mouse target"
-        }
-        foreach vertex {V1 V2 V3 V4} {
-            csg_edit_point_matches_source $source $vertex $prim
-        }
-        arb_standard_storage_check arb5 $prim
-    } failure]
-    set orig_gui $saved_orig_gui
-    catch {press reject}
-    catch {d $prim}
-    catch {kill $prim}
-    if {$failed} {
-        puts "  FAIL: repeated ARB5 mouse movement ($failure)"
-    } else {
-        puts "  PASS: repeated ARB5 mouse movement"
-    }
-}
-csg_arb_repeated_mouse_check
-
 # Every ARB menu entry is checked independently.  The variants do not share
 # menu indices, so sampling one edge or face would miss precisely the class of
 # integration failure this test is intended to catch.  Move each selection a
@@ -1454,280 +1322,6 @@ csg_edit_sequence_check csg_lifecycle_dsp.s "Toggle Smooth" {
     {press {Toggle Smooth}}
 } [list csg_edit_scalar_at sm 1]
 
-puts "--- Specialized mouse editing and menu inventory ---"
-proc csg_edit_prepare_mouse_view {} {
-    global csg_dispatch_view_size
-    center 0 0 0
-    size $csg_dispatch_view_size
-    setview 0 0 0
-}
-array set csg_mouse_covered {}
-proc csg_mouse_case {source menu_items label commands validator} {
-    global csg_mouse_covered
-    csg_edit_sequence_check $source $label $commands $validator
-    set type [lindex [db get $source] 0]
-    if {![info exists csg_mouse_covered($type)]} {
-        set csg_mouse_covered($type) {}
-    }
-    foreach item $menu_items {
-        if {[lsearch -exact $csg_mouse_covered($type) $item] < 0} {
-            lappend csg_mouse_covered($type) $item
-        }
-    }
-}
-proc csg_edit_menu_inventory_check {source ignored} {
-    global csg_mouse_covered
-    if {[catch {
-        Z
-        e $source
-        sed $source
-        set actual [mmenu_get 0]
-        set type [lindex [db get $source] 0]
-        set covered {}
-        if {[info exists csg_mouse_covered($type)]} {
-            set covered $csg_mouse_covered($type)
-        }
-        foreach item $actual {
-            set tested [expr {[lsearch -exact $covered $item] >= 0}]
-            set exempt [expr {[lsearch -exact $ignored $item] >= 0}]
-            if {$tested == $exempt} {
-                error "menu entry '$item' needs exactly one mouse-test or exclusion"
-            }
-        }
-        foreach item [concat $covered $ignored] {
-            if {[lsearch -exact $actual $item] < 0} {
-                error "recorded menu entry '$item' is absent from $actual"
-            }
-        }
-        press reject
-        d $source
-    } failure]} {
-        puts "  FAIL: menu inventory $source ($failure)"
-        catch {press reject}
-        catch {Z}
-    } else {
-        puts "  PASS: menu inventory $source"
-    }
-}
-
-csg_edit_prepare_mouse_view
-set csg_special_mouse_target [list \
-    [expr {512.0 / $csg_bv_coord_half_range * $csg_dispatch_view_size / 2.0}] \
-    [expr {512.0 / $csg_bv_coord_half_range * $csg_dispatch_view_size / 2.0}] 0]
-set csg_special_mouse_scale [expr {1.0 + 2047.0 / ($csg_bv_coord_half_range * 4.0)}]
-set csg_special_mouse_shrink [expr {
-    1.0 / (1.0 + 1024.0 / ($csg_bv_coord_half_range * 4.0))}]
-csg_mouse_case csg_lifecycle_pipe.s {{Move Point}} "mouse select and move point" {
-    {csg_edit_prepare_mouse_view}
-    {press {Select Point}}
-    {p 0 0 0}
-    {press {Move Point}}
-    {M 1 512 512}
-} [list csg_edit_point_at V0 $csg_special_mouse_target]
-in csg_mouse_pipe_topology.s pipe 4 \
-    0 0 0 1 2 3 \
-    0 0 30 1 2 3 \
-    30 40 80 1 2 3 \
-    80 80 100 1 2 3
-csg_mouse_case csg_mouse_pipe_topology.s {{Select Point} {Move Point}} "mouse select point" {
-    {csg_edit_prepare_mouse_view}
-    {press {Select Point}}
-    {M 1 0 0}
-    {press {Move Point}}
-    {M 1 512 512}
-} [list csg_edit_point_at V0 $csg_special_mouse_target]
-csg_mouse_case csg_mouse_pipe_topology.s {{Append Point}} "mouse append point" {
-    {csg_edit_prepare_mouse_view}
-    {press {Append Point}}
-    {M 1 512 512}
-} [list csg_edit_point_at V4 {5 5 0}]
-csg_mouse_case csg_mouse_pipe_topology.s {{Prepend Point}} "mouse prepend point" {
-    {csg_edit_prepare_mouse_view}
-    {press {Prepend Point}}
-    {M 1 512 512}
-} [list csg_edit_point_at V0 {5 5 0}]
-csg_mouse_case csg_mouse_pipe_topology.s {{Split Segment}} "mouse split segment" {
-    {csg_edit_prepare_mouse_view}
-    {press {Select Point}}
-    {p 0 0 0}
-    {press {Split Segment}}
-    {M 1 512 512}
-} [list csg_edit_point_at V1 {5 5 0}]
-foreach {item attribute initial} {
-    {Set Point OD} O0 5
-    {Set Point ID} I0 3
-    {Set Point Bend} R0 6
-} {
-    csg_mouse_case csg_lifecycle_pipe.s [list $item] "mouse $item" [list \
-        {csg_edit_prepare_mouse_view} \
-        {press {Select Point}} {p 0 0 0} [list press $item] \
-        {M 1 0 -1024}] \
-        [list csg_edit_scalar_at $attribute [expr {$initial * $csg_special_mouse_shrink}]]
-}
-foreach {item attributes initial} {
-    {Set Pipe OD} {O0 O1 O2 O3} {5 5 6 6}
-    {Set Pipe ID} {I0 I1 I2 I3} {3 3 2 0}
-    {Set Pipe Bend} {R0 R1 R2 R3} {6 7 10 8}
-} {
-    set expected {}
-    foreach value $initial {
-        lappend expected [expr {$value * $csg_special_mouse_shrink}]
-    }
-    csg_mouse_case csg_lifecycle_pipe.s [list $item] "mouse $item" [list \
-        {csg_edit_prepare_mouse_view} \
-        [list press $item] {M 1 0 -1024}] \
-        [list csg_edit_scalar_values_at $attributes $expected]
-}
-proc csg_edit_bot_vertices_moved {source moved delta prim} {
-    set vertices [db get $source V]
-    for {set index 0} {$index < [llength $vertices]} {incr index} {
-        set expected [lindex $vertices $index]
-        if {[lsearch -exact $moved $index] >= 0} {
-            set translated {}
-            foreach value $expected shift $delta {
-                lappend translated [expr {$value + $shift}]
-            }
-            set expected $translated
-        }
-        csg_edit_list_value_at V $index $expected $prim
-    }
-}
-csg_mouse_case csg_lifecycle_bot.s {{Move Vertex}} "mouse move vertex" {
-    {csg_edit_prepare_mouse_view}
-    {press {Pick Vertex}}
-    {p 0}
-    {press {Move Vertex}}
-    {M 1 512 512}
-} [list csg_edit_bot_vertices_moved csg_lifecycle_bot.s {0} \
-    $csg_special_mouse_target]
-csg_mouse_case csg_lifecycle_bot.s {{Pick Vertex} {Move Vertex}} "mouse pick and move vertex" {
-    {csg_edit_prepare_mouse_view}
-    {press {Pick Vertex}}
-    {M 1 0 0}
-    {press {Move Vertex}}
-    {M 1 512 512}
-} [list csg_edit_bot_vertices_moved csg_lifecycle_bot.s {0} \
-    $csg_special_mouse_target]
-csg_mouse_case csg_lifecycle_bot.s {{Move Edge}} "mouse move edge" {
-    {csg_edit_prepare_mouse_view}
-    {press {Pick Edge}}
-    {p 0 1}
-    {press {Move Edge}}
-    {M 1 1024 512}
-} [list csg_edit_bot_vertices_moved csg_lifecycle_bot.s {0 1} {10 5 0}]
-csg_mouse_case csg_lifecycle_bot.s {{Pick Edge} {Move Edge}} "mouse pick and move edge" {
-    {csg_edit_prepare_mouse_view}
-    {press {Pick Edge}}
-    {M 1 512 512}
-    {press {Move Edge}}
-    {M 1 1024 512}
-} [list csg_edit_bot_vertices_moved csg_lifecycle_bot.s {0 1} {10 5 0}]
-csg_mouse_case csg_lifecycle_bot.s {{Move Triangle}} "mouse move triangle" {
-    {csg_edit_prepare_mouse_view}
-    {press {Pick Triangle}}
-    {p 0 1 2}
-    {press {Move Triangle}}
-    {M 1 512 512}
-} [list csg_edit_bot_vertices_moved csg_lifecycle_bot.s {0 1 2} \
-    $csg_special_mouse_target]
-csg_mouse_case csg_lifecycle_ebm.s {{Extrude Depth}} "mouse extrusion depth" {
-    {csg_edit_prepare_mouse_view}
-    {press {Extrude Depth}}
-    {M 1 0 2047}
-} [list csg_edit_scalar_at H [expr {4.0 * $csg_special_mouse_scale}]]
-csg_mouse_case csg_lifecycle_vol.s {{Threshold (low)}} "mouse low threshold" {
-    {csg_edit_prepare_mouse_view}
-    {press {Threshold (low)}}
-    {p 10}
-    {M 1 0 2047}
-} [list csg_edit_scalar_at lo [expr {int(10.0 * $csg_special_mouse_scale)}]]
-csg_mouse_case csg_lifecycle_vol.s {{Voxel Size (X Y Z)}} "mouse voxel size" {
-    {csg_edit_prepare_mouse_view}
-    {press {Voxel Size (X Y Z)}}
-    {M 1 0 2047}
-} [list csg_edit_point_at size [list \
-    $csg_special_mouse_scale $csg_special_mouse_scale $csg_special_mouse_scale]]
-csg_mouse_case csg_lifecycle_vol.s {{Threshold (hi)}} "mouse high threshold" {
-    {csg_edit_prepare_mouse_view}
-    {press {Threshold (hi)}}
-    {M 1 0 -1024}
-} [list csg_edit_scalar_at hi [expr {int(255.0 * $csg_special_mouse_shrink)}]]
-csg_mouse_case csg_lifecycle_dsp.s {{Set X}} "mouse X scale" {
-    {csg_edit_prepare_mouse_view}
-    {press {Set X}}
-    {M 1 0 2047}
-} [list csg_edit_matrix_component_at stom 0 $csg_special_mouse_scale]
-foreach {item index} {{Set Y} 5 {Set ALT} 10} {
-    csg_mouse_case csg_lifecycle_dsp.s [list $item] "mouse $item" [list \
-        {csg_edit_prepare_mouse_view} \
-        [list press $item] {M 1 0 2047}] \
-        [list csg_edit_matrix_component_at stom $index $csg_special_mouse_scale]
-}
-foreach type {arbn brep} {
-    set source csg_lifecycle_${type}.s
-    csg_edit_sequence_check $source "generic mouse translation" {
-        {csg_edit_prepare_mouse_view}
-        {keypoint 0 0 0}
-        {press sxy}
-        {M 1 512 512}
-    } [list csg_edit_bbox_translated $source $csg_special_mouse_target]
-}
-
-# Every specialized menu entry must be accounted for.  Exclusions are menu
-# headings, non-positional actions/settings, or the BOT triangle picker (tested
-# under Xmin because it needs Tk).  A new entry without a mouse case or
-# explicit exclusion fails here.
-foreach {source ignored} {
-    csg_lifecycle_pipe.s {
-        {PIPE MENU} {Next Point} {Previous Point} {Delete Point}
-    }
-    csg_lifecycle_bot.s {
-        {BOT MENU} {Pick Triangle} {Move Vertex List}
-        {Split Edge} {Split Face} {Fuse Vertices} {Fuse Faces}
-        {Delete Triangle} {Select Mode} {Select Orientation}
-        {Set flags} {Set Face Thickness} {Set Face Mode}
-    }
-    csg_lifecycle_dsp.s {
-        {DSP MENU} Name {Toggle Smooth} {Set Data Source}
-    }
-    csg_lifecycle_ebm.s {
-        {EBM MENU} {File Name} {File Size (W N)}
-    }
-    csg_lifecycle_vol.s {
-        {VOL MENU} {File Name} {File Size (X Y Z)}
-    }
-    csg_lifecycle_arbn.s {}
-    csg_lifecycle_brep.s {}
-} {
-    csg_edit_menu_inventory_check $source $ignored
-}
-
-# A view-space request must remain view-space even when the editor's current
-# coordinate system is object-relative.  This is the fast path underlying the
-# corresponding real mouse drag in the Xmin GUI test.
-set csg_saved_coords [rset var coords]
-set csg_saved_transform [rset var transform]
-if {[catch {
-    Z
-    e csg_lifecycle_bot.s
-    sed csg_lifecycle_bot.s
-    center 0 0 0
-    rset var coords o
-    rset var transform v
-    knob -i -v aX 1
-    if {[csg_edit_point_distance [center] {-1 0 0}] > 0.000001} {
-        error "explicit view knob left center at [center]"
-    }
-} csg_view_override_error]} {
-    puts "  FAIL: view-space translation with object coordinates ($csg_view_override_error)"
-} else {
-    puts "  PASS: view-space translation with object coordinates"
-}
-catch {press reject}
-catch {Z}
-rset var coords $csg_saved_coords
-rset var transform $csg_saved_transform
-
 file delete -force $csg_data_file
 file delete -force $csg_dsp_file
 

regress/mged/extrude.mged

@@ -43,37 +43,4 @@ foreach {arb_type face expected_type} $arb_extrude_cases {
     arb_standard_storage_check $expected_type $prim
 }
 
-# A one-inch extrusion must extend a face by 25.4 base millimeters through
-# both the direct libged command and MGED's interactive solid editor.
-set inch_in_mm 25.4
-set tolerance 0.001
-foreach mode {direct interactive} {
-    set suffix "_inch_$mode"
-    in_arb8 extrude $suffix
-    set prim "extrude_arb8${suffix}.s"
-    set base_x [lindex [db get $prim V1] 0]
-
-    units in
-    if {$mode eq "direct"} {
-	if {[catch {edarb extrude $prim 1234 1} result]} {
-	    error "inch edarb extrusion failed: $result"
-	}
-    } else {
-	Z
-	e $prim
-	sed $prim
-	if {[catch {extrude 1234 1} result]} {
-	    error "inch MGED extrusion failed: $result"
-	}
-	accept
-	Z
-    }
-    units mm
-
-    set new_x [lindex [db get $prim V5] 0]
-    if {abs($new_x - $base_x - $inch_in_mm) > $tolerance} {
-	error "inch $mode extrusion moved V5 by [expr {$new_x - $base_x}] mm"
-    }
-}
-
 puts "*** 'extrude' testing completed ***"

regress/mged/prim_edit.mged

@@ -31,7 +31,6 @@ in tor_pe.s tor 0 0 0  0 0 1  20 2
 prim_edit_check      tor_pe.s "Set Radius 1" 30 r_a 30 -1
 prim_edit_check      tor_pe.s "Set Radius 2"  5 r_h  5 -1
 prim_edit_mouse_check tor_pe.s "Set Radius 1" r_a 30 -1
-prim_edit_mouse_check tor_pe.s "Set Radius 2" r_h 5 -1
 kill tor_pe.s
 
 puts "--- ELL (ellipsoid: A, B, C) ---"
@@ -40,8 +39,6 @@ prim_edit_check      ell_pe.s "Set A" 8 A 8 0
 prim_edit_check      ell_pe.s "Set B" 6 B 6 1
 prim_edit_check      ell_pe.s "Set C" 4 C 4 2
 prim_edit_mouse_check ell_pe.s "Set A" A 8 0
-prim_edit_mouse_check ell_pe.s "Set B" B 6 1
-prim_edit_mouse_check ell_pe.s "Set C" C 4 2
 kill ell_pe.s
 
 puts "--- RPC (right parabolic cylinder: H, r) ---"
@@ -49,7 +46,6 @@ in rpc_pe.s rpc 0 0 0  0 0 10  0 5 0  3
 prim_edit_check      rpc_pe.s "Set H" 20 H 20 2
 prim_edit_check      rpc_pe.s "Set r"  6 r  6 -1
 prim_edit_mouse_check rpc_pe.s "Set H" H 20 2
-prim_edit_mouse_check rpc_pe.s "Set r" r 6 -1
 kill rpc_pe.s
 
 puts "--- RHC (right hyperbolic cylinder: H, r, c) ---"
@@ -58,8 +54,6 @@ prim_edit_check      rhc_pe.s "Set H" 20 H 20 2
 prim_edit_check      rhc_pe.s "Set r"  6 r  6 -1
 prim_edit_check      rhc_pe.s "Set c"  3 c  3 -1
 prim_edit_mouse_check rhc_pe.s "Set r" r 6 -1
-prim_edit_mouse_check rhc_pe.s "Set H" H 20 2
-prim_edit_mouse_check rhc_pe.s "Set c" c 3 -1
 kill rhc_pe.s
 
 puts "--- EPA (elliptical paraboloid: H, r_1, r_2) ---"
@@ -68,8 +62,6 @@ prim_edit_check      epa_pe.s "Set H" 20 H   20 2
 prim_edit_check      epa_pe.s "Set A"  8 r_1  8 -1
 prim_edit_check      epa_pe.s "Set B"  4 r_2  4 -1
 prim_edit_mouse_check epa_pe.s "Set H" H 20 2
-prim_edit_mouse_check epa_pe.s "Set A" r_1 8 -1
-prim_edit_mouse_check epa_pe.s "Set B" r_2 4 -1
 kill epa_pe.s
 
 puts "--- EHY (elliptical hyperboloid: H, r_1, c) ---"
@@ -78,8 +70,6 @@ prim_edit_check      ehy_pe.s "Set H" 20 H   20 2
 prim_edit_check      ehy_pe.s "Set A"  8 r_1  8 -1
 prim_edit_check      ehy_pe.s "Set c"  3 c    3 -1
 prim_edit_mouse_check ehy_pe.s "Set A" r_1 8 -1
-prim_edit_mouse_check ehy_pe.s "Set H" H 20 2
-prim_edit_mouse_check ehy_pe.s "Set c" c 3 -1
 kill ehy_pe.s
 
 puts "--- PART (particle: H, r_v, r_h) ---"
@@ -88,8 +78,6 @@ prim_edit_check      part_pe.s "Set H" 20 H   20 2
 prim_edit_check      part_pe.s "Set v"  4 r_v  4 -1
 prim_edit_check      part_pe.s "Set h"  3 r_h  3 -1
 prim_edit_mouse_check part_pe.s "Set v" r_v 4 -1
-prim_edit_mouse_check part_pe.s "Set H" H 20 2
-prim_edit_mouse_check part_pe.s "Set h" r_h 3 -1
 kill part_pe.s
 
 puts "--- TGC (truncated general cone: H, A, B, C, D) ---"
@@ -103,10 +91,6 @@ prim_edit_check      tgc_pe.s "Set B"  3 B   3 1
 prim_edit_check      tgc_pe.s "Set C"  3 C   3 0
 prim_edit_check      tgc_pe.s "Set D"  4 D   4 1
 prim_edit_mouse_check tgc_pe.s "Set H"  H 8 2
-prim_edit_mouse_check tgc_pe.s "Set A"  A 4 0
-prim_edit_mouse_check tgc_pe.s "Set B"  B 3 1
-prim_edit_mouse_check tgc_pe.s "Set C"  C 3 0
-prim_edit_mouse_check tgc_pe.s "Set D"  D 4 1
 kill tgc_pe.s
 
 puts "--- ETO (elliptical torus: r, C, D) ---"
@@ -116,7 +100,6 @@ prim_edit_check      eto_pe.s "Set r"  8   r   8   -1
 prim_edit_check      eto_pe.s "Set D"  1.5 r_d 1.5 -1
 prim_edit_mouse_check eto_pe.s "Set r"  r   8   -1
 prim_edit_mouse_check eto_pe.s "Set C"  C   5   0
-prim_edit_mouse_check eto_pe.s "Set D"  r_d 1.5 -1
 kill eto_pe.s
 
 puts "--- HYP (one-sheet hyperboloid: H, A, B, c) ---"
@@ -128,9 +111,6 @@ prim_edit_check      hyp_pe.s "Set A"  2   A   10   1
 prim_edit_check      hyp_pe.s "Set B"  2   b    4   -1
 prim_edit_check      hyp_pe.s "Set c"  0.5 bnr  0.25 -1
 prim_edit_mouse_check hyp_pe.s "Set H"  H  20   2
-prim_edit_mouse_check hyp_pe.s "Set A"  A  10   1
-prim_edit_mouse_check hyp_pe.s "Set B"  b  4    -1
-prim_edit_mouse_check hyp_pe.s "Set c"  bnr 0.25 -1
 kill hyp_pe.s
 
 puts "--- SUPERELL (superellipsoid: A, B, C) ---"
@@ -139,8 +119,6 @@ prim_edit_check      superell_pe.s "Set A" 5 A 5 0
 prim_edit_check      superell_pe.s "Set B" 4 B 4 1
 prim_edit_check      superell_pe.s "Set C" 3 C 3 2
 prim_edit_mouse_check superell_pe.s "Set A" A 5 0
-prim_edit_mouse_check superell_pe.s "Set B" B 4 1
-prim_edit_mouse_check superell_pe.s "Set C" C 3 2
 kill superell_pe.s
 
 puts "--- CLINE (cylinder line: H, R, plate thickness) ---"
@@ -151,7 +129,6 @@ prim_edit_check      cline_pe.s "Set R"              4   R 4   -1
 prim_edit_check      cline_pe.s "Set plate thickness" 0.4 T 0.4 -1
 prim_edit_mouse_check cline_pe.s "Set H" H 8   2
 prim_edit_mouse_check cline_pe.s "Set R" R 4   -1
-prim_edit_mouse_check cline_pe.s "Set plate thickness" T 0.4 -1
 kill cline_pe.s
 
 puts "--- NMG (non-manifold geometry: Pick Edge, Move Edge, Next EU) ---"

regress/mged/sed_reset.mged

@@ -1,64 +0,0 @@
-puts "*** Testing 'sed_reset' command ***"
-
-proc sed_reset_check {primitive edit_commands} {
-    e $primitive
-    sed $primitive
-    if {[status state] ne "SOL EDIT"} {
-	error "$primitive entered [status state], not SOL EDIT"
-    }
-
-    set original [get_sed]
-    foreach command $edit_commands {
-	uplevel #0 $command
-    }
-    if {[get_sed] eq $original} {
-	error "$primitive edit did not change the working geometry"
-    }
-
-    sed_reset
-    if {[status state] ne "SOL EDIT"} {
-	error "$primitive reset entered [status state], not SOL EDIT"
-    }
-    if {[get_sed] ne $original} {
-	error "$primitive reset did not restore the original geometry"
-    }
-
-    press reject
-    if {[status state] ne "VIEWING"} {
-	error "$primitive reject entered [status state], not VIEWING"
-    }
-    d $primitive
-}
-
-if {[catch {
-    in sed_reset_arb8.s arb8 \
-	0 0 0  10 0 0  10 10 0  0 10 0 \
-	0 0 10  10 0 10  10 10 10  0 10 10
-    sed_reset_check sed_reset_arb8.s {
-	{press {Move Faces}}
-	{press {Move Face 1234}}
-	{p 0 0 -1}
-    }
-} failure]} {
-    puts "FAIL: ARB8 face move reset ($failure)"
-    catch {press reject}
-    catch {Z}
-} else {
-    puts "PASS: ARB8 face move reset"
-}
-
-if {[catch {
-    make sed_reset_cline.s cline
-    sed_reset_check sed_reset_cline.s {
-	{press {Move End H}}
-	{p 3 4 12}
-    }
-} failure]} {
-    puts "FAIL: CLINE edit reset ($failure)"
-    catch {press reject}
-    catch {Z}
-} else {
-    puts "PASS: CLINE edit reset"
-}
-
-puts "PASS: 'sed_reset' testing completed"

regress/xmin/CMakeLists.txt

@@ -93,7 +93,6 @@ if(BRLCAD_X11_PROVIDER_RESOLVED STREQUAL "XMIN" AND
       "PLOT3_ASC_BIN=$<TARGET_FILE:plot3-asc>"
     )
     mged_add_xmin_gui_fixture(help "mged;dm-tkswrast;m35.g")
-    mged_add_xmin_gui_fixture(edit-interaction "mged;dm-tkswrast;m35.g")
     mged_add_xmin_gui_fixture(bot "mged;dm-tkswrast;m35.g")
     mged_add_xmin_gui_fixture(editors "mged;dm-tkswrast;m35.g")
     mged_add_xmin_gui_fixture(query-pattern "mged;dm-tkswrast;m35.g")
@@ -213,19 +212,18 @@ cmakefiles(
   mged/mged_xmin_gui.sh
   mged/xmin_gui_bot.tcl
   mged/xmin_gui_controls.tcl
-  mged/xmin_gui_edit.tcl
-  mged/xmin_gui_edit_interaction.tcl
   mged/xmin_gui_editors.tcl
   mged/xmin_gui_help.tcl
   mged/xmin_gui_lod.tcl
   mged/xmin_gui_overlaps.tcl
-  mged/xmin_gui_pipe_oracle.tcl
   mged/xmin_gui_query_pattern.tcl
   mged/xmin_gui_render_outputs.tcl
   mged/xmin_gui_search_exec.tcl
   mged/xmin_gui_shotvis.tcl
   mged/xmin_gui_test.tcl
   mged/xmin_gui_workflows.tcl
+  mged/xmin_gui_edit.tcl
+  mged/xmin_gui_pipe_oracle.tcl
 )
 
 # Local Variables:

regress/xmin/mged/xmin_gui_help.tcl

@@ -50,18 +50,6 @@ proc ::mged::xmin::help::exercise_command_manual {top} {
     ::gui::test::require {
 	[llength $selection] == 1 && [$toc get $selection] eq "rt"
     } "man rt did not select and load the rt manual page"
-
-    event generate $toc <<ListboxSelect>>
-    ::mged::gui::test::settle
-
-    man search
-    set html_view [$browser component browser].htmlview
-    set html_widget [$html_view html]
-    $html_view goto {#hierarchy_performance}
-    ::mged::gui::test::settle
-    ::gui::test::require {[lindex [$html_widget yview] 0] > 0.0} \
-	"manual browser did not follow an in-page hyperlink"
-
     ::gui::test::require {
 	[catch {man xmin_page_that_does_not_exist} message] &&
 	[string first "couldn't find manual page" $message] >= 0
@@ -163,38 +151,10 @@ proc ::mged::xmin::help::exercise_html_manual {top} {
     set mged_browser [file join $::env(GUI_TEST_DIR) missing-browser]
     ::mged::gui::test::invoke $top {Help Manual}
     set fallback $top.man
-    set viewer $fallback.html
     ::gui::test::require {
 	[winfo exists $fallback] && [winfo ismapped $fallback] &&
-	[winfo exists $viewer] && [$viewer title] eq "Table of Contents"
+	[string length [string trim [$fallback.text get 1.0 end]]] > 100
     } "Manual did not load MGED's internal HTML viewer"
-
-    set special_path [file join [pwd] {manual path} {contents#1.html}]
-    ::gui::test::require {
-	[::mged::manual::local_path \
-	    [::mged::manual::file_uri $special_path]] eq \
-	[file normalize $special_path]
-    } "internal Manual viewer did not preserve special path characters"
-
-    set html [$viewer html]
-    set contents [$html text text]
-    ::gui::test::require {
-	[string first "Preface" $contents] >= 0 &&
-	[string first "background-color" $contents] < 0
-    } "internal Manual viewer did not render its table of contents"
-
-    $viewer goto mged.html#csg
-    ::mged::gui::test::settle
-    set contents [$html text text]
-    ::gui::test::require {
-	[$viewer title] eq "Mged User's Manual" &&
-	[string first "Modeling With CSG" $contents] >= 0
-    } "internal Manual viewer did not follow its document links"
-
-    $fallback.f.back invoke
-    ::mged::gui::test::settle
-    ::gui::test::require {[$viewer title] eq "Table of Contents"} \
-	"internal Manual viewer Back button did not restore the prior page"
     destroy $fallback
 }
 

src/archer/CMakeLists.txt

@@ -53,23 +53,12 @@ endif(BRLCAD_ENABLE_TCL)
 # Archer plugins
 set(
   archer_utility_FILES
-  plugins/Utility/README
   plugins/Utility/attrGroupsDisplayUtilityP.tcl
-  plugins/Utility/attrGroupsDisplayUtilityP/AttrGroupsDisplayUtilityP.tcl
   plugins/Utility/botUtilityP.tcl
-  plugins/Utility/botUtilityP/BotUtilityP.tcl
   plugins/Utility/lodUtilityP.tcl
-  plugins/Utility/lodUtilityP/LODUtilityP.tcl
-)
-set(archer_wizard_FILES
-  plugins/Wizards/humanwizard.tcl
-  plugins/Wizards/humanwizard/HumanWizard.tcl
-  plugins/Wizards/tankwizard.tcl
-  plugins/Wizards/tankwizard/TankWizard.tcl
-  plugins/Wizards/tankwizard/images/tank.png
-  plugins/Wizards/tirewizard.tcl
-  plugins/Wizards/tirewizard/TireWizard.tcl
+  plugins/Utility/README
 )
+set(archer_wizard_FILES plugins/Wizards/humanwizard.tcl plugins/Wizards/tankwizard.tcl plugins/Wizards/tirewizard.tcl)
 
 if(BRLCAD_ENABLE_TCL)
   brlcad_adddata(archer_utility_FILES plugins/archer/Utility)
@@ -88,8 +77,6 @@ endif(BRLCAD_ENABLE_TCL)
 set(
   archer_ignore_files
   CMakeLists.txt
-  plugins/Commands/README
-  plugins/Core/README
   ${archer_utility_FILES}
   ${archer_wizard_FILES}
   ${archer_txt}

src/external/Creo/part.cpp

@@ -752,7 +752,7 @@ tessellate_part(struct creo_conv_info *cinfo, ProMdl model, struct bu_vls **snam
             }
 
         /* Check solidity */
-        success = !bg_trimesh_solid((int)vert_tree->curr_vert, (size_t)faces.size() / 3,
+        success = bg_trimesh_solid((int)vert_tree->curr_vert, (size_t)faces.size() / 3,
                                         vert_tree->the_array, &faces[0], NULL);
 
         /* If it's not solid and we're testing solidity, keep trying... */

src/gtools/gist/InformationGatherer.cpp

@@ -23,20 +23,10 @@
 #include "InformationGatherer.h"
 #include "bu/log.h"
 
-// flush results, if we have any, then exit
-static void reportAndExit(const std::string &message, const std::string &result = "")
-{
-    if (!result.empty())
-	bu_log("%s%s", result.c_str(), result.back() == '\n' ? "" : "\n");
-
-    bu_exit(BRLCAD_ERROR, "%s", message.c_str());
-}
-
-
 std::string getCmdPath(std::string exeDir, const char* cmd) {
     char buf[MAXPATHLEN] = {0};
     if (!bu_dir(buf, MAXPATHLEN, exeDir.c_str(), cmd, BU_DIR_EXT, NULL))
-	reportAndExit("Couldn't find " + std::string(cmd) + ", aborting.\n");
+        bu_exit(BRLCAD_ERROR, "Couldn't find %s, aborting.\n", cmd);
 
     return std::string(buf);
 }
@@ -68,13 +58,13 @@ getSurfaceArea(Options* opt, std::map<std::string, std::string> UNUSED(map), std
     bu_process_create(&p, rtarea_av, BU_PROCESS_HIDE_WINDOW | BU_PROCESS_OUT_EQ_ERR);
 
     if (bu_process_pid(p) <= 0) {
-	reportAndExit("Problem with getSurfaceArea, aborting\n");
+        bu_exit(BRLCAD_ERROR, "Problem with getSurfaceArea, aborting\n");
     }
 
     char buffer[128];
-    std::string result;
+    std::string result = "";
     int read_cnt = 0;
-    while ((read_cnt = bu_process_read_n(p, BU_PROCESS_STDOUT, sizeof(buffer) - 1, buffer)) > 0) {
+    while ((read_cnt = bu_process_read_n(p, BU_PROCESS_STDOUT, 128-1, buffer)) > 0) {
         /* NOTE: read does not ensure null-termination, thus buffersize-1 */
         buffer[read_cnt] = '\0';
         result += buffer;
@@ -90,7 +80,7 @@ getSurfaceArea(Options* opt, std::map<std::string, std::string> UNUSED(map), std
         try {
             surfArea += stod(result);
         } catch (const std::invalid_argument& ia) {
-	    reportAndExit("Invalid argument for getSurfaceArea. Got (" + std::string(ia.what()) + "), aborting.\n", result);
+            bu_exit(BRLCAD_ERROR, "Invalid argument for getSurfaceArea. Got (%s), aborting.\n", ia.what());
         }
     }
 }
@@ -210,7 +200,7 @@ getVerificationData(struct ged* UNUSED(g), Options* opt, std::map<std::string, s
     struct bu_process* p;
     int read_cnt = 0;
     char buffer[1024] = {0};
-    std::string result;
+    std::string result = "";
     std::string ncpu(std::to_string(opt->getNCPU()));
     std::string dFile(opt->getDensityFile());
 
@@ -243,23 +233,21 @@ getVerificationData(struct ged* UNUSED(g), Options* opt, std::map<std::string, s
     bu_process_create(&p, const_cast<const char**>(gqa_av_vec.data()), BU_PROCESS_HIDE_WINDOW | BU_PROCESS_OUT_EQ_ERR);
 
     if (bu_process_pid(p) <= 0) {
-	reportAndExit("Problem in getVerificationData gqa process creation, aborting\n");
+        bu_exit(BRLCAD_ERROR, "Problem in getVerificationData gqa process creation, aborting\n");
     }
 
-    while ((read_cnt = bu_process_read_n(p, BU_PROCESS_STDOUT, sizeof(buffer) - 1, buffer)) > 0) {
+    result = "";
+    while ((read_cnt = bu_process_read_n(p, BU_PROCESS_STDOUT, 1024-1, buffer)) > 0) {
         buffer[read_cnt] = '\0';
         result += buffer;
     }
 
-    const int gqa_status = bu_process_wait_n(&p, 0);
-
-    // sanity - we should have clean status code and not the "no density found" message
-    const bool no_density_data = result.find(no_density_msg) != std::string::npos;
-    if (gqa_status != 0 && (!no_density_data || !dFile.empty())) {
-	reportAndExit("Problem collecting gqa volume and mass, aborting\n", result);
+    if (bu_process_wait_n(&p, 0) != 0) {
+        bu_exit(BRLCAD_ERROR, "Problem collecting gqa volume and mass, aborting\n");
     }
 
-    if (!no_density_data) {
+    // make sure we did not get 'no density file' error message
+    if (result.find(no_density_msg) == std::string::npos) {
         // NOTE: tmp_val is zeroed at each parseLabeledNumber call
         if (parseLabeledNumber(tmp_val, result, volume_label))
             volume += tmp_val;
@@ -275,17 +263,17 @@ getVerificationData(struct ged* UNUSED(g), Options* opt, std::map<std::string, s
     bu_process_create(&p, const_cast<const char**>(gqa_av_vec.data()), BU_PROCESS_HIDE_WINDOW | BU_PROCESS_OUT_EQ_ERR);
 
     if (bu_process_pid(p) <= 0) {
-	reportAndExit("Problem in getVerificationData gqa process creation, aborting\n");
+        bu_exit(BRLCAD_ERROR, "Problem in getVerificationData gqa process creation, aborting\n");
     }
 
-    result.clear();
-    while ((read_cnt = bu_process_read_n(p, BU_PROCESS_STDOUT, sizeof(buffer) - 1, buffer)) > 0) {
+    result = "";
+    while ((read_cnt = bu_process_read_n(p, BU_PROCESS_STDOUT, 1024-1, buffer)) > 0) {
         buffer[read_cnt] = '\0';
         result += buffer;
     }
 
     if (bu_process_wait_n(&p, 0) != 0) {
-	reportAndExit("Problem collecting gqa volume, aborting\n", result);
+        bu_exit(BRLCAD_ERROR, "Problem collecting gqa volume, aborting\n");
     }
 
     if (parseLabeledNumber(tmp_val, result, volume_label))
@@ -393,7 +381,7 @@ InformationGatherer::getMainComp()
         ged_exec_exists(g, 2, cmd);
         std::string res = bu_vls_addr(g->ged_result_str);
         if (res != "1") {
-	    reportAndExit("Could not find component (" + topcomp + "), aborting.\n");
+            bu_exit(BRLCAD_ERROR, "Could not find component (%s), aborting.\n", topname);
         }
 
         int entities = getNumEntities(opt->getTopComp());

src/gtools/gist/pch.h

@@ -34,9 +34,6 @@
 
 // OpenCV header files
 #include <opencv2/opencv.hpp>
-#if CV_VERSION_MAJOR >= 5
-#include <opencv2/geometry.hpp>
-#endif
 #include <opencv2/core/core.hpp>
 #include "opencv2/highgui/highgui.hpp"
 

src/gtools/gqa.c

@@ -43,7 +43,6 @@ main(int argc, char *argv[])
     int i, j;
     int db_index;
     int c;
-    int ret;
     const char **av;
     struct ged *gedp;
 
@@ -104,14 +103,14 @@ main(int argc, char *argv[])
 	bu_exit(1, usage, argv[0]);
     }
 
-    ret = ged_exec_gqa(gedp, j, av);
+    (void)ged_exec_gqa(gedp, j, av);
     if (bu_vls_strlen(gedp->ged_result_str) > 0)
 	bu_log("%s", bu_vls_addr(gedp->ged_result_str));
     ged_close(gedp);
 
     bu_free((void *)av, "av");
 
-    return ret;
+    return 0;
 }
 
 

src/libanalyze/CMakeLists.txt

@@ -29,7 +29,6 @@ set(
   api.c
   centroid.c
   check_options.c
-  contour.cpp
   density.cpp
   globals.c
   inside.c
@@ -69,7 +68,7 @@ set(
 cmakefiles(${libanalyze_ignored_files})
 
 # Note - libanalyze_deps is defined by ${BRLCAD_SOURCE_DIR}/src/source_dirs.cmake
-brlcad_addlib(libanalyze "${LIBANALYZE_SOURCES}" "" "${CMAKE_CURRENT_BINARY_DIR};${EIGEN3_INCLUDE_DIR}"
+brlcad_addlib(libanalyze "${LIBANALYZE_SOURCES}" "" "${CMAKE_CURRENT_BINARY_DIR}"
   PUBLIC_LIBS ${libanalyze_deps}
 )
 set_target_properties(libanalyze PROPERTIES VERSION 20.0.1 SOVERSION 20)

src/libanalyze/tests/CMakeLists.txt

@@ -1,6 +1,3 @@
-brlcad_addexec(analyze_contour contour.cpp "libanalyze;libwdb;librt;libbg;libbu" TEST)
-brlcad_add_test(NAME analyze_contour COMMAND analyze_contour)
-
 brlcad_addexec(analyze_raydiff raydiff.c "libanalyze;librt;libbu" TEST)
 brlcad_addexec(analyze_sp solid_partitions.c "libanalyze;librt;libbu" TEST)
 brlcad_addexec(analyze_nhit nhit.cpp "libanalyze;librt;libbu" TEST_USESDATA)
@@ -16,7 +13,6 @@ brlcad_add_test(NAME analyze_densities_std        COMMAND analyze_densities std)
 cmakefiles(
   CMakeLists.txt
   arbs.g
-  contour.cpp
   raydiff.g
 )
 

src/libanalyze/tests/contour.cpp

@@ -1,425 +0,0 @@
-/*               A N A L Y Z E _ C O N T O U R . C P P
- * BRL-CAD
- *
- * Copyright (c) 2026 United States Government as represented by
- * the U.S. Army Research Laboratory.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * 1. Redistributions of source code must retain the above copyright notice,
- * this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
- * AND ANY EXPRESS OR IMPLIED WARRANTIES ARE DISCLAIMED.
- */
-/** @file contour.cpp
- *
- * Basic topology and resource-limit tests for analyze_mdc().
- */
-
-#include "common.h"
-
-#include <algorithm>
-#include <climits>
-#include <cmath>
-#include <cstdio>
-#include <set>
-#include <utility>
-
-#include "bu/app.h"
-#include "bu/malloc.h"
-#include "bg/trimesh.h"
-#include "analyze/contour.h"
-#include "analyze/polygonize.h"
-#include "raytrace.h"
-#include "wdb.h"
-
-static constexpr double METRIC_RELATIVE_TOLERANCE = 0.10;
-
-static int failures = 0;
-
-
-static void
-expect(bool condition, const char *message)
-{
-    if (condition)
-	return;
-
-    std::fprintf(stderr, "FAIL: %s\n", message);
-    failures++;
-}
-
-
-static void
-expect_metric(double actual, double expected, const char *object,
-	const char *metric)
-{
-    double relative_error = std::fabs(actual - expected) / expected;
-    if (actual >= 0.0 && relative_error <= METRIC_RELATIVE_TOLERANCE)
-	return;
-
-    std::fprintf(stderr,
-	    "FAIL: %s %s is %.17g, expected %.17g (relative error %.2f%%)\n",
-	    object, metric, actual, expected, 100.0 * relative_error);
-    failures++;
-}
-
-
-static void
-check_mesh(struct db_i *dbip, const char *object, int expected_components = 1,
-	double expected_area = 0.0, double expected_volume = 0.0,
-	size_t minimum_faces = 4, int expected_euler = INT_MAX)
-{
-    int *faces = NULL;
-    point_t *vertices = NULL;
-    size_t face_count = 0;
-    size_t vertex_count = 0;
-    struct analyze_mdc_params params = ANALYZE_MDC_PARAMS_DEFAULT;
-    params.min_depth = 4;
-    params.max_depth = 8;
-    params.max_rays = 0;
-    params.minimum_free_mem = 0;
-    params.max_time = 0;
-    params.verbosity = 0;
-
-    enum analyze_mdc_status status = analyze_mdc(&faces, &face_count,
-	    &vertices, &vertex_count, object, dbip, &params);
-    expect(status == ANALYZE_MDC_OK, object);
-    if (status == ANALYZE_MDC_OK) {
-	expect(vertex_count >= 4, "contour has vertices");
-	expect(face_count >= minimum_faces, "contour has expected resolution");
-	expect(bg_trimesh_solid2(static_cast<int>(vertex_count),
-		static_cast<int>(face_count),
-		reinterpret_cast<fastf_t *>(vertices), faces, NULL) == 0,
-		"contour is a closed oriented manifold");
-	if (expected_euler != INT_MAX) {
-	    std::set<std::pair<int, int>> edges;
-	    for (size_t face = 0; face < face_count; face++) {
-		for (size_t corner = 0; corner < 3; corner++) {
-		    int a = faces[3 * face + corner];
-		    int b = faces[3 * face + (corner + 1) % 3];
-		    edges.insert(std::minmax(a, b));
-		}
-	    }
-	    long long euler = static_cast<long long>(vertex_count) -
-		static_cast<long long>(edges.size()) +
-		static_cast<long long>(face_count);
-	    expect(euler == expected_euler,
-		    "contour has the expected Euler characteristic");
-	}
-	if (expected_area > 0.0)
-	    expect_metric(bg_trimesh_area(faces, face_count, vertices,
-		    vertex_count), expected_area, object, "surface area");
-	if (expected_volume > 0.0)
-	    expect_metric(bg_trimesh_volume(faces, face_count, vertices,
-		    vertex_count), expected_volume, object, "volume");
-
-	int *face_indices = NULL;
-	int *component_offsets = NULL;
-	int components = bg_trimesh_separate(&face_indices,
-		&component_offsets, faces, static_cast<int>(face_count));
-	expect(components == expected_components,
-		"contour has the expected connected components");
-	if (face_indices)
-	    bu_free(face_indices, "MDC test component faces");
-	if (component_offsets)
-	    bu_free(component_offsets, "MDC test component offsets");
-    }
-
-    if (faces)
-	bu_free(faces, "MDC test faces");
-    if (vertices)
-	bu_free(vertices, "MDC test vertices");
-}
-
-
-static bool
-make_region(struct rt_wdb *wdbp, const char *region, const char *solid)
-{
-    struct wmember member;
-    BU_LIST_INIT(&member.l);
-    if (!mk_addmember(solid, &member.l, NULL, WMOP_UNION))
-	return false;
-    return mk_lcomb(wdbp, region, &member, 1, NULL, NULL, NULL, 0) == 0;
-}
-
-
-int
-main(int UNUSED(argc), const char **argv)
-{
-    bu_setprogname(argv[0]);
-
-    struct db_i *dbip = db_create_inmem();
-    expect(dbip != NULL, "create in-memory database");
-    if (!dbip)
-	return 1;
-
-    struct rt_wdb *wdbp = wdb_dbopen(dbip, RT_WDB_TYPE_DB_INMEM);
-    expect(wdbp != NULL, "open in-memory database");
-    if (!wdbp) {
-	db_close(dbip);
-	return 1;
-    }
-
-    constexpr double sphere_radius = 10.0;
-    constexpr double torus_major_radius = 10.0;
-    constexpr double torus_minor_radius = 2.5;
-    constexpr double slender_torus_major_radius = 100.0;
-    constexpr double slender_torus_minor_radius = 2.0;
-    constexpr double lower_radius = 1.5;
-    constexpr double upper_radius = 1.0;
-
-    point_t center = VINIT_ZERO;
-    point_t minimum = {-8.0, -6.0, -4.0};
-    point_t maximum = {8.0, 6.0, 4.0};
-    expect(mk_sph(wdbp, "sphere.s", center, sphere_radius) == 0,
-	    "create test sphere");
-    expect(mk_rpp(wdbp, "box.s", minimum, maximum) == 0,
-	    "create test box");
-    point_t thin_minimum = {-5.0, -2.5, -0.05};
-    point_t thin_maximum = {5.0, 2.5, 0.05};
-    expect(mk_rpp(wdbp, "thin.s", thin_minimum, thin_maximum) == 0,
-	    "create thin-wall test box");
-
-    point_t tunnel_minimum = {-10.0, -10.0, -10.0};
-    point_t tunnel_maximum = {10.0, 10.0, 10.0};
-    point_t tunnel_base = {0.0, 0.0, -11.0};
-    vect_t tunnel_height = {0.0, 0.0, 22.0};
-    expect(mk_rpp(wdbp, "tunnel_outer.s", tunnel_minimum,
-	    tunnel_maximum) == 0, "create tunnel test outer box");
-    expect(mk_rcc(wdbp, "tunnel_void.s", tunnel_base, tunnel_height,
-	    1.0) == 0, "create tunnel test void");
-    struct wmember tunnel_members;
-    BU_LIST_INIT(&tunnel_members.l);
-    expect(mk_addmember("tunnel_outer.s", &tunnel_members.l, NULL,
-	    WMOP_UNION) != NULL, "add tunnel outer box");
-    expect(mk_addmember("tunnel_void.s", &tunnel_members.l, NULL,
-	    WMOP_SUBTRACT) != NULL, "subtract tunnel void");
-    expect(mk_lcomb(wdbp, "tunnel.r", &tunnel_members, 1, NULL, NULL,
-	    NULL, 0) == 0, "create tunnel test region");
-    vect_t normal = {0.0, 0.0, 1.0};
-    expect(mk_tor(wdbp, "torus.s", center, normal, torus_major_radius,
-	    torus_minor_radius) == 0,
-	    "create test torus");
-    expect(mk_tor(wdbp, "slender_torus.s", center, normal,
-	    slender_torus_major_radius, slender_torus_minor_radius) == 0,
-	    "create high-aspect torus");
-
-    point_t tgc_base = {-4.0, -3.0, -6.0};
-    vect_t tgc_height = {2.0, 1.0, 12.0};
-    vect_t tgc_a = {5.0, 0.0, 0.0};
-    vect_t tgc_b = {0.0, 3.0, 0.0};
-    vect_t tgc_c = {2.5, 0.0, 0.0};
-    vect_t tgc_d = {0.0, 1.5, 0.0};
-    expect(mk_tgc(wdbp, "tgc.s", tgc_base, tgc_height, tgc_a, tgc_b,
-	    tgc_c, tgc_d) == 0, "create test TGC");
-
-    point_t concave_arb[8] = {
-	{500.0, -500.0, -500.0},
-	{500.0, 500.0, -500.0},
-	{500.0, -169.922, -304.688},
-	{500.0, -500.0, 500.0},
-	{400.0, -500.0, -500.0},
-	{400.0, 500.0, -500.0},
-	{400.0, -169.922, -304.688},
-	{400.0, -500.0, 500.0}
-    };
-    expect(mk_arb8(wdbp, "concave.s",
-	    reinterpret_cast<const fastf_t *>(concave_arb)) == 0,
-	    "create sharp concave ARB");
-
-    point_t lower_center = {-8.0, -5.0, -3.0};
-    point_t upper_center = {9.0, 4.0, 6.0};
-    expect(mk_sph(wdbp, "lower.s", lower_center, lower_radius) == 0,
-	    "create lower disconnected sphere");
-    expect(mk_sph(wdbp, "upper.s", upper_center, upper_radius) == 0,
-	    "create upper disconnected sphere");
-    struct wmember members;
-    BU_LIST_INIT(&members.l);
-    expect(mk_addmember("lower.s", &members.l, NULL, WMOP_UNION) != NULL,
-	    "add lower disconnected sphere");
-    expect(mk_addmember("upper.s", &members.l, NULL, WMOP_UNION) != NULL,
-	    "add upper disconnected sphere");
-    expect(mk_lcomb(wdbp, "disconnected.r", &members, 1, NULL, NULL, NULL,
-	    0) == 0, "create disconnected region");
-
-    constexpr double overlap_radius = 5.0;
-    constexpr double overlap_offset = 3.0;
-    point_t overlap_left_center = {-overlap_offset, 0.0, 0.0};
-    point_t overlap_right_center = {overlap_offset, 0.0, 0.0};
-    expect(mk_sph(wdbp, "overlap_left.s", overlap_left_center,
-	    overlap_radius) == 0, "create left overlapping sphere");
-    expect(mk_sph(wdbp, "overlap_right.s", overlap_right_center,
-	    overlap_radius) == 0, "create right overlapping sphere");
-    expect(make_region(wdbp, "overlap_left.r", "overlap_left.s"),
-	    "create left overlapping region");
-    expect(make_region(wdbp, "overlap_right.r", "overlap_right.s"),
-	    "create right overlapping region");
-    struct wmember overlap_members;
-    BU_LIST_INIT(&overlap_members.l);
-    expect(mk_addmember("overlap_left.r", &overlap_members.l, NULL,
-	    WMOP_UNION) != NULL, "add left overlapping region");
-    expect(mk_addmember("overlap_right.r", &overlap_members.l, NULL,
-	    WMOP_UNION) != NULL, "add right overlapping region");
-    expect(mk_lcomb(wdbp, "overlap.c", &overlap_members, 0, NULL, NULL,
-	    NULL, 0) == 0, "create overlapping-region combination");
-
-    vect_t box_size;
-    VSUB2(box_size, maximum, minimum);
-
-    const double sphere_area = 4.0 * M_PI * sphere_radius * sphere_radius;
-    const double sphere_volume = 4.0 * M_PI * sphere_radius * sphere_radius *
-	sphere_radius / 3.0;
-    const double box_area = 2.0 * (box_size[X] * box_size[Y] +
-	box_size[X] * box_size[Z] + box_size[Y] * box_size[Z]);
-    const double box_volume = box_size[X] * box_size[Y] * box_size[Z];
-    vect_t thin_size;
-    VSUB2(thin_size, thin_maximum, thin_minimum);
-    const double thin_area = 2.0 * (thin_size[X] * thin_size[Y] +
-	thin_size[X] * thin_size[Z] + thin_size[Y] * thin_size[Z]);
-    const double thin_volume =
-	thin_size[X] * thin_size[Y] * thin_size[Z];
-    const double torus_area = 4.0 * M_PI * M_PI * torus_major_radius *
-	torus_minor_radius;
-    const double torus_volume = 2.0 * M_PI * M_PI * torus_major_radius *
-	torus_minor_radius * torus_minor_radius;
-    const double slender_torus_area = 4.0 * M_PI * M_PI *
-	slender_torus_major_radius * slender_torus_minor_radius;
-    const double disconnected_area = 4.0 * M_PI *
-	(lower_radius * lower_radius + upper_radius * upper_radius);
-    const double disconnected_volume = 4.0 * M_PI *
-	(lower_radius * lower_radius * lower_radius +
-	 upper_radius * upper_radius * upper_radius) / 3.0;
-    const double overlap_distance = 2.0 * overlap_offset;
-    const double overlap_cap_height = overlap_radius -
-	0.5 * overlap_distance;
-    const double overlap_intersection_volume = M_PI *
-	(4.0 * overlap_radius + overlap_distance) *
-	std::pow(2.0 * overlap_radius - overlap_distance, 2.0) / 12.0;
-    const double overlap_area = 8.0 * M_PI * overlap_radius *
-	overlap_radius - 4.0 * M_PI * overlap_radius * overlap_cap_height;
-    const double overlap_volume = 8.0 * M_PI * overlap_radius *
-	overlap_radius * overlap_radius / 3.0 -
-	overlap_intersection_volume;
-
-    check_mesh(dbip, "sphere.s", 1, sphere_area, sphere_volume);
-    check_mesh(dbip, "box.s", 1, box_area, box_volume);
-    check_mesh(dbip, "thin.s", 1, thin_area, thin_volume, 10000);
-    check_mesh(dbip, "torus.s", 1, torus_area, torus_volume, 4, 0);
-    check_mesh(dbip, "slender_torus.s", 1, slender_torus_area,
-	0.0, 4, 0);
-    check_mesh(dbip, "tunnel.r", 1, 0.0, 0.0, 4, 0);
-    check_mesh(dbip, "tgc.s");
-    check_mesh(dbip, "concave.s");
-    check_mesh(dbip, "disconnected.r", 2, disconnected_area,
-	disconnected_volume);
-    check_mesh(dbip, "overlap.c", 1, overlap_area, overlap_volume);
-
-    {
-	int *coarse_faces = NULL;
-	point_t *coarse_vertices = NULL;
-	size_t coarse_face_count = 0;
-	size_t coarse_vertex_count = 0;
-	struct analyze_mdc_params coarse = ANALYZE_MDC_PARAMS_DEFAULT;
-	coarse.min_depth = 3;
-	coarse.max_depth = 3;
-	coarse.max_rays = 50000;
-	coarse.minimum_free_mem = 0;
-	coarse.max_time = 0;
-	enum analyze_mdc_status coarse_status = analyze_mdc(&coarse_faces,
-		&coarse_face_count, &coarse_vertices, &coarse_vertex_count,
-		"tunnel.r", dbip, &coarse);
-	expect(coarse_status == ANALYZE_MDC_AMBIGUOUS,
-		"under-resolved tunnel requests refinement");
-	expect(!coarse_faces && !coarse_vertices && !coarse_face_count &&
-		coarse_vertex_count == 0,
-		"under-resolved tunnel leaves outputs empty");
-	if (coarse_faces)
-	    bu_free(coarse_faces, "coarse MDC test faces");
-	if (coarse_vertices)
-	    bu_free(coarse_vertices, "coarse MDC test vertices");
-    }
-
-    {
-	int *compatibility_faces = NULL;
-	point_t *compatibility_vertices = NULL;
-	int compatibility_face_count = 0;
-	int compatibility_vertex_count = 0;
-	point_t unused_seed = VINIT_ZERO;
-	struct analyze_polygonize_params compatibility =
-	    ANALYZE_POLYGONIZE_PARAMS_DEFAULT;
-	compatibility.max_time = 0;
-	compatibility.max_cycle_time = 0;
-	compatibility.minimum_free_mem = 0;
-
-	int status = analyze_polygonize(&compatibility_faces,
-		&compatibility_face_count, &compatibility_vertices,
-		&compatibility_vertex_count, 1.0, unused_seed, "sphere.s",
-		dbip, &compatibility);
-	expect(status == 0, "polygonize compatibility interface");
-	if (status == 0) {
-	    expect(compatibility_face_count >= 4,
-		    "compatibility contour has faces");
-	    expect(compatibility_vertex_count >= 4,
-		    "compatibility contour has vertices");
-	    expect(bg_trimesh_solid2(compatibility_vertex_count,
-		    compatibility_face_count,
-		    reinterpret_cast<fastf_t *>(compatibility_vertices),
-		    compatibility_faces, NULL) == 0,
-		    "compatibility contour is a closed oriented manifold");
-	}
-	if (compatibility_faces)
-	    bu_free(compatibility_faces, "compatibility test faces");
-	if (compatibility_vertices)
-	    bu_free(compatibility_vertices, "compatibility test vertices");
-
-	compatibility.max_time = 1;
-	compatibility.time_offset = 1;
-	expect(analyze_polygonize(&compatibility_faces,
-		&compatibility_face_count, &compatibility_vertices,
-		&compatibility_vertex_count, 1.0, unused_seed, "sphere.s",
-		dbip, &compatibility) == 2,
-		"compatibility interface preserves timeout status");
-	expect(!compatibility_faces && !compatibility_vertices &&
-		!compatibility_face_count && !compatibility_vertex_count,
-		"compatibility timeout leaves outputs empty");
-    }
-
-    int *faces = NULL;
-    point_t *vertices = NULL;
-    size_t face_count = 0;
-    size_t vertex_count = 0;
-    struct analyze_mdc_params limited = ANALYZE_MDC_PARAMS_DEFAULT;
-    limited.min_depth = 4;
-    limited.max_depth = 4;
-    limited.max_rays = 1;
-    limited.minimum_free_mem = 0;
-    expect(analyze_mdc(&faces, &face_count, &vertices, &vertex_count,
-	    "sphere.s", dbip, &limited) == ANALYZE_MDC_RAY_LIMIT,
-	    "ray limit is enforced during sampling");
-    expect(!faces && !vertices && !face_count && !vertex_count,
-	    "failure leaves outputs empty");
-
-    expect(analyze_mdc(NULL, &face_count, &vertices, &vertex_count,
-	    "sphere.s", dbip, NULL) == ANALYZE_MDC_INVALID_INPUT,
-	    "invalid output pointer is rejected");
-
-    db_close(dbip);
-    return failures ? 1 : 0;
-}
-
-/*
- * Local Variables:
- * mode: C++
- * tab-width: 8
- * c-basic-offset: 4
- * indent-tabs-mode: t
- * c-file-style: "stroustrup"
- * End:
- * ex: shiftwidth=4 tabstop=8
- */

src/libbg/clip.c

@@ -113,10 +113,10 @@ bg_lseg_clip(fastf_t *xp1, fastf_t *yp1, fastf_t *xp2, fastf_t *yp2, fastf_t cli
 int
 bg_ray_vclip(point_t a, point_t b, const fastf_t *min_pt, const fastf_t *max_pt)
 {
-    vect_t diff;
-    double sv;
-    double st;
-    double mindist, maxdist;
+    static vect_t diff;
+    static double sv;
+    static double st;
+    static double mindist, maxdist;
     fastf_t *pt = &a[0];
     fastf_t *dir = &diff[0];
     int i;

src/libbg/pca.cpp

@@ -22,7 +22,7 @@
 /** @file libbg/pca.cpp
  *
  * @brief
- * Principal Component Analysis.
+ * Principle Component Analysis.
  *
  */
 
@@ -74,7 +74,7 @@ bg_pca(point_t *c, vect_t *xa, vect_t *ya, vect_t *za, size_t npnts, const point
     }
 
     // 3.  Perform SVD
-    Eigen::JacobiSVD<Eigen::MatrixXd> svd(A, Eigen::ComputeFullU);
+    Eigen::JacobiSVD<Eigen::MatrixXd> svd(A, Eigen::ComputeThinU);
 
     // 4.  Extract the vectors from the U matrix
     vect_t xaxis, yaxis, zaxis;

src/libbg/plane.cpp

@@ -2620,50 +2620,20 @@ bg_lseg3_lseg3_parallel(const point_t sg1pt1, const point_t sg1pt2,
 }
 
 extern "C" int
-bg_plane_pt_nrml(plane_t *p, const point_t pt, const vect_t nrml)
+bg_plane_pt_nrml(plane_t *p, point_t pt, vect_t nrml)
 {
-    vect_t normal;
-    fastf_t normal_length;
-
-    if (!p || !pt || !nrml)
+    if (!p)
 	return -1;
-
-    VMOVE(normal, nrml);
-    normal_length = MAGNITUDE(normal);
-    if (normal_length <= SMALL_FASTF)
-	return -1;
-
-    VSCALE(normal, normal, 1.0 / normal_length);
-    (*p)[X] = normal[X];
-    (*p)[Y] = normal[Y];
-    (*p)[Z] = normal[Z];
-    (*p)[H] = VDOT(normal, pt);
-
+    vect_t unrml;
+    VMOVE(unrml, nrml);
+    VUNITIZE(nrml);
+    (*p)[0] = unrml[0];
+    (*p)[1] = unrml[1];
+    (*p)[2] = unrml[2];
+    (*p)[3] = unrml[0]*pt[0] + unrml[1]*pt[1] + unrml[2]*pt[2];
     return 0;
 }
 
-static int
-plane_coordinate_frame(point_t origin, vect_t xaxis, vect_t yaxis, const plane_t *p)
-{
-    vect_t normal;
-    fastf_t normal_length;
-
-    VSET(normal, (*p)[X], (*p)[Y], (*p)[Z]);
-    normal_length = MAGNITUDE(normal);
-    if (normal_length <= SMALL_FASTF)
-	return -1;
-
-    VSCALE(normal, normal, 1.0 / normal_length);
-    VSCALE(origin, normal, (*p)[H] / normal_length);
-    bn_vec_perp(xaxis, normal);
-    VUNITIZE(xaxis);
-    VCROSS(yaxis, normal, xaxis);
-    VUNITIZE(yaxis);
-
-    return 0;
-}
-
-
 // Use PCA fit a plane to vertex points
 extern "C" int
 bg_fit_plane(point_t *c, vect_t *n, size_t npnts, point_t *pnts)
@@ -2694,11 +2664,40 @@ bg_plane_closest_pt(fastf_t *u, fastf_t *v, plane_t *p, point_t *pt)
 	return -1;
 
     point_t origin;
-    vect_t xaxis, yaxis;
+    vect_t xaxis, yaxis, zaxis;
+    VSET(zaxis, (*p)[0], (*p)[1], (*p)[2]);
+    fastf_t x, y, z, d;
+    x = fabs((*p)[0]);
+    y = fabs((*p)[1]);
+    z = fabs((*p)[2]);
+    d = 0.0;
+    if ( y >= x && y >= z ) {
+	d = x;
+	x = y;
+	y = d;
+    } else if ( z >= x && z >= y ) {
+	d = x;
+	x = z;
+	z = d;
+    }
+    if ( x > SMALL_FASTF ) {
+	y /= x;
+	z /= x;
+	d = x*sqrt(1.0 + y*y + z*z);
+    } else if ( x > 0.0 && x < MAX_FASTF ) {
+	d = x;
+    }
 
-    if (plane_coordinate_frame(origin, xaxis, yaxis, p))
+    if (d < 0 || NEAR_ZERO(d, SMALL_FASTF))
 	return -1;
 
+    VMOVE(origin, zaxis);
+    VSCALE(origin, origin, 1/d*(*p)[3]);
+    VUNITIZE(zaxis);
+    bn_vec_perp(xaxis, zaxis);
+    VUNITIZE(xaxis);
+    VCROSS(yaxis, zaxis, xaxis);
+    VUNITIZE(yaxis);
     vect_t vc;
     VSUB2(vc, *pt, origin);
 
@@ -2712,15 +2711,45 @@ bg_plane_closest_pt(fastf_t *u, fastf_t *v, plane_t *p, point_t *pt)
 extern "C" int
 bg_plane_pt_at(point_t *pt, plane_t *p, fastf_t u, fastf_t v)
 {
-    if (!pt || !p)
+    if (!pt)
 	return -1;
 
     point_t origin;
-    vect_t xaxis, yaxis;
+    vect_t xaxis, yaxis, zaxis;
+    VSET(zaxis, (*p)[0], (*p)[1], (*p)[2]);
+    fastf_t x, y, z, d;
+    x = fabs((*p)[0]);
+    y = fabs((*p)[1]);
+    z = fabs((*p)[2]);
+    d = 0.0;
+    if ( y >= x && y >= z ) {
+	d = x;
+	x = y;
+	y = d;
+    } else if ( z >= x && z >= y ) {
+	d = x;
+	x = z;
+	z = d;
+    }
+    if ( x > SMALL_FASTF ) {
+	y /= x;
+	z /= x;
+	d = x*sqrt(1.0 + y*y + z*z);
+    } else if ( x > 0.0 && x < MAX_FASTF ) {
+	d = x;
+    }
 
-    if (plane_coordinate_frame(origin, xaxis, yaxis, p))
+    if (d < 0 || NEAR_ZERO(d, SMALL_FASTF))
 	return -1;
 
+    VMOVE(origin, zaxis);
+    VSCALE(origin, origin, 1/d*(*p)[3]);
+    VUNITIZE(zaxis);
+    bn_vec_perp(xaxis, zaxis);
+    VUNITIZE(xaxis);
+    VCROSS(yaxis, zaxis, xaxis);
+    VUNITIZE(yaxis);
+
     VSCALE(xaxis, xaxis, u);
     VSCALE(yaxis, yaxis, v);
     VADD2(origin, origin, xaxis);

src/libbg/polygon.c

@@ -83,7 +83,7 @@ bg_polygon_view_bbox(point2d_t *bmin, point2d_t *bmax, struct bg_polygon *p, mat
     // contours.  ONLY considering positive contour points.
     for (size_t i = 0; i < p->num_contours; i++) {
 	struct bg_poly_contour *c = &p->contour[i];
-	if ((p->hole && p->hole[i]) || !c->num_points)
+	if (!c->num_points)
 	    continue;
 	for (size_t j = 0; j < c->num_points; j++) {
 	    point_t vpoint;
@@ -143,45 +143,64 @@ bg_3d_polygon_area(fastf_t *area, size_t npts, const point_t *pts)
 int
 bg_3d_polygon_centroid(point_t *cent, size_t npts, const point_t *pts)
 {
-    point_t centroid = VINIT_ZERO;
-    vect_t normal = VINIT_ZERO;
-    vect_t edge0, edge1, cross;
-    fastf_t signed_area = 0.0;
+    size_t i;
+    fastf_t x_0 = 0.0;
+    fastf_t x_1 = 0.0;
+    fastf_t y_0 = 0.0;
+    fastf_t y_1 = 0.0;
+    fastf_t z_0 = 0.0;
+    fastf_t z_1 = 0.0;
+    fastf_t a = 0.0;
+    fastf_t signedArea = 0.0;
 
     if (!pts || !cent || npts < 3)
 	return 1;
-
-    for (size_t i = 1; i + 1 < npts; i++) {
-	VSUB2(edge0, pts[i], pts[0]);
-	VSUB2(edge1, pts[i + 1], pts[0]);
-	VCROSS(cross, edge0, edge1);
-	VADD2(normal, normal, cross);
+    /* Calculate Centroid projection for face for x-y-plane */
+    for (i = 0; i < npts-1; i++) {
+	x_0 = pts[i][0];
+	y_0 = pts[i][1];
+	x_1 = pts[i+1][0];
+	y_1 = pts[i+1][1];
+	a = x_0 *y_1 - x_1*y_0;
+	signedArea += a;
+	*cent[0] += (x_0 + x_1)*a;
+	*cent[1] += (y_0 + y_1)*a;
     }
-    if (MAGNITUDE(normal) <= SMALL_FASTF)
-	return 1;
-    VUNITIZE(normal);
+    x_0 = pts[i][0];
+    y_0 = pts[i][1];
+    x_1 = pts[0][0];
+    y_1 = pts[0][1];
+    a = x_0 *y_1 - x_1*y_0;
+    signedArea += a;
+    *cent[0] += (x_0 + x_1)*a;
+    *cent[1] += (y_0 + y_1)*a;
 
-    for (size_t i = 1; i + 1 < npts; i++) {
-	point_t triangle_centroid;
-	fastf_t triangle_area;
+    signedArea *= 0.5;
+    *cent[0] /= (6.0*signedArea);
+    *cent[1] /= (6.0*signedArea);
 
-	VSUB2(edge0, pts[i], pts[0]);
-	VSUB2(edge1, pts[i + 1], pts[0]);
-	VCROSS(cross, edge0, edge1);
-	triangle_area = VDOT(cross, normal);
-	signed_area += triangle_area;
-	VADD2(triangle_centroid, pts[0], pts[i]);
-	VADD2(triangle_centroid, triangle_centroid, pts[i + 1]);
-	VSCALE(triangle_centroid, triangle_centroid, triangle_area / 3.0);
-	VADD2(centroid, centroid, triangle_centroid);
+    /* calculate Centroid projection for face for x-z-plane */
+
+    signedArea = 0.0;
+    for (i = 0; i < npts-1; i++) {
+	x_0 = pts[i][0];
+	z_0 = pts[i][2];
+	x_1 = pts[i+1][0];
+	z_1 = pts[i+1][2];
+	a = x_0 *z_1 - x_1*z_0;
+	signedArea += a;
+	*cent[2] += (z_0 + z_1)*a;
     }
+    x_0 = pts[i][0];
+    z_0 = pts[i][2];
+    x_1 = pts[0][0];
+    z_1 = pts[0][2];
+    a = x_0 *z_1 - x_1*z_0;
+    signedArea += a;
+    *cent[2] += (z_0 + z_1)*a;
 
-    if (NEAR_ZERO(signed_area, SMALL_FASTF))
-	return 1;
-
-    VSCALE(centroid, centroid, 1.0 / signed_area);
-    VMOVE(*cent, centroid);
-
+    signedArea *= 0.5;
+    *cent[2] /= (6.0*signedArea);
     return 0;
 }
 
@@ -244,7 +263,6 @@ bg_3d_polygon_make_pnts_planes(size_t *npts, point_t **pts, size_t neqs, const p
 
 
 struct sort_ccw_data {
-    point_t centroid;
     vect_t x_axis;
     vect_t y_axis;
 };
@@ -254,26 +272,20 @@ static int
 sort_ccw_3d(const void *left, const void *right, void *context)
 {
     const struct sort_ccw_data *data = (const struct sort_ccw_data *)context;
-    const point_t *left_point = (const point_t *)left;
-    const point_t *right_point = (const point_t *)right;
-    vect_t left_offset, right_offset;
-    double left_angle, right_angle;
-    double left_radius, right_radius;
-
-    VSUB2(left_offset, *left_point, data->centroid);
-    VSUB2(right_offset, *right_point, data->centroid);
-    left_angle = atan2(VDOT(left_offset, data->y_axis),
-	    VDOT(left_offset, data->x_axis));
-    right_angle = atan2(VDOT(right_offset, data->y_axis),
-	    VDOT(right_offset, data->x_axis));
+    const fastf_t *left_point = (const fastf_t *)left;
+    const fastf_t *right_point = (const fastf_t *)right;
+    double left_angle = atan2(VDOT(left_point, data->y_axis),
+	    VDOT(left_point, data->x_axis));
+    double right_angle = atan2(VDOT(right_point, data->y_axis),
+	    VDOT(right_point, data->x_axis));
 
     if (left_angle < right_angle)
 	return -1;
     if (left_angle > right_angle)
 	return 1;
 
-    left_radius = MAGSQ(left_offset);
-    right_radius = MAGSQ(right_offset);
+    double left_radius = MAGSQ(left_point);
+    double right_radius = MAGSQ(right_point);
     if (left_radius < right_radius)
 	return -1;
     if (left_radius > right_radius)
@@ -286,10 +298,11 @@ int
 bg_3d_polygon_sort_ccw(size_t npts, point_t *pts, plane_t cmp)
 {
     size_t i;
+    point_t centroid;
     vect_t normal;
     struct sort_ccw_data data;
 
-    if (!pts || !cmp || npts < 3)
+    if (!pts || npts < 3)
 	return 1;
     if (MAGNITUDE(cmp) < VDIVIDE_TOL)
 	return 1;
@@ -299,13 +312,21 @@ bg_3d_polygon_sort_ccw(size_t npts, point_t *pts, plane_t cmp)
     bn_vec_ortho(data.x_axis, normal);
     VCROSS(data.y_axis, normal, data.x_axis);
 
-    VSETALL(data.centroid, 0.0);
+    /* Angular ordering is about the polygon center, not the model origin.
+     * Translate temporarily so the comparator only needs the plane axes. */
+    VSETALL(centroid, 0.0);
     for (i = 0; i < npts; i++)
-	VADD2(data.centroid, data.centroid, pts[i]);
-    VSCALE(data.centroid, data.centroid, 1.0 / (fastf_t)npts);
+	VADD2(centroid, centroid, pts[i]);
+    VSCALE(centroid, centroid, 1.0 / (double)npts);
+
+    for (i = 0; i < npts; i++)
+	VSUB2(pts[i], pts[i], centroid);
 
     bu_sort(pts, npts, sizeof(point_t), sort_ccw_3d, &data);
 
+    for (i = 0; i < npts; i++)
+	VADD2(pts[i], pts[i], centroid);
+
     return 0;
 }
 

src/libbg/spsr.cpp

@@ -8,8 +8,8 @@
  * modify it under the terms of the GNU Lesser General Public License
  * version 2.1 as published by the Free Software Foundation.
  *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * This library is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Lesser General Public License for more details.
  *
@@ -19,832 +19,170 @@
  */
 /** @file spsr.cpp
  *
- * Screened Poisson surface reconstruction for fixed and adaptive oriented
- * point sets.
+ * Interface to Adaptive Multigrid Solvers for Screened Poisson Surface Reconstruction
+ * Compatible with mkazhdan/PoissonRecon API (v18.x+).
+ *
  */
 
 #include "common.h"
-
-#include <algorithm>
-#include <array>
-#include <chrono>
-#include <cmath>
-#include <cstring>
-#include <exception>
-#include <limits>
-#include <memory>
-#include <mutex>
-#include <unordered_map>
-#include <utility>
-#include <vector>
-
 #include "vmath.h"
+#include "bu/log.h"
 #include "bu/malloc.h"
 #include "bg/spsr.h"
-#include "RTree.h"
-
 #if defined(__GNUC__) && !defined(__clang__)
-#  pragma GCC diagnostic push
+#  pragma GCC diagnostic push /* start new diagnostic pragma */
 #  pragma GCC diagnostic ignored "-Wall"
 #elif defined(__clang__)
-#  pragma clang diagnostic push
+#  pragma clang diagnostic push /* start new diagnostic pragma */
 #  pragma clang diagnostic ignored "-Weverything"
 #endif
 #include "SPSR/Reconstructors.h"
 #if defined(__GNUC__) && !defined(__clang__)
-#  pragma GCC diagnostic pop
+#  pragma GCC diagnostic pop /* end ignoring warnings */
 #elif defined(__clang__)
-#  pragma clang diagnostic pop
+#  pragma clang diagnostic pop /* end ignoring warnings */
 #endif
 
 using namespace PoissonRecon;
 
-namespace {
-
-using clock_type = std::chrono::steady_clock;
-using real_type = fastf_t;
-
-constexpr size_t SPSR_MAX_HINTS = 4096;
-constexpr size_t SPSR_MIN_NEIGHBORS = 4;
-constexpr double SPSR_NORMAL_ANGLE_DEGREES = 15.0;
-constexpr double SPSR_DEDUP_FRACTION = 0.25;
-constexpr int SPSR_MAX_DEPTH = 30;
-
-struct spsr_mesh {
-    std::vector<int> faces;
-    std::vector<real_type> vertices;
-};
-
+// Input stream for oriented samples: implements `read` for coordinates and normals
 template<typename Real, unsigned int Dim>
-struct point_stream : public Reconstructor::InputOrientedSampleStream<Real, Dim>
+struct PtStream : public Reconstructor::InputOrientedSampleStream<Real, Dim>
 {
-    point_stream(const std::vector<struct bg_3d_spsr_sample> &samples)
-        : current(0), input(samples)
+    PtStream(const point_t *ipnts, const vect_t *inorms, int cnt)
+	: _size(cnt), _current(0), _input_pnts(ipnts), _input_nrmls(inorms) {}
+    void reset(void) { _current = 0; }
+    bool read(Point<Real, Dim> &p, Point<Real, Dim> &n)
     {
+	if (_current < _size) {
+	    for (size_t d = 0; d < Dim; d++)
+		p[d] = _input_pnts[_current][d];
+	    for (size_t d = 0; d < Dim; d++)
+		n[d] = _input_nrmls[_current][d];
+	    _current++;
+	    return true;
+	}
+	return false;
     }
-
-    void reset(void)
-    {
-        current = 0;
-    }
-
-    bool read(Point<Real, Dim> &point, Point<Real, Dim> &normal)
-    {
-        if (current >= input.size())
-            return false;
-
-        for (size_t dimension = 0; dimension < Dim; dimension++) {
-            point[dimension] = input[current].point[dimension];
-            normal[dimension] = input[current].normal[dimension];
-        }
-        current++;
-        return true;
-    }
-
-  private:
-    size_t current;
-    const std::vector<struct bg_3d_spsr_sample> &input;
+    protected:
+    unsigned int _size, _current;
+    const point_t *_input_pnts;
+    const vect_t *_input_nrmls;
 };
 
-template<typename Index>
-struct polygon_stream : public Reconstructor::OutputFaceStream<2>
+// Output face stream: must implement write() and size()
+template <typename Index>
+struct PolygonStream : public Reconstructor::OutputFaceStream<2>
 {
-    polygon_stream(std::vector<std::vector<Index>> &output) : polygons(output)
-    {
-    }
-
-    size_t size(void) const
-    {
-        return polygons.size();
-    }
-
+    PolygonStream(std::vector<std::vector<Index>> &polygonStream) : _polygons(polygonStream) {}
+    size_t size(void) const { return _polygons.size(); }
     size_t write(const std::vector<node_index_type> &polygon)
     {
-        std::vector<Index> converted(polygon.size());
-        for (size_t i = 0; i < polygon.size(); i++)
-            converted[i] = static_cast<Index>(polygon[i]);
-        polygons.push_back(std::move(converted));
-        return polygons.size() - 1;
+	std::vector<Index> poly(polygon.size());
+	for (size_t i = 0; i < polygon.size(); i++) poly[i] = (Index)polygon[i];
+	_polygons.push_back(poly);
+	return _polygons.size() - 1;
     }
-
-  private:
-    std::vector<std::vector<Index>> &polygons;
+    protected:
+    std::vector<std::vector<Index>> &_polygons;
 };
 
-template<typename Real, unsigned int Dim>
-struct vertex_stream : public Reconstructor::OutputLevelSetVertexStream<Real, Dim>
+// Output vertex stream: must implement write() and size()
+template <typename Real, unsigned int Dim>
+struct VertexStream : public Reconstructor::OutputLevelSetVertexStream<Real, Dim>
 {
-    vertex_stream(std::vector<Real> &output) : coordinates(output)
+    VertexStream(std::vector<Real> &vCoordinates) : _vCoordinates(vCoordinates) {}
+    size_t size(void) const { return _vCoordinates.size() / Dim; }
+    size_t write(const Point<Real, Dim> &p, const Point<Real, Dim> &, const Real &)
     {
+	for (unsigned int d = 0; d < Dim; d++) _vCoordinates.push_back(p[d]);
+	return _vCoordinates.size() / Dim - 1;
     }
-
-    size_t size(void) const
-    {
-        return coordinates.size() / Dim;
-    }
-
-    size_t write(const Point<Real, Dim> &point, const Point<Real, Dim> &,
-        const Real &)
-    {
-        for (unsigned int dimension = 0; dimension < Dim; dimension++)
-            coordinates.push_back(point[dimension]);
-        return coordinates.size() / Dim - 1;
-    }
-
-  private:
-    std::vector<Real> &coordinates;
+    protected:
+    std::vector<Real> &_vCoordinates;
 };
 
-static double
-elapsed_seconds(const clock_type::time_point &start)
+extern "C" int
+bg_3d_spsr(int **faces, int *num_faces, point_t **points, int *num_pnts,
+	const point_t *input_points_3d, const vect_t *input_normals_3d,
+	int num_input_pnts, struct bg_3d_spsr_opts *spsr_opts)
 {
-    return std::chrono::duration<double>(clock_type::now() - start).count();
-}
+    using Real = fastf_t;
+    static const unsigned int FEMSig = FEMDegreeAndBType<Reconstructor::Poisson::DefaultFEMDegree, Reconstructor::Poisson::DefaultFEMBoundary>::Signature;
+    using FEMSigs = IsotropicUIntPack<3, FEMSig>;
 
-static bool
-finite_vector(const fastf_t *vector)
-{
-    return std::isfinite(vector[X]) && std::isfinite(vector[Y]) &&
-        std::isfinite(vector[Z]);
-}
+    // Set up multithreading
+    PoissonRecon::ThreadPool::ParallelizationType = PoissonRecon::ThreadPool::ASYNC;
 
-static bool
-valid_options(const struct bg_3d_spsr_opts &options)
-{
-    if (options.degree != BG_3D_SPSR_DEFAULT_DEGREE ||
-        options.btype != BG_3D_SPSR_BOUNDARY_NEUMANN ||
-        options.max_memory_GB != BG_3D_SPSR_DEFAULT_MAX_MEM ||
-        options.threads != BG_3D_SPSR_DEFAULT_THREADS ||
-        !NEAR_ZERO(options.confidence, SMALL_FASTF) ||
-        !NEAR_ZERO(options.confidence_bias, SMALL_FASTF))
-        return false;
+    // Solver and extraction parameters
+    Reconstructor::Poisson::SolutionParameters<Real> solverParams;
+    solverParams.verbose = false;
+    solverParams.depth = (spsr_opts) ? spsr_opts->depth : 8;
+    solverParams.fullDepth = (spsr_opts) ? spsr_opts->full_depth : 11;
+    solverParams.samplesPerNode = (spsr_opts) ? spsr_opts->samples_per_node : 1.5;
+    solverParams.exactInterpolation = true;
 
-    if (options.depth < 1 || options.depth > SPSR_MAX_DEPTH ||
-        options.kerneldepth < 0 || options.iterations < 0 ||
-        options.full_depth < 0 || options.base_depth < 0 ||
-        options.baseVcycles < 0 || options.samples_per_node <= 0.0 ||
-        options.scale < 1.0 || options.width < 0.0 ||
-        options.cgsolver_accuracy <= 0.0 || options.point_weight < 0.0)
-        return false;
+    Reconstructor::LevelSetExtractionParameters extractionParams;
+    extractionParams.forceManifold = true;
+    extractionParams.linearFit = false;
+    extractionParams.polygonMesh = false;
+    extractionParams.verbose = false;
 
-    return options.nonManifold >= 0 && options.nonManifold <= 1 &&
-        options.linearFit >= 0 && options.linearFit <= 1 &&
-        options.exact >= 0 && options.exact <= 1;
-}
+    PtStream<Real, 3> vstream(input_points_3d, input_normals_3d, num_input_pnts);
 
-static void
-set_solver_options(
-    Reconstructor::Poisson::SolutionParameters<real_type> &solver,
-    Reconstructor::LevelSetExtractionParameters &extraction,
-    const struct bg_3d_spsr_opts &options)
-{
-    solver.depth = static_cast<unsigned int>(options.depth);
-    solver.kernelDepth = options.kerneldepth ?
-        static_cast<unsigned int>(options.kerneldepth) :
-        static_cast<unsigned int>(-1);
-    solver.iters = options.iterations ?
-        static_cast<unsigned int>(options.iterations) : 8u;
-    solver.fullDepth = options.full_depth ?
-        static_cast<unsigned int>(options.full_depth) :
-        std::min(5u, solver.depth);
-    solver.baseDepth = options.base_depth ?
-        static_cast<unsigned int>(options.base_depth) :
-        static_cast<unsigned int>(-1);
-    solver.baseVCycles = options.baseVcycles ?
-        static_cast<unsigned int>(options.baseVcycles) : 1u;
-    solver.samplesPerNode = options.samples_per_node;
-    solver.scale = options.scale;
-    solver.width = options.width;
-    solver.cgSolverAccuracy = options.cgsolver_accuracy;
-    solver.pointWeight = options.point_weight;
-    solver.exactInterpolation = options.exact != 0;
-    solver.confidence = false;
-    solver.verbose = false;
-    solver.showResidual = false;
+    using Implicit = Reconstructor::Implicit<Real, 3, FEMSigs>;
+    using Solver = Reconstructor::Poisson::Solver<Real, 3, FEMSigs>;
+    Implicit *implicit = Solver::Solve(vstream, solverParams);
 
-    extraction.forceManifold = options.nonManifold == 0;
-    extraction.linearFit = options.linearFit != 0;
-    extraction.polygonMesh = false;
-    extraction.verbose = false;
-}
-
-static fastf_t
-sample_extent(const std::vector<struct bg_3d_spsr_sample> &samples)
-{
-    point_t minimum;
-    point_t maximum;
-    VSETALL(minimum, INFINITY);
-    VSETALL(maximum, -INFINITY);
-    for (const auto &sample : samples)
-        VMINMAX(minimum, maximum, sample.point);
-    return DIST_PNT_PNT(minimum, maximum);
-}
-
-class sample_set
-{
-  public:
-    sample_set(fastf_t tolerance, size_t limit) :
-        distance_tolerance(tolerance), distance_tolerance_sq(tolerance * tolerance),
-        point_limit(limit)
-    {
+    if (!implicit) {
+	bu_log("PoissonRecon: Solver::Solve failed\n");
+	return -1;
     }
 
-    bool append(const struct bg_3d_spsr_sample &input)
-    {
-        if (!finite_vector(input.point) || !finite_vector(input.normal))
-            return false;
-
-        struct bg_3d_spsr_sample sample = input;
-        fastf_t normal_length = MAGNITUDE(sample.normal);
-        if (!std::isfinite(normal_length) || normal_length <= VUNITIZE_TOL)
-            return false;
-        VSCALE(sample.normal, sample.normal, 1.0 / normal_length);
-
-        double minimum[3];
-        double maximum[3];
-        for (size_t dimension = 0; dimension < 3; dimension++) {
-            minimum[dimension] = sample.point[dimension] - distance_tolerance;
-            maximum[dimension] = sample.point[dimension] + distance_tolerance;
-        }
-
-        bool duplicate = false;
-        index.Search(minimum, maximum,
-            [&sample, this, &duplicate](const size_t &candidate, void *) {
-                if (DIST_PNT_PNT_SQ(sample.point, values[candidate].point) <=
-                    distance_tolerance_sq) {
-                    duplicate = true;
-                    return false;
-                }
-                return true;
-            }, NULL);
-        if (duplicate || (point_limit && values.size() >= point_limit))
-            return false;
-
-        size_t sample_index = values.size();
-        values.push_back(sample);
-        double point[3] = {
-            sample.point[X], sample.point[Y], sample.point[Z]
-        };
-        index.Insert(point, point, sample_index);
-        return true;
-    }
-
-    const std::vector<struct bg_3d_spsr_sample> &samples(void) const
-    {
-        return values;
-    }
-
-    bool full(void) const
-    {
-        return point_limit && values.size() >= point_limit;
-    }
-
-  private:
-    fastf_t distance_tolerance;
-    fastf_t distance_tolerance_sq;
-    size_t point_limit;
-    std::vector<struct bg_3d_spsr_sample> values;
-    RTree<size_t, double, 3> index;
-};
-
-static void
-append_hint(std::vector<struct bg_3d_spsr_refinement_hint> &hints,
-    const point_t point, const vect_t normal, fastf_t error,
-    unsigned int reasons)
-{
-    struct bg_3d_spsr_refinement_hint hint = {};
-    VMOVE(hint.point, point);
-    VMOVE(hint.normal, normal);
-    hint.error = error;
-    hint.reasons = reasons;
-    hints.push_back(hint);
-}
-
-template<typename Implicit>
-static void
-sample_hints(std::vector<struct bg_3d_spsr_refinement_hint> &hints,
-    const std::vector<struct bg_3d_spsr_sample> &samples,
-    const Implicit &implicit, fastf_t feature_size)
-{
-    const fastf_t normal_dot_limit =
-        std::cos(SPSR_NORMAL_ANGLE_DEGREES * DEG2RAD);
-    typename Implicit::Evaluator evaluator = implicit.evaluator();
-
-    for (const auto &sample : samples) {
-        Point<real_type, 3> point;
-        for (size_t dimension = 0; dimension < 3; dimension++)
-            point[dimension] = sample.point[dimension];
-
-        try {
-            Point<real_type, 3> gradient = evaluator.grad(point);
-            real_type gradient_length = std::sqrt(
-                gradient[0] * gradient[0] + gradient[1] * gradient[1] +
-                gradient[2] * gradient[2]);
-            unsigned int reasons = 0;
-            fastf_t error = feature_size;
-            vect_t normal;
-            VSET(normal, gradient[0], gradient[1], gradient[2]);
-
-            if (gradient_length <= VUNITIZE_TOL) {
-                reasons = BG_3D_SPSR_REFINE_RESIDUAL |
-                    BG_3D_SPSR_REFINE_NORMAL;
-                VSETALL(normal, 0.0);
-            } else {
-                fastf_t residual = std::fabs(
-                    evaluator(point) - implicit.isoValue) / gradient_length;
-                fastf_t normal_dot = std::fabs(
-                    VDOT(sample.normal, normal) / gradient_length);
-                if (residual > feature_size) {
-                    reasons |= BG_3D_SPSR_REFINE_RESIDUAL;
-                    error = residual;
-                }
-                if (normal_dot < normal_dot_limit) {
-                    reasons |= BG_3D_SPSR_REFINE_NORMAL;
-                    error = std::max(error,
-                        feature_size * (1.0 + normal_dot_limit - normal_dot));
-                }
-                VSCALE(normal, normal, 1.0 / gradient_length);
-            }
-
-            if (reasons)
-                append_hint(hints, sample.point, normal, error, reasons);
-        } catch (const std::exception &) {
-            append_hint(hints, sample.point, sample.normal,
-                2.0 * feature_size, BG_3D_SPSR_REFINE_RESIDUAL);
-        }
-    }
-}
-
-static void
-density_hints(std::vector<struct bg_3d_spsr_refinement_hint> &hints,
-    const std::vector<struct bg_3d_spsr_sample> &samples,
-    fastf_t feature_size)
-{
-    RTree<size_t, double, 3> index;
-    for (size_t i = 0; i < samples.size(); i++) {
-        double point[3] = {
-            samples[i].point[X], samples[i].point[Y], samples[i].point[Z]
-        };
-        index.Insert(point, point, i);
-    }
-
-    fastf_t search_distance_sq = feature_size * feature_size;
-    for (size_t i = 0; i < samples.size(); i++) {
-        double minimum[3];
-        double maximum[3];
-        for (size_t dimension = 0; dimension < 3; dimension++) {
-            minimum[dimension] =
-                samples[i].point[dimension] - feature_size;
-            maximum[dimension] =
-                samples[i].point[dimension] + feature_size;
-        }
-
-        size_t neighbor_count = 0;
-        index.Search(minimum, maximum,
-            [&samples, i, search_distance_sq, &neighbor_count](
-                const size_t &candidate, void *) {
-                if (DIST_PNT_PNT_SQ(samples[i].point,
-                        samples[candidate].point) <= search_distance_sq)
-                    neighbor_count++;
-                return neighbor_count < SPSR_MIN_NEIGHBORS;
-            }, NULL);
-
-        if (neighbor_count < SPSR_MIN_NEIGHBORS)
-            append_hint(hints, samples[i].point, samples[i].normal,
-                feature_size, BG_3D_SPSR_REFINE_DENSITY);
-    }
-}
-
-static void
-surface_variation_hints(
-    std::vector<struct bg_3d_spsr_refinement_hint> &hints,
-    const spsr_mesh &mesh, fastf_t feature_size)
-{
-    size_t vertex_count = mesh.vertices.size() / 3;
-    std::vector<std::array<fastf_t, 3>> first_normal(vertex_count);
-    std::vector<fastf_t> variation(vertex_count, 0.0);
-    std::vector<unsigned char> have_normal(vertex_count, 0);
-    const fastf_t variation_limit =
-        1.0 - std::cos(SPSR_NORMAL_ANGLE_DEGREES * DEG2RAD);
-
-    for (size_t face = 0; face < mesh.faces.size() / 3; face++) {
-        int ia = mesh.faces[3 * face];
-        int ib = mesh.faces[3 * face + 1];
-        int ic = mesh.faces[3 * face + 2];
-        const fastf_t *a = &mesh.vertices[3 * static_cast<size_t>(ia)];
-        const fastf_t *b = &mesh.vertices[3 * static_cast<size_t>(ib)];
-        const fastf_t *c = &mesh.vertices[3 * static_cast<size_t>(ic)];
-        vect_t ab;
-        vect_t ac;
-        vect_t normal;
-        VSUB2(ab, b, a);
-        VSUB2(ac, c, a);
-        VCROSS(normal, ab, ac);
-        fastf_t length = MAGNITUDE(normal);
-        if (length <= VUNITIZE_TOL)
-            continue;
-        VSCALE(normal, normal, 1.0 / length);
-
-        const int vertices[3] = {ia, ib, ic};
-        for (size_t corner = 0; corner < 3; corner++) {
-            size_t vertex = static_cast<size_t>(vertices[corner]);
-            if (!have_normal[vertex]) {
-                VMOVE(first_normal[vertex].data(), normal);
-                have_normal[vertex] = 1;
-            } else {
-                variation[vertex] = std::max(variation[vertex],
-                    1.0 - std::fabs(VDOT(first_normal[vertex].data(), normal)));
-            }
-        }
-    }
-
-    for (size_t vertex = 0; vertex < vertex_count; vertex++) {
-        if (variation[vertex] <= variation_limit)
-            continue;
-        const fastf_t *point = &mesh.vertices[3 * vertex];
-        append_hint(hints, point, first_normal[vertex].data(),
-            feature_size * (1.0 + variation[vertex]),
-            BG_3D_SPSR_REFINE_SURFACE_VARIATION);
-    }
-}
-
-static void
-limit_hints(std::vector<struct bg_3d_spsr_refinement_hint> &hints,
-    fastf_t feature_size)
-{
-    std::sort(hints.begin(), hints.end(),
-        [](const struct bg_3d_spsr_refinement_hint &left,
-           const struct bg_3d_spsr_refinement_hint &right) {
-            return left.error > right.error;
-        });
-
-    RTree<size_t, double, 3> locations;
-    std::vector<struct bg_3d_spsr_refinement_hint> selected;
-    selected.reserve(std::min(hints.size(), SPSR_MAX_HINTS));
-    fastf_t separation = feature_size * SPSR_DEDUP_FRACTION;
-    fastf_t separation_sq = separation * separation;
-
-    for (const auto &hint : hints) {
-        double minimum[3];
-        double maximum[3];
-        for (size_t dimension = 0; dimension < 3; dimension++) {
-            minimum[dimension] = hint.point[dimension] - separation;
-            maximum[dimension] = hint.point[dimension] + separation;
-        }
-
-        bool nearby = false;
-        locations.Search(minimum, maximum,
-            [&hint, &selected, separation_sq, &nearby](
-                const size_t &candidate, void *) {
-                if (DIST_PNT_PNT_SQ(hint.point,
-                        selected[candidate].point) <= separation_sq) {
-                    nearby = true;
-                    return false;
-                }
-                return true;
-            }, NULL);
-        if (nearby)
-            continue;
-
-        size_t hint_index = selected.size();
-        selected.push_back(hint);
-        double point[3] = {hint.point[X], hint.point[Y], hint.point[Z]};
-        locations.Insert(point, point, hint_index);
-        if (selected.size() == SPSR_MAX_HINTS)
-            break;
-    }
-
-    hints.swap(selected);
-}
-
-template<typename Implicit>
-static bool
-extract_mesh(spsr_mesh &mesh, const Implicit &implicit,
-    const Reconstructor::LevelSetExtractionParameters &parameters)
-{
     std::vector<std::vector<int>> polygons;
-    polygon_stream<int> faces(polygons);
-    vertex_stream<real_type, 3> vertices(mesh.vertices);
-    implicit.extractLevelSet(vertices, faces, parameters);
+    std::vector<Real> vCoordinates;
+    PolygonStream<int> pStream(polygons);
+    VertexStream<Real, 3> vStream(vCoordinates);
 
-    if (mesh.vertices.empty() || mesh.vertices.size() % 3 ||
-        mesh.vertices.size() / 3 >
-            static_cast<size_t>(std::numeric_limits<int>::max()) ||
-        polygons.empty() ||
-        polygons.size() > static_cast<size_t>(std::numeric_limits<int>::max()))
-        return false;
+    implicit->extractLevelSet(vStream, pStream, extractionParams);
 
-    mesh.faces.reserve(polygons.size() * 3);
-    for (const auto &polygon : polygons) {
-        if (polygon.size() != 3)
-            return false;
-        for (int vertex : polygon) {
-            if (vertex < 0 ||
-                static_cast<size_t>(vertex) >= mesh.vertices.size() / 3)
-                return false;
-            mesh.faces.push_back(vertex);
-        }
+    *num_faces = (int)(polygons.size());
+    *num_pnts = (int)(vCoordinates.size() / 3);
+    bu_log("Point cnt: %d\n", *num_pnts);
+    bu_log("Face cnt: %d\n", *num_faces);
+
+    // Allocate output arrays
+    (*faces) = (int *)bu_calloc(*num_faces * 3, sizeof(int), "faces array");
+    (*points) = (point_t *)bu_calloc(*num_pnts, sizeof(point_t), "points array");
+
+    // Copy faces (triangulated output expected)
+    for (int i = 0; i < *num_faces; i++) {
+	if (polygons[i].size() != 3) {
+	    bu_log("Warning: polygon %d is not a triangle (has %zu vertices)\n", i, polygons[i].size());
+	    // TODO - triangulate if we don't have a triangle.
+	    continue;
+	}
+	(*faces)[3*i+0] = polygons[i][0];
+	(*faces)[3*i+1] = polygons[i][1];
+	(*faces)[3*i+2] = polygons[i][2];
+    }
+    // Copy points
+    for (int i = 0; i < *num_pnts; i++) {
+	(*points)[i][X] = vCoordinates[3*i+0];
+	(*points)[i][Y] = vCoordinates[3*i+1];
+	(*points)[i][Z] = vCoordinates[3*i+2];
     }
 
-    return true;
+    delete implicit;
+    return 0;
 }
 
-static bool
-solve_once(spsr_mesh &mesh,
-    std::vector<struct bg_3d_spsr_refinement_hint> &hints,
-    const std::vector<struct bg_3d_spsr_sample> &samples,
-    const struct bg_3d_spsr_adaptive_opts &options)
-{
-    static std::mutex solver_mutex;
-    std::lock_guard<std::mutex> guard(solver_mutex);
 
-    static const unsigned int fem_signature =
-        FEMDegreeAndBType<Reconstructor::Poisson::DefaultFEMDegree,
-            Reconstructor::Poisson::DefaultFEMBoundary>::Signature;
-    using fem_signatures = IsotropicUIntPack<3, fem_signature>;
-    using implicit_type =
-        Reconstructor::Implicit<real_type, 3, fem_signatures>;
-    using solver_type =
-        Reconstructor::Poisson::Solver<real_type, 3, fem_signatures>;
-
-    Reconstructor::Poisson::SolutionParameters<real_type> solver_parameters;
-    Reconstructor::LevelSetExtractionParameters extraction_parameters;
-    set_solver_options(solver_parameters, extraction_parameters,
-        options.solver);
-
-    ThreadPool::ParallelizationType = ThreadPool::ASYNC;
-    point_stream<real_type, 3> points(samples);
-    std::unique_ptr<implicit_type> implicit(
-        solver_type::Solve(points, solver_parameters));
-    if (!implicit || !extract_mesh(mesh, *implicit, extraction_parameters))
-        return false;
-
-    if (options.target_feature_size > 0.0) {
-        sample_hints(hints, samples, *implicit,
-            options.target_feature_size);
-        density_hints(hints, samples, options.target_feature_size);
-        surface_variation_hints(hints, mesh,
-            options.target_feature_size);
-        limit_hints(hints, options.target_feature_size);
-    }
-
-    return true;
-}
-
-static bool
-copy_mesh(int **faces, int *face_count, point_t **vertices,
-    int *vertex_count, const spsr_mesh &mesh)
-{
-    size_t faces_size = mesh.faces.size() * sizeof(int);
-    size_t vertices_size = mesh.vertices.size() * sizeof(real_type);
-    int *new_faces = static_cast<int *>(bu_malloc(faces_size,
-        "SPSR face array"));
-    point_t *new_vertices = static_cast<point_t *>(bu_malloc(vertices_size,
-        "SPSR vertex array"));
-    if (!new_faces || !new_vertices) {
-        if (new_faces)
-            bu_free(new_faces, "SPSR face array");
-        if (new_vertices)
-            bu_free(new_vertices, "SPSR vertex array");
-        return false;
-    }
-
-    std::memcpy(new_faces, mesh.faces.data(), faces_size);
-    std::memcpy(new_vertices, mesh.vertices.data(), vertices_size);
-    *faces = new_faces;
-    *face_count = static_cast<int>(mesh.faces.size() / 3);
-    *vertices = new_vertices;
-    *vertex_count = static_cast<int>(mesh.vertices.size() / 3);
-    return true;
-}
-
-static void
-initialize_outputs(int **faces, int *face_count, point_t **vertices,
-    int *vertex_count, struct bg_3d_spsr_report *report)
-{
-    if (faces)
-        *faces = NULL;
-    if (face_count)
-        *face_count = 0;
-    if (vertices)
-        *vertices = NULL;
-    if (vertex_count)
-        *vertex_count = 0;
-    if (report)
-        std::memset(report, 0, sizeof(*report));
-}
-
-} // namespace
-
-extern "C" int
-bg_3d_spsr_adaptive(int **faces, int *num_faces, point_t **vertices,
-    int *num_vertices, const struct bg_3d_spsr_sample *input_samples,
-    size_t sample_count, const struct bg_3d_spsr_adaptive_opts *input_options,
-    bg_3d_spsr_refinement_func_t refine, void *client_data,
-    struct bg_3d_spsr_report *report)
-{
-    initialize_outputs(faces, num_faces, vertices, num_vertices, report);
-    if (!faces || !num_faces || !vertices || !num_vertices ||
-        !input_samples || !sample_count)
-        return BRLCAD_ERROR;
-
-    struct bg_3d_spsr_adaptive_opts default_options =
-        BG_3D_SPSR_ADAPTIVE_OPTS_DEFAULT;
-    const struct bg_3d_spsr_adaptive_opts &options =
-        input_options ? *input_options : default_options;
-    if (!valid_options(options.solver) ||
-        options.target_feature_size < 0.0 || options.max_time < 0.0 ||
-        (options.max_refinement_passes &&
-            (!refine || options.target_feature_size <= 0.0)) ||
-        (options.max_points && options.max_points < sample_count))
-        return BRLCAD_ERROR;
-
-    fastf_t extent = 0.0;
-    {
-        std::vector<struct bg_3d_spsr_sample> initial(
-            input_samples, input_samples + sample_count);
-        extent = sample_extent(initial);
-    }
-    if (!std::isfinite(extent) || extent <= SMALL_FASTF)
-        return BRLCAD_ERROR;
-
-    fastf_t deduplication_distance =
-        options.target_feature_size > 0.0 ?
-        options.target_feature_size * SPSR_DEDUP_FRACTION :
-        std::max(extent * 1.0e-12, static_cast<fastf_t>(SMALL_FASTF));
-    sample_set accumulated(deduplication_distance, options.max_points);
-    for (size_t i = 0; i < sample_count; i++)
-        accumulated.append(input_samples[i]);
-    if (accumulated.samples().empty())
-        return BRLCAD_ERROR;
-
-    const clock_type::time_point start = clock_type::now();
-    if (report)
-        report->initial_sample_count = accumulated.samples().size();
-
-    bool point_limit_reached = accumulated.full();
-    for (size_t pass = 0; ; pass++) {
-        if (options.max_time > 0.0 &&
-            elapsed_seconds(start) >= options.max_time) {
-            if (report)
-                report->termination = BG_3D_SPSR_TIME_LIMIT;
-            break;
-        }
-
-        spsr_mesh mesh;
-        std::vector<struct bg_3d_spsr_refinement_hint> hints;
-        try {
-            if (!solve_once(mesh, hints, accumulated.samples(), options)) {
-                if (report)
-                    report->termination = BG_3D_SPSR_SOLVER_ERROR;
-                break;
-            }
-        } catch (const std::exception &) {
-            if (report)
-                report->termination = BG_3D_SPSR_SOLVER_ERROR;
-            break;
-        } catch (...) {
-            if (report)
-                report->termination = BG_3D_SPSR_SOLVER_ERROR;
-            break;
-        }
-
-        if (report)
-            report->solve_count++;
-
-        if (!refine) {
-            if (copy_mesh(faces, num_faces, vertices, num_vertices, mesh)) {
-                if (report) {
-                    report->termination = BG_3D_SPSR_COMPLETE;
-                    report->validation.passed = 1;
-                    report->final_sample_count = accumulated.samples().size();
-                    report->elapsed_time = elapsed_seconds(start);
-                }
-                return BRLCAD_OK;
-            }
-            if (report)
-                report->termination = BG_3D_SPSR_SOLVER_ERROR;
-            break;
-        }
-
-        double remaining_time = options.max_time > 0.0 ?
-            std::max(0.0, options.max_time - elapsed_seconds(start)) : 0.0;
-        if (options.max_time > 0.0 && remaining_time <= 0.0) {
-            if (report)
-                report->termination = BG_3D_SPSR_TIME_LIMIT;
-            break;
-        }
-
-        struct bg_3d_spsr_refinement_request request = {};
-        request.pass = pass;
-        request.target_feature_size = options.target_feature_size;
-        request.remaining_time = remaining_time;
-        request.vertices =
-            reinterpret_cast<const point_t *>(mesh.vertices.data());
-        request.vertex_count = mesh.vertices.size() / 3;
-        request.faces = mesh.faces.data();
-        request.face_count = mesh.faces.size() / 3;
-        request.hints = hints.data();
-        request.hint_count = hints.size();
-
-        struct bg_3d_spsr_refinement_response response = {};
-        if (refine(&response, &request, client_data) != BRLCAD_OK) {
-            if (report)
-                report->termination = BG_3D_SPSR_CALLBACK_STOP;
-            break;
-        }
-        if (report)
-            report->validation = response.validation;
-
-        if (response.validation.passed) {
-            if (copy_mesh(faces, num_faces, vertices, num_vertices, mesh)) {
-                if (report) {
-                    report->termination = BG_3D_SPSR_COMPLETE;
-                    report->final_sample_count = accumulated.samples().size();
-                    report->elapsed_time = elapsed_seconds(start);
-                }
-                return BRLCAD_OK;
-            }
-            if (report)
-                report->termination = BG_3D_SPSR_SOLVER_ERROR;
-            break;
-        }
-        if (response.stop_refinement) {
-            if (report)
-                report->termination = BG_3D_SPSR_CALLBACK_STOP;
-            break;
-        }
-
-        if (pass == options.max_refinement_passes) {
-            if (report)
-                report->termination = point_limit_reached ?
-                    BG_3D_SPSR_POINT_LIMIT : BG_3D_SPSR_CALLBACK_STOP;
-            break;
-        }
-        if (response.sample_count && !response.samples) {
-            if (report)
-                report->termination = BG_3D_SPSR_CALLBACK_STOP;
-            break;
-        }
-
-        if (report)
-            report->requested_sample_count += response.sample_count;
-        size_t accepted = 0;
-        for (size_t i = 0; i < response.sample_count; i++) {
-            if (accumulated.append(response.samples[i]))
-                accepted++;
-        }
-        if (report)
-            report->accepted_sample_count += accepted;
-        point_limit_reached = accumulated.full();
-
-        if (!accepted) {
-            if (report)
-                report->termination = point_limit_reached ?
-                    BG_3D_SPSR_POINT_LIMIT : BG_3D_SPSR_NO_NEW_SAMPLES;
-            break;
-        }
-    }
-
-    if (report) {
-        report->final_sample_count = accumulated.samples().size();
-        report->elapsed_time = elapsed_seconds(start);
-    }
-    return BRLCAD_ERROR;
-}
-
-extern "C" int
-bg_3d_spsr(int **faces, int *num_faces, point_t **vertices, int *num_vertices,
-    const point_t *input_points_3d, const vect_t *input_normals_3d,
-    int num_input_pnts, struct bg_3d_spsr_opts *spsr_opts)
-{
-    if (!input_points_3d || !input_normals_3d || num_input_pnts <= 0)
-        return BRLCAD_ERROR;
-
-    std::vector<struct bg_3d_spsr_sample> samples(
-        static_cast<size_t>(num_input_pnts));
-    for (size_t i = 0; i < samples.size(); i++) {
-        VMOVE(samples[i].point, input_points_3d[i]);
-        VMOVE(samples[i].normal, input_normals_3d[i]);
-    }
-
-    struct bg_3d_spsr_adaptive_opts options =
-        BG_3D_SPSR_ADAPTIVE_OPTS_DEFAULT;
-    options.max_refinement_passes = 0;
-    if (spsr_opts)
-        options.solver = *spsr_opts;
-
-    return bg_3d_spsr_adaptive(faces, num_faces, vertices, num_vertices,
-        samples.data(), samples.size(), &options, NULL, NULL, NULL);
-}
-
-/*
- * Local Variables:
- * tab-width: 8
- * mode: C++
- * c-basic-offset: 4
- * indent-tabs-mode: t
- * c-file-style: "stroustrup"
- * End:
- * ex: shiftwidth=4 tabstop=8 cino=N-s
- */
+// Local Variables:
+// tab-width: 8
+// mode: C++
+// c-basic-offset: 4
+// indent-tabs-mode: t
+// c-file-style: "stroustrup"
+// End:
+// ex: shiftwidth=4 tabstop=8 cino=N-s

src/libbg/tests/CMakeLists.txt

@@ -33,10 +33,6 @@ brlcad_addexec(bg_aabb_ray aabb_ray.c "${BG_TEST_LIBS}" TEST)
 
 brlcad_add_test(NAME bg_aabb_ray COMMAND bg_aabb_ray)
 
-brlcad_addexec(bg_spsr spsr.cpp "${BG_TEST_LIBS}" TEST)
-
-brlcad_add_test(NAME bg_spsr COMMAND bg_spsr)
-
 brlcad_addexec(bg_polygon_sort polygon_sort.c "${BG_TEST_LIBS}" TEST)
 
 brlcad_add_test(NAME bg_polygon_sort COMMAND bg_polygon_sort)
@@ -146,7 +142,7 @@ brlcad_add_test(NAME bg_plane_mk_plane_3pts_succeed          COMMAND bg_test pla
 #
 #  A-D are plane equation parameters, and P is the test point.
 brlcad_add_test(NAME bg_plane_pt_project_1  COMMAND bg_test plane_pt 6  0,0,1,1 2,2,1)
-brlcad_add_test(NAME bg_plane_pt_project_2  COMMAND bg_test plane_pt 6  0.737397,0.461098,0.493593,236.3 77.526016919831704,185.674010580054585,189.465070961146)
+brlcad_add_test(NAME bg_plane_pt_project_2  COMMAND bg_test plane_pt 6  0.737397,0.461098,0.493593,236.3 77.526016919831704,185.674010580054585,189.465011325663767)
 
 # For function #7 (bg_coplanar_pts), the <args> format is as follows:
 #
@@ -310,24 +306,7 @@ brlcad_addexec(bg_line_distance line_distance.c "${BG_TEST_LIBS}" TEST)
 
 brlcad_add_test(NAME bg_line_distance COMMAND bg_line_distance)
 
-#  ************ plane coordinate tests ***********
-
-brlcad_addexec(bg_plane_coordinates plane_coordinates.c "${BG_TEST_LIBS}" TEST)
-
-brlcad_add_test(NAME bg_plane_coordinates COMMAND bg_plane_coordinates)
-
-#  ************ pca.c tests ***********
-
-brlcad_addexec(bg_pca pca.c "${BG_TEST_LIBS}" TEST)
-
-brlcad_add_test(NAME bg_pca COMMAND bg_pca)
-
 #  ************ polygon.c tests ***********
-
-brlcad_addexec(bg_polygon polygon.c "${BG_TEST_LIBS}" TEST)
-
-brlcad_add_test(NAME bg_polygon COMMAND bg_polygon)
-
 brlcad_addexec(bg_polygon_triangulate polygon_triangulate.c "${BG_TEST_LIBS}" TEST)
 
 brlcad_add_test(NAME bg_polygon_triangulate	    COMMAND bg_polygon_triangulate)
@@ -469,10 +448,6 @@ brlcad_addexec(bg_trimesh_area trimesh_area.c "${BG_TEST_LIBS}" TEST)
 
 #BRLCAD_ADD_TEST(NAME bg_trimesh_area  COMMAND bg_trimesh_area)
 
-brlcad_addexec(bg_trimesh_solid trimesh_solid.c "${BG_TEST_LIBS}" TEST)
-
-brlcad_add_test(NAME bg_trimesh_solid COMMAND bg_trimesh_solid)
-
 #  ************ trimesh_repair tests ***********
 
 brlcad_addexec(bg_trimesh_repair trimesh_repair.cpp "${BG_TEST_LIBS}" TEST)

src/libbg/tests/pca.c

@@ -1,70 +0,0 @@
-/*                           P C A . C
- * BRL-CAD
- *
- * Copyright (c) 2026 United States Government as represented by
- * the U.S. Army Research Laboratory.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public License
- * version 2.1 as published by the Free Software Foundation.
- *
- * This library is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- */
-
-#include "common.h"
-
-#include "bn.h"
-#include "bu.h"
-#include "bg.h"
-
-
-static int
-orthonormal_axes(const vect_t xaxis, const vect_t yaxis, const vect_t zaxis)
-{
-    return !NEAR_EQUAL(MAGSQ(xaxis), 1.0, BN_TOL_DIST)
-	|| !NEAR_EQUAL(MAGSQ(yaxis), 1.0, BN_TOL_DIST)
-	|| !NEAR_EQUAL(MAGSQ(zaxis), 1.0, BN_TOL_DIST)
-	|| !NEAR_ZERO(VDOT(xaxis, yaxis), BN_TOL_DIST)
-	|| !NEAR_ZERO(VDOT(xaxis, zaxis), BN_TOL_DIST)
-	|| !NEAR_ZERO(VDOT(yaxis, zaxis), BN_TOL_DIST);
-}
-
-
-int
-main(int argc, char **argv)
-{
-    const point_t one_point[] = {{1.0, 2.0, 3.0}};
-    const point_t two_points[] = {{1.0, 2.0, 3.0}, {5.0, 2.0, 3.0}};
-    const point_t one_center = {1.0, 2.0, 3.0};
-    const point_t two_center = {3.0, 2.0, 3.0};
-    const vect_t xaxis_expected = {1.0, 0.0, 0.0};
-    point_t center;
-    vect_t xaxis, yaxis, zaxis;
-    fastf_t alignment;
-    int failed = 0;
-
-    bu_setprogname(argv[0]);
-    if (argc != 1)
-	return 1;
-
-    if (bg_pca(&center, &xaxis, &yaxis, &zaxis, 1, one_point) != BRLCAD_OK ||
-	!VNEAR_EQUAL(center, one_center, BN_TOL_DIST) ||
-	orthonormal_axes(xaxis, yaxis, zaxis)) {
-	failed = 1;
-    }
-
-    if (bg_pca(&center, &xaxis, &yaxis, &zaxis, 2, two_points) != BRLCAD_OK ||
-	!VNEAR_EQUAL(center, two_center, BN_TOL_DIST) ||
-	orthonormal_axes(xaxis, yaxis, zaxis)) {
-	failed = 1;
-    }
-
-    alignment = VDOT(xaxis, xaxis_expected);
-    if (!NEAR_EQUAL(alignment * alignment, 1.0, BN_TOL_DIST))
-	failed = 1;
-
-    return failed;
-}

src/libbg/tests/plane_coordinates.c

@@ -1,69 +0,0 @@
-/*              P L A N E _ C O O R D I N A T E S . C
- * BRL-CAD
- *
- * Copyright (c) 2026 United States Government as represented by
- * the U.S. Army Research Laboratory.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public License
- * version 2.1 as published by the Free Software Foundation.
- *
- * This library is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- */
-
-#include "common.h"
-
-#include "bn.h"
-#include "bu.h"
-#include "bg.h"
-
-
-int
-main(int argc, char **argv)
-{
-    const point_t plane_point = {0.0, 0.0, 3.0};
-    const vect_t original_normal = {0.0, 0.0, 2.0};
-    const vect_t expected_normal = {0.0, 0.0, 1.0};
-    vect_t normal;
-    vect_t zero_normal = VINIT_ZERO;
-    plane_t plane;
-    plane_t unnormalized_plane = {0.0, 0.0, 2.0, 6.0};
-    point_t query = {2.0, 2.0, 3.0};
-    point_t off_plane_query = {2.0, 2.0, 5.0};
-    const point_t expected_projection = {2.0, 2.0, 3.0};
-    point_t reconstructed = VINIT_ZERO;
-    fastf_t u, v;
-    int failed = 0;
-
-    bu_setprogname(argv[0]);
-    if (argc != 1)
-	return 1;
-
-    VMOVE(normal, original_normal);
-    if (bg_plane_pt_nrml(&plane, plane_point, normal) ||
-	!VNEAR_EQUAL(plane, expected_normal, BN_TOL_DIST) ||
-	!NEAR_EQUAL(plane[H], 3.0, BN_TOL_DIST) ||
-	!VNEAR_EQUAL(normal, original_normal, BN_TOL_DIST)) {
-	failed = 1;
-    }
-
-    if (bg_plane_pt_nrml(&plane, plane_point, zero_normal) != -1)
-	failed = 1;
-
-    if (bg_plane_closest_pt(&u, &v, &unnormalized_plane, &query) ||
-	bg_plane_pt_at(&reconstructed, &unnormalized_plane, u, v) ||
-	!VNEAR_EQUAL(reconstructed, query, BN_TOL_DIST)) {
-	failed = 1;
-    }
-
-    if (bg_plane_closest_pt(&u, &v, &unnormalized_plane, &off_plane_query) ||
-	bg_plane_pt_at(&reconstructed, &unnormalized_plane, u, v) ||
-	!VNEAR_EQUAL(reconstructed, expected_projection, BN_TOL_DIST)) {
-	failed = 1;
-    }
-
-    return failed;
-}

src/libbg/tests/polygon.c

@@ -1,123 +0,0 @@
-/*                       P O L Y G O N . C
- * BRL-CAD
- *
- * Copyright (c) 2026 United States Government as represented by
- * the U.S. Army Research Laboratory.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public License
- * version 2.1 as published by the Free Software Foundation.
- *
- * This library is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- */
-
-#include "common.h"
-
-#include "bn.h"
-#include "bu.h"
-#include "bg.h"
-
-
-static int
-test_view_bbox(void)
-{
-    point_t outer[] = {
-	{0.0, 0.0, 0.0},
-	{2.0, 0.0, 0.0},
-	{2.0, 2.0, 0.0},
-	{0.0, 2.0, 0.0}
-    };
-    point_t hole[] = {
-	{100.0, 100.0, 0.0},
-	{101.0, 100.0, 0.0},
-	{101.0, 101.0, 0.0},
-	{100.0, 101.0, 0.0}
-    };
-    struct bg_poly_contour contours[] = {
-	{4, outer, 0},
-	{4, hole, 0}
-    };
-    int holes[] = {0, 1};
-    struct bg_polygon polygon = BG_POLYGON_NULL;
-    mat_t model2view;
-    point2d_t bmin, bmax;
-
-    polygon.num_contours = 2;
-    polygon.hole = holes;
-    polygon.contour = contours;
-    MAT_IDN(model2view);
-    bg_polygon_view_bbox(&bmin, &bmax, &polygon, model2view);
-
-    return !NEAR_EQUAL(bmin[X], 0.0, BN_TOL_DIST)
-	|| !NEAR_EQUAL(bmin[Y], 0.0, BN_TOL_DIST)
-	|| !NEAR_EQUAL(bmax[X], 2.0, BN_TOL_DIST)
-	|| !NEAR_EQUAL(bmax[Y], 2.0, BN_TOL_DIST);
-}
-
-
-static int
-test_centroid(void)
-{
-    const point_t rectangle[] = {
-	{5.0, 0.0, 0.0},
-	{5.0, 4.0, 0.0},
-	{5.0, 4.0, 2.0},
-	{5.0, 0.0, 2.0}
-    };
-    const point_t expected = {5.0, 2.0, 1.0};
-    point_t output[] = {
-	{11.0, 12.0, 13.0},
-	{0.0, 0.0, 0.0},
-	{17.0, 18.0, 19.0},
-	{23.0, 24.0, 25.0}
-    };
-    const point_t before = {11.0, 12.0, 13.0};
-    const point_t after = {17.0, 18.0, 19.0};
-    const point_t farther_after = {23.0, 24.0, 25.0};
-
-    return bg_3d_polygon_centroid(&output[1], 4, rectangle)
-	|| !VNEAR_EQUAL(output[1], expected, BN_TOL_DIST)
-	|| !VNEAR_EQUAL(output[0], before, BN_TOL_DIST)
-	|| !VNEAR_EQUAL(output[2], after, BN_TOL_DIST)
-	|| !VNEAR_EQUAL(output[3], farther_after, BN_TOL_DIST);
-}
-
-
-static int
-test_ccw_sort(void)
-{
-    point_t points[] = {
-	{10.0, 10.0, 0.0},
-	{10.1, 10.1, 0.0},
-	{10.1, 10.0, 0.0},
-	{10.0, 10.1, 0.0}
-    };
-    plane_t plane = {0.0, 0.0, 1.0, 0.0};
-    vect_t total = VINIT_ZERO;
-    vect_t cross;
-
-    if (bg_3d_polygon_sort_ccw(4, points, plane))
-	return 1;
-
-    for (size_t i = 0; i < 4; i++) {
-	size_t next = i + 1 == 4 ? 0 : i + 1;
-	VCROSS(cross, points[i], points[next]);
-	VADD2(total, total, cross);
-    }
-
-    return total[Z] <= SMALL_FASTF;
-}
-
-
-int
-main(int argc, char **argv)
-{
-    bu_setprogname(argv[0]);
-    if (argc != 1)
-	return 1;
-
-    return test_view_bbox() || test_centroid() || test_ccw_sort();
-}

src/libbg/tests/spsr.cpp

@@ -1,200 +0,0 @@
-/*                       S P S R . C P P
- * BRL-CAD
- *
- * Copyright (c) 2026 United States Government as represented by
- * the U.S. Army Research Laboratory.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public License
- * version 2.1 as published by the Free Software Foundation.
- *
- * This library is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this file; see the file named COPYING for more
- * information.
- */
-
-#include "common.h"
-
-#include <cmath>
-#include <vector>
-
-#include "vmath.h"
-#include "bu/app.h"
-#include "bu/log.h"
-#include "bu/malloc.h"
-#include "bg/spsr.h"
-
-static int failures = 0;
-
-static void
-expect(bool condition, const char *message)
-{
-    if (condition)
-        return;
-    bu_log("FAIL: %s\n", message);
-    failures++;
-}
-
-static std::vector<struct bg_3d_spsr_sample>
-sphere_samples(size_t count)
-{
-    const fastf_t golden_angle = M_PI * (3.0 - std::sqrt(5.0));
-    std::vector<struct bg_3d_spsr_sample> samples(count);
-    for (size_t i = 0; i < count; i++) {
-        fastf_t y = 1.0 - 2.0 *
-            (static_cast<fastf_t>(i) + 0.5) / count;
-        fastf_t radius = std::sqrt(std::max(0.0, 1.0 - y * y));
-        fastf_t angle = golden_angle * i;
-        VSET(samples[i].point, radius * std::cos(angle), y,
-            radius * std::sin(angle));
-        VMOVE(samples[i].normal, samples[i].point);
-    }
-    return samples;
-}
-
-struct callback_state {
-    size_t calls;
-    size_t hints;
-    struct bg_3d_spsr_sample additional_sample;
-    bool refine_once;
-    bool stop;
-};
-
-static int
-accept_candidate(struct bg_3d_spsr_refinement_response *response,
-    const struct bg_3d_spsr_refinement_request *request, void *data)
-{
-    struct callback_state *state =
-        static_cast<struct callback_state *>(data);
-    state->calls++;
-    state->hints = request->hint_count;
-    response->validation.ray_count = 100;
-    if (state->stop) {
-	response->validation.passed = 0;
-	response->stop_refinement = 1;
-    } else if (state->refine_once && state->calls == 1) {
-	response->samples = &state->additional_sample;
-	response->sample_count = 1;
-	response->validation.passed = 0;
-    } else {
-	response->validation.passed = 1;
-    }
-    return BRLCAD_OK;
-}
-
-int
-main(int UNUSED(argc), const char **argv)
-{
-    bu_setprogname(argv[0]);
-
-    std::vector<struct bg_3d_spsr_sample> samples = sphere_samples(256);
-    struct bg_3d_spsr_adaptive_opts options =
-        BG_3D_SPSR_ADAPTIVE_OPTS_DEFAULT;
-    options.solver.depth = 5;
-    options.max_refinement_passes = 0;
-
-    int *faces = NULL;
-    int face_count = 0;
-    point_t *vertices = NULL;
-    int vertex_count = 0;
-    struct bg_3d_spsr_report report = {};
-    int ret = bg_3d_spsr_adaptive(&faces, &face_count, &vertices,
-        &vertex_count, samples.data(), samples.size(), &options,
-        NULL, NULL, &report);
-    expect(ret == BRLCAD_OK, "fixed structured reconstruction succeeds");
-    expect(face_count > 0 && vertex_count > 0,
-        "fixed structured reconstruction returns a mesh");
-    expect(report.solve_count == 1 && report.validation.passed,
-        "fixed structured reconstruction reports one successful solve");
-    if (faces)
-        bu_free(faces, "SPSR test faces");
-    if (vertices)
-        bu_free(vertices, "SPSR test vertices");
-
-    struct callback_state state = {};
-    options.max_refinement_passes = 3;
-    options.target_feature_size = 0.1;
-    options.max_points = 512;
-    faces = NULL;
-    vertices = NULL;
-    face_count = 0;
-    vertex_count = 0;
-    ret = bg_3d_spsr_adaptive(&faces, &face_count, &vertices,
-        &vertex_count, samples.data(), samples.size(), &options,
-        accept_candidate, &state, &report);
-    expect(ret == BRLCAD_OK, "callback can accept an adaptive candidate");
-    expect(state.calls == 1, "accepted candidate stops adaptive solving");
-    expect(report.validation.ray_count == 100,
-        "adaptive report preserves callback validation");
-    if (faces)
-        bu_free(faces, "SPSR test faces");
-    if (vertices)
-        bu_free(vertices, "SPSR test vertices");
-
-    state = {};
-    state.stop = true;
-    faces = NULL;
-    vertices = NULL;
-    face_count = 0;
-    vertex_count = 0;
-    ret = bg_3d_spsr_adaptive(&faces, &face_count, &vertices,
-	&vertex_count, samples.data(), samples.size(), &options,
-	accept_candidate, &state, &report);
-    expect(ret == BRLCAD_ERROR,
-	"callback can stop an unproductive adaptive solve");
-    expect(state.calls == 1 && report.solve_count == 1 &&
-	report.termination == BG_3D_SPSR_CALLBACK_STOP,
-	"callback stop preserves the final validation report");
-
-    state = {};
-    state.refine_once = true;
-    VSET(state.additional_sample.point, 1.0, 0.0, 0.0);
-    VSET(state.additional_sample.normal, 1.0, 0.0, 0.0);
-    faces = NULL;
-    vertices = NULL;
-    face_count = 0;
-    vertex_count = 0;
-    ret = bg_3d_spsr_adaptive(&faces, &face_count, &vertices,
-	&vertex_count, samples.data(), samples.size(), &options,
-	accept_candidate, &state, &report);
-    expect(ret == BRLCAD_OK, "adaptive refinement can add a source sample");
-    expect(state.calls == 2 && report.solve_count == 2,
-	"new source sample triggers a second solve");
-    expect(report.accepted_sample_count == 1 &&
-	report.final_sample_count == samples.size() + 1,
-	"adaptive report counts incorporated samples");
-    if (faces)
-	bu_free(faces, "SPSR test faces");
-    if (vertices)
-	bu_free(vertices, "SPSR test vertices");
-
-    options.solver.threads = 1;
-    ret = bg_3d_spsr_adaptive(&faces, &face_count, &vertices,
-        &vertex_count, samples.data(), samples.size(), &options,
-        accept_candidate, &state, NULL);
-    expect(ret == BRLCAD_ERROR,
-        "unsupported solver settings are rejected");
-
-    expect(bg_3d_spsr_adaptive(NULL, &face_count, &vertices,
-        &vertex_count, samples.data(), samples.size(), &options,
-        accept_candidate, &state, NULL) == BRLCAD_ERROR,
-        "invalid output arguments are rejected");
-
-    return failures ? 1 : 0;
-}
-
-/*
- * Local Variables:
- * tab-width: 8
- * mode: C++
- * c-basic-offset: 4
- * indent-tabs-mode: t
- * c-file-style: "stroustrup"
- * End:
- * ex: shiftwidth=4 tabstop=8 cino=N-s
- */

src/libbg/tests/trimesh_solid.c

@@ -1,106 +0,0 @@
-/*                 T R I M E S H _ S O L I D . C
- * BRL-CAD
- *
- * Copyright (c) 2026 United States Government as represented by
- * the U.S. Army Research Laboratory.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public License
- * version 2.1 as published by the Free Software Foundation.
- *
- * This library is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- */
-
-#include "common.h"
-
-#include "bu.h"
-#include "bg.h"
-
-
-static int
-test_solid_diagnostics(void)
-{
-    fastf_t vertices[][3] = {
-	{0.0, 0.0, 0.0},
-	{1.0, 0.0, 0.0},
-	{0.0, 1.0, 0.0},
-	{0.0, 0.0, 1.0},
-	{1.0, 1.0, 1.0}
-    };
-    int solid_faces[] = {
-	0, 2, 1,
-	0, 1, 3,
-	0, 3, 2,
-	1, 2, 3
-    };
-    int reversed_faces[] = {
-	0, 1, 2,
-	0, 1, 3,
-	0, 3, 2,
-	1, 2, 3
-    };
-    int mixed_error_faces[] = {
-	0, 1, 2,
-	0, 1, 3,
-	0, 3, 4,
-	1, 2, 3
-    };
-    int *bad_edges = NULL;
-    struct bg_trimesh_solid_errors errors = BG_TRIMESH_SOLID_ERRORS_INIT_NULL;
-    int failed = 0;
-
-    if (bg_trimesh_solid(4, 4, &vertices[0][0], solid_faces, &bad_edges) || bad_edges)
-	failed = 1;
-
-    if (bad_edges) {
-	bu_free(bad_edges, "bad edges");
-	bad_edges = NULL;
-    }
-
-    if (bg_trimesh_solid(4, 4, &vertices[0][0], reversed_faces, &bad_edges) != 1
-	|| !bad_edges) {
-	failed = 1;
-    }
-
-    if (bad_edges)
-	bu_free(bad_edges, "bad edges");
-
-    if (!bg_trimesh_solid2(5, 4, &vertices[0][0], mixed_error_faces, &errors)
-	|| !errors.unmatched.count || !errors.misoriented.count) {
-	failed = 1;
-    }
-    bg_free_trimesh_solid_errors(&errors);
-
-    return failed;
-}
-
-
-static int
-test_free_helpers(void)
-{
-    struct bg_trimesh_edges edges = BG_TRIMESH_EDGES_INIT_NULL;
-    struct bg_trimesh_faces faces = BG_TRIMESH_FACES_INIT_NULL;
-
-    edges.count = 1;
-    edges.edges = (int *)bu_malloc(2 * sizeof(int), "test edges");
-    faces.count = 1;
-    faces.faces = (int *)bu_malloc(sizeof(int), "test faces");
-    bg_free_trimesh_edges(&edges);
-    bg_free_trimesh_faces(&faces);
-
-    return edges.count != 0 || edges.edges || faces.count != 0 || faces.faces;
-}
-
-
-int
-main(int argc, char **argv)
-{
-    bu_setprogname(argv[0]);
-    if (argc != 1)
-	return 1;
-
-    return test_solid_diagnostics() || test_free_helpers();
-}

src/libbg/tri_ray.cpp

@@ -88,7 +88,7 @@ intersect_triangle(const point_t origin, const vect_t direction,
 extern "C" {
 
 int
-bg_isect_tri_ray(const point_t orig, const vect_t dir,
+bg_isect_tri_ray(const point_t orig, const point_t dir,
 		 const point_t vert0, const point_t vert1, const point_t vert2,
 		 point_t *isect)
 {

src/libbg/trimesh.cpp

@@ -285,20 +285,10 @@ bg_trimesh_solid2(int vcnt, int fcnt, fastf_t *v, int *f, struct bg_trimesh_soli
 
     bad_edge_func = errors ? bg_trimesh_edge_continue : bg_trimesh_edge_exit;
 
-    unmatched_edges = bg_trimesh_unmatched_edges(num_edges, edge_list, bad_edge_func, NULL);
-    if (!errors && unmatched_edges) {
-	bu_free(edge_list, "edge_list");
-	return 1;
-    }
-
-    misoriented_edges = bg_trimesh_misoriented_edges(num_edges, edge_list, bad_edge_func, NULL);
-    if (!errors && misoriented_edges) {
-	bu_free(edge_list, "edge_list");
-	return 1;
-    }
-
-    excess_edges = bg_trimesh_excess_edges(num_edges, edge_list, bad_edge_func, NULL);
-    if (unmatched_edges || misoriented_edges || excess_edges) {
+    if ((unmatched_edges = bg_trimesh_unmatched_edges(num_edges, edge_list, bad_edge_func, NULL)) ||
+	(misoriented_edges = bg_trimesh_misoriented_edges(num_edges, edge_list, bad_edge_func, NULL)) ||
+	(excess_edges = bg_trimesh_excess_edges(num_edges, edge_list, bad_edge_func, NULL)))
+    {
 	if (!errors) {
 	    bu_free(edge_list, "edge_list");
 	    return 1;
@@ -339,7 +329,6 @@ bg_free_trimesh_edges(struct bg_trimesh_edges *edges)
     if (!edges) return;
 
     bu_free(edges->edges, "bg trimesh edges");
-    edges->edges = NULL;
     edges->count = 0;
 }
 
@@ -349,7 +338,6 @@ bg_free_trimesh_faces(struct bg_trimesh_faces *faces)
     if (!faces) return;
 
     bu_free(faces->faces, "bg trimesh faces");
-    faces->faces = NULL;
     faces->count = 0;
 }
 
@@ -367,42 +355,34 @@ bg_free_trimesh_solid_errors(struct bg_trimesh_solid_errors *errors)
 int
 bg_trimesh_solid(int vcnt, int fcnt, fastf_t *v, int *f, int **bedges)
 {
-    int not_solid;
+    int bedge_cnt = 0;
 
     if (bedges) {
-	int copy_count = 0;
-	int edge_count;
+	int copy_cnt = 0;
 	struct bg_trimesh_solid_errors errors = BG_TRIMESH_SOLID_ERRORS_INIT_NULL;
 
-	*bedges = NULL;
-	not_solid = bg_trimesh_solid2(vcnt, fcnt, v, f, &errors);
-	edge_count = errors.unmatched.count + errors.misoriented.count + errors.excess.count;
-	if (edge_count) {
-	    *bedges = (int *)bu_calloc(edge_count * 2, sizeof(int), "bad edges");
+	bedge_cnt = bg_trimesh_solid2(vcnt, fcnt, v, f, &errors);
 
-	    if (errors.unmatched.count) {
-		memcpy(*bedges + copy_count, errors.unmatched.edges,
-		       errors.unmatched.count * 2 * sizeof(int));
-		copy_count += errors.unmatched.count * 2;
-	    }
-	    if (errors.misoriented.count) {
-		memcpy(*bedges + copy_count, errors.misoriented.edges,
-		       errors.misoriented.count * 2 * sizeof(int));
-		copy_count += errors.misoriented.count * 2;
-	    }
-	    if (errors.excess.count) {
-		memcpy(*bedges + copy_count, errors.excess.edges,
-		       errors.excess.count * 2 * sizeof(int));
-	    }
-	}
+	*bedges = (int *)bu_calloc(bedge_cnt * 2, sizeof(int), "bad edges");
+
+	if (!errors.unmatched.edges || !errors.unmatched.count)
+	    return 0;
+
+	memcpy(*bedges, errors.unmatched.edges, errors.unmatched.count * 2 * sizeof(int));
+	copy_cnt += errors.unmatched.count * 2;
+
+	memcpy(*bedges + copy_cnt, errors.misoriented.edges, errors.misoriented.count * 2 * sizeof(int));
+	copy_cnt += errors.misoriented.count * 2;
+
+	memcpy(*bedges + copy_cnt, errors.excess.edges, errors.excess.count * 2 * sizeof(int));
 
 	bg_free_trimesh_solid_errors(&errors);
     } else {
-	not_solid = bg_trimesh_solid2(vcnt, fcnt, v, f, NULL);
+	bedge_cnt = bg_trimesh_solid2(vcnt, fcnt, v, f, NULL);
     }
 
     /* returns true when not solid */
-    return not_solid ? 1 : 0;
+    return (bedge_cnt > 0) ? 1 : 0;
 }
 
 int

src/libbn/mat.c

@@ -662,6 +662,87 @@ bn_vec_perp(vect_t new_vec, const vect_t old_vec)
     VCROSS(new_vec, another_vec, old_vec);
 }
 
+static int
+bn_lseg3_lseg3_parallel(const point_t sg1pt1, const point_t sg1pt2,
+	const point_t sg2pt1, const point_t sg2pt2,
+	const struct bn_tol *tol)
+{
+    vect_t e_dif[2]    = {{0.0, 0.0, 0.0}, {0.0, 0.0, 0.0}};
+    vect_t e_dif_a[2]  = {{0.0, 0.0, 0.0}, {0.0, 0.0, 0.0}};
+    fastf_t e_rr[2][3] = {{0.0, 0.0, 0.0}, {0.0, 0.0, 0.0}};
+    char e_sc[2][3] = {{0, 0, 0}, {0, 0, 0}};
+    fastf_t dist = tol->dist;
+    fastf_t tmp;
+    int i, j;
+
+    VSUB2(e_dif[0], sg1pt2, sg1pt1);
+    VSUB2(e_dif[1], sg2pt2, sg2pt1);
+
+    for ( i = 0 ; i < 2 ; i++ ) {
+	for ( j = 0 ; j < 3 ; j++ ) {
+	    e_dif_a[i][j] = fabs(e_dif[i][j]);
+	}
+    }
+
+    for ( i = 0 ; i < 2 ; i++ ) {
+	if ((e_dif_a[i][X] < dist) && (e_dif_a[i][Y] > dist)) {
+	    e_sc[i][0] = 1;
+	} else if ((e_dif_a[i][X] > dist) && (e_dif_a[i][Y] < dist)) {
+	    e_sc[i][0] = 2;
+	} else if ((e_dif_a[i][X] < dist) && (e_dif_a[i][Y] < dist)) {
+	    e_sc[i][0] = 3;
+	} else {
+	    e_rr[i][0] = e_dif[i][Y] / e_dif[i][X];
+	    e_sc[i][0] = 0;
+	}
+	if ((e_dif_a[i][X] < dist) && (e_dif_a[i][Z] > dist)) {
+	    e_sc[i][1] = 1;
+	} else if ((e_dif_a[i][X] > dist) && (e_dif_a[i][Z] < dist)) {
+	    e_sc[i][1] = 2;
+	} else if ((e_dif_a[i][X] < dist) && (e_dif_a[i][Z] < dist)) {
+	    e_sc[i][1] = 3;
+	} else {
+	    e_rr[i][1] = e_dif[i][Z] / e_dif[i][X];
+	    e_sc[i][1] = 0;
+	}
+	if ((e_dif_a[i][X] < dist) && (e_dif_a[i][Z] > dist)) {
+	    e_sc[i][1] = 1;
+	} else if ((e_dif_a[i][X] > dist) && (e_dif_a[i][Z] < dist)) {
+	    e_sc[i][1] = 2;
+	} else if ((e_dif_a[i][X] < dist) && (e_dif_a[i][Z] < dist)) {
+	    e_sc[i][1] = 3;
+	} else {
+	    e_rr[i][1] = e_dif[i][Z] / e_dif[i][X];
+	    e_sc[i][1] = 0;
+	}
+	if ((e_dif_a[i][Y] < dist) && (e_dif_a[i][Z] > dist)) {
+	    e_sc[i][2] = 1;
+	} else if ((e_dif_a[i][Y] > dist) && (e_dif_a[i][Z] < dist)) {
+	    e_sc[i][2] = 2;
+	} else if ((e_dif_a[i][Y] < dist) && (e_dif_a[i][Z] < dist)) {
+	    e_sc[i][2] = 3;
+	} else {
+	    e_rr[i][2] = e_dif[i][Z] / e_dif[i][Y];
+	    e_sc[i][2] = 0;
+	}
+    }
+
+    /* loop thru (rise/run) ratios from xy, xz and yz planes */
+    for ( i = 0 ; i < 3 ; i++ ) {
+	if (e_sc[0][i] != e_sc[1][i]) {
+	    return 0;
+	}
+	if (e_sc[0][i] == 0) {
+	    tmp = e_rr[0][i] - e_rr[1][i];
+	    if (fabs(tmp) > dist) {
+		return 0;
+	    }
+	}
+    }
+
+    return 1;
+}
+
 void
 bn_mat_fromto(
     mat_t m,
@@ -672,6 +753,7 @@ bn_mat_fromto(
     vect_t test_to;
     vect_t unit_from, unit_to;
     fastf_t dot;
+    point_t origin = VINIT_ZERO;
 
     /**
      * The method used here is from Graphics Gems, A. Glassner, ed.
@@ -685,24 +767,18 @@ bn_mat_fromto(
     vect_t N, M;
     vect_t w_prime;		/* image of "to" ("w") in Qt */
 
-    BN_CK_TOL(tol);
-
     VMOVE(unit_from, from);
     VUNITIZE(unit_from);		/* aka "v" */
     VMOVE(unit_to, to);
     VUNITIZE(unit_to);		/* aka "w" */
 
-    if (VZERO(unit_from) || VZERO(unit_to)) {
-	MAT_IDN(m);
-	return;
-    }
-
-    /* Same and opposite directions need special handling because their
-     * cross product does not define a rotation axis.
+    /* If from and to are the same or opposite, special handling is
+     * needed, because the cross product isn't defined.  asin(0.00001)
+     * = 0.0005729 degrees (1/2000 degree)
      */
-    dot = VDOT(unit_from, unit_to);
-    if (BN_VECT_ARE_PARALLEL(dot, tol)) {
-	if (dot > 0.0) {
+    if (bn_lseg3_lseg3_parallel(origin, from, origin, to, tol)) {
+	dot = VDOT(from, to);
+	if (dot > SMALL_FASTF) {
 	    MAT_IDN(m);
 	    return;
 	} else {
@@ -736,7 +812,7 @@ bn_mat_fromto(
 
     /* Verify that it worked */
     MAT4X3VEC(test_to, m, unit_from);
-    if (UNLIKELY(!BN_VECT_ARE_PARALLEL(VDOT(unit_to, test_to), tol))) {
+    if (UNLIKELY(!bn_lseg3_lseg3_parallel(origin, unit_to, origin, test_to, tol))) {
 	dot = VDOT(unit_to, test_to);
 	bu_log("bn_mat_fromto() ERROR!  from (%g, %g, %g) to (%g, %g, %g) went to (%g, %g, %g), dot=%g?\n",
 	       V3ARGS(from), V3ARGS(to), V3ARGS(test_to), dot);
@@ -823,32 +899,16 @@ bn_mat_lookat(mat_t rot, const vect_t dir, int yflip)
     vect_t x;
     vect_t z;
     vect_t t1;
-    vect_t unit_dir;
     fastf_t hypot_xy;
     vect_t xproj;
     vect_t zproj;
 
-    VMOVE(unit_dir, dir);
-    VUNITIZE(unit_dir);
-    if (VZERO(unit_dir)) {
-	MAT_IDN(rot);
-	return;
-    }
-
     /* First, rotate D around Z axis to match +X axis (azimuth) */
-    hypot_xy = hypot(unit_dir[X], unit_dir[Y]);
-    if (hypot_xy < VDIVIDE_TOL) {
-	if (unit_dir[Z] < 0.0) {
-	    MAT_IDN(rot);
-	} else {
-	    bn_mat_yrot(rot, 0.0, -1.0);
-	}
-	return;
-	}
-    bn_mat_zrot(first, -unit_dir[Y] / hypot_xy, unit_dir[X] / hypot_xy);
+    hypot_xy = hypot(dir[X], dir[Y]);
+    bn_mat_zrot(first, -dir[Y] / hypot_xy, dir[X] / hypot_xy);
 
     /* Next, rotate D around Y axis to match -Z axis (elevation) */
-    bn_mat_yrot(second, -hypot_xy, -unit_dir[Z]);
+    bn_mat_yrot(second, -hypot_xy, -dir[Z]);
     bn_mat_mul(prod12, second, first);
 
     /* Produce twist correction, by re-orienting projection of X axis */
@@ -877,7 +937,7 @@ bn_mat_lookat(mat_t rot, const vect_t dir, int yflip)
     }
 
     /* Check the final results */
-    MAT4X3VEC(t1, rot, unit_dir);
+    MAT4X3VEC(t1, rot, dir);
     if (t1[Z] > -0.98) {
 	bu_log("Error:  bn_mat_lookat final= (%g, %g, %g)\n", V3ARGS(t1));
     }
@@ -1217,10 +1277,10 @@ bn_mat_is_non_unif(const mat_t m)
 void
 bn_wrt_point_direc(mat_t out, const mat_t change, const mat_t in, const point_t point, const vect_t direc, const struct bn_tol *tol)
 {
-    mat_t t1;
-    mat_t pt_to_origin, origin_to_pt;
-    mat_t d_to_zaxis, zaxis_to_d;
-    vect_t zaxis;
+    static mat_t t1;
+    static mat_t pt_to_origin, origin_to_pt;
+    static mat_t d_to_zaxis, zaxis_to_d;
+    static vect_t zaxis;
 
     /* build "point to origin" matrix */
     MAT_IDN(pt_to_origin);
@@ -1228,7 +1288,7 @@ bn_wrt_point_direc(mat_t out, const mat_t change, const mat_t in, const point_t
 
     /* build "origin to point" matrix */
     MAT_IDN(origin_to_pt);
-    MAT_DELTAS_VEC(origin_to_pt, point);
+    MAT_DELTAS_VEC_NEG(origin_to_pt, point);
 
     /* build "direc to zaxis" matrix */
     VSET(zaxis, 0.0, 0.0, 1.0);

src/libbn/multipoly.c

@@ -28,11 +28,21 @@
 
 #include "common.h"
 
+#include <stdio.h>
+#include <math.h>
+
+#include "bu/interrupt.h"
 #include "bu/malloc.h"
+#include "vmath.h"
 #include "bn/multipoly.h"
 
 
 #define FAILSTR "failure in multipoly.c"
+/* the Max and Min macros in vmath.h are destructive and not suited for here, should this be
+ * added somewhere else? */
+#define Max(a, b) (((a) > (b)) ? (a) : (b))
+#define Min(a, b) (((a) > (b)) ? (a) : (b))
+
 /**
  *        bn_multipoly_new
  *
@@ -42,41 +52,25 @@ struct bn_multipoly *
 bn_multipoly_new(int dgrs, int dgrt)
 {
     struct bn_multipoly *newmp;
-    int i;
-
-    if (dgrs <= 0 || dgrt <= 0) {
-	return NULL;
-	}
+    int    i, s, t;
 
     BU_ALLOC(newmp, struct bn_multipoly);
-    newmp->cf = (double **)bu_calloc(dgrs, sizeof(double *), FAILSTR);
+    newmp->cf = (double **)bu_malloc(dgrs * sizeof(double *), FAILSTR);
 
     for (i = 0; i < dgrs; i++) {
-	newmp->cf[i] = (double *)bu_calloc(dgrt, sizeof(double), FAILSTR);
+	newmp->cf[i] = (double *)bu_malloc(dgrt * sizeof(double), FAILSTR);
     }
 
     newmp->dgrs = dgrs;
     newmp->dgrt = dgrt;
+    for (s = 0; s < dgrs; s++) {
+	for (t = 0; t < dgrt; t++) {
+	    newmp->cf[s][t] = 0;
+	}
+    }
     return newmp;
 }
 
-
-void
-bn_multipoly_free(struct bn_multipoly *poly)
-{
-    int s;
-
-    if (!poly) {
-	return;
-    }
-
-    for (s = 0; s < poly->dgrs; s++) {
-	bu_free(poly->cf[s], "bn_multipoly coefficients");
-    }
-    bu_free(poly->cf, "bn_multipoly coefficient rows");
-    bu_free(poly, "bn_multipoly");
-}
-
 /**
  *        bn_multipoly_grow
  *
@@ -85,35 +79,24 @@ bn_multipoly_free(struct bn_multipoly *poly)
 struct bn_multipoly *
 bn_multipoly_grow(register struct bn_multipoly *P, int dgrs, int dgrt)
 {
-    double **coefficients;
-    int new_dgrs, new_dgrt;
-    int s, t;
-
-    if (!P) {
-	return NULL;
+    int i, j;
+    if (dgrs > P->dgrs) {
+	P->cf = (double **)bu_realloc(P->cf, dgrs * sizeof(double *), FAILSTR);
+	for (i = P->dgrs; i < dgrs; i++) {
+	    P->cf[i] = (double *)bu_malloc(Max(P->dgrt, dgrt) * sizeof(double), FAILSTR);
+	    for (j = 0; j < Max(P->dgrt, dgrt); j++) {
+		P->cf[i][j] = 0;
+	    }
+	}
     }
-
-    new_dgrs = (dgrs > P->dgrs) ? dgrs : P->dgrs;
-    new_dgrt = (dgrt > P->dgrt) ? dgrt : P->dgrt;
-    if (new_dgrs == P->dgrs && new_dgrt == P->dgrt) {
-	return P;
-    }
-
-    coefficients = (double **)bu_calloc(new_dgrs, sizeof(double *), FAILSTR);
-    for (s = 0; s < new_dgrs; s++) {
-	coefficients[s] = (double *)bu_calloc(new_dgrt, sizeof(double), FAILSTR);
-    }
-    for (s = 0; s < P->dgrs; s++) {
-	for (t = 0; t < P->dgrt; t++) {
-	    coefficients[s][t] = P->cf[s][t];
+    if (dgrt > P->dgrt) {
+	for (i = 0; i < P->dgrt; i++) {
+	    P->cf[i] = (double *)bu_realloc(P->cf, dgrt * sizeof(double *), FAILSTR);
+	    for (j = P->dgrt; j < dgrt; j++) {
+		P->cf[i][j] = 0;
+	    }
 	}
-	bu_free(P->cf[s], "bn_multipoly coefficients");
     }
-    bu_free(P->cf, "bn_multipoly coefficient rows");
-
-    P->cf = coefficients;
-    P->dgrs = new_dgrs;
-    P->dgrt = new_dgrt;
     return P;
 }
 
@@ -125,12 +108,7 @@ bn_multipoly_grow(register struct bn_multipoly *P, int dgrs, int dgrt)
 struct bn_multipoly *
 bn_multipoly_set(register struct bn_multipoly *P, int s, int t, double val)
 {
-    if (!P || s < 0 || t < 0) {
-	return NULL;
-    }
-    if (!bn_multipoly_grow(P, s + 1, t + 1)) {
-	return NULL;
-    }
+    bn_multipoly_grow(P, s + 1, t + 1);
     P->cf[s][t] = val;
     return P;
 }
@@ -141,26 +119,13 @@ bn_multipoly_set(register struct bn_multipoly *P, int s, int t, double val)
  * @brief add two polynomials
  */
 struct bn_multipoly *
-bn_multipoly_add(register const struct bn_multipoly *p1, register const struct bn_multipoly *p2)
+bn_multipoly_add(register struct bn_multipoly *p1, register struct bn_multipoly *p2)
 {
-    struct bn_multipoly *sum;
+    struct bn_multipoly *sum = bn_multipoly_new(Max(p1->dgrs, p2->dgrs), Max(p1->dgrt, p2->dgrs));
     int s, t;
-
-	if (!p1 || !p2 || p1->dgrs <= 0 || p1->dgrt <= 0 ||
-	p2->dgrs <= 0 || p2->dgrt <= 0) {
-	return NULL;
-    }
-
-    sum = bn_multipoly_new((p1->dgrs > p2->dgrs) ? p1->dgrs : p2->dgrs,
-			    (p1->dgrt > p2->dgrt) ? p1->dgrt : p2->dgrt);
     for (s = 0; s < sum->dgrs; s++) {
 	for (t = 0; t < sum->dgrt; t++) {
-	    if (s < p1->dgrs && t < p1->dgrt) {
-		sum->cf[s][t] += p1->cf[s][t];
-	    }
-	    if (s < p2->dgrs && t < p2->dgrt) {
-		sum->cf[s][t] += p2->cf[s][t];
-	    }
+	    sum->cf[s][t] = p1->cf[s][t] + p2->cf[s][t];
 	}
     }
     return sum;
@@ -173,23 +138,15 @@ bn_multipoly_add(register const struct bn_multipoly *p1, register const struct b
  */
 
 struct bn_multipoly *
-bn_multipoly_mul(register const struct bn_multipoly *p1, register const struct bn_multipoly *p2)
+bn_multipoly_mul(register struct bn_multipoly *p1, register struct bn_multipoly *p2)
 {
-    struct bn_multipoly *product;
-    int s1, s2, t1, t2;
-
-    if (!p1 || !p2 || p1->dgrs <= 0 || p1->dgrt <= 0 ||
-	p2->dgrs <= 0 || p2->dgrt <= 0) {
-	return NULL;
-	}
-
-    product = bn_multipoly_new(p1->dgrs + p2->dgrs - 1,
-				p1->dgrt + p2->dgrt - 1);
+    struct bn_multipoly *product = bn_multipoly_new(p1->dgrs + p2->dgrs, p1->dgrt + p2->dgrt);
+    int s1,s2,t1,t2;
     for (s1 = 0; s1 < p1->dgrs; s1++) {
 	for (t1 = 0; t1 < p1->dgrt; t1++) {
 	    for (s2 = 0; s2 < p2->dgrs; s2++) {
-		for (t2 = 0; t2 < p2->dgrt; t2++) {
-		    product->cf[s1 + s2][t1 + t2] += p1->cf[s1][t1] * p2->cf[s2][t2];
+		for (t2 = 0; t2 < p2->dgrt; p2++) {
+		    product->cf[s1 + s2][t1 + t2] = p1->cf[s1][t1] * p2->cf[s2][t2];
 		}
 	    }
 	}

src/libbn/poly.c

@@ -28,6 +28,7 @@
 
 #include "common.h"
 
+#include <stdlib.h>  /* for abs */
 #include <stdio.h>
 #include <math.h>
 
@@ -48,24 +49,7 @@ static const struct bn_poly bn_Zero_poly = { BN_POLY_MAGIC, 0, {0.0} };
 struct bn_poly *
 bn_poly_mul(register struct bn_poly *product, register const struct bn_poly *m1, register const struct bn_poly *m2)
 {
-    if (m1->dgr > BN_MAX_POLY_DEGREE ||
-	m2->dgr > BN_MAX_POLY_DEGREE ||
-	m1->dgr > BN_MAX_POLY_DEGREE - m2->dgr) {
-	return BN_POLY_NULL;
-    }
-
-    if (product == m1 || product == m2) {
-	struct bn_poly result;
-
-	if (!bn_poly_mul(&result, m1, m2)) {
-	    return BN_POLY_NULL;
-	}
-	*product = result;
-	return product;
-    }
-
     if (m1->dgr == 1 && m2->dgr == 1) {
-	product->magic = BN_POLY_MAGIC;
 	product->dgr = 2;
 	product->cf[0] = m1->cf[0] * m2->cf[0];
 	product->cf[1] = m1->cf[0] * m2->cf[1] +
@@ -74,7 +58,6 @@ bn_poly_mul(register struct bn_poly *product, register const struct bn_poly *m1,
 	return product;
     }
     if (m1->dgr == 2 && m2->dgr == 2) {
-	product->magic = BN_POLY_MAGIC;
 	product->dgr = 4;
 	product->cf[0] = m1->cf[0] * m2->cf[0];
 	product->cf[1] = m1->cf[0] * m2->cf[1] +
@@ -94,7 +77,12 @@ bn_poly_mul(register struct bn_poly *product, register const struct bn_poly *m1,
 
 	*product = bn_Zero_poly;
 
-	product->dgr = m1->dgr + m2->dgr;
+	/* If the degree of the product will be larger than the
+	 * maximum size allowed in "polyno.h", then return a null
+	 * pointer to indicate failure.
+	 */
+	if ((product->dgr = m1->dgr + m2->dgr) > BN_MAX_POLY_DEGREE)
+	    return BN_POLY_NULL;
 
 	for (ct1=0; ct1 <= m1->dgr; ++ct1) {
 	    for (ct2=0; ct2 <= m2->dgr; ++ct2) {
@@ -122,26 +110,28 @@ bn_poly_scale(register struct bn_poly *eqn, double factor)
 struct bn_poly *
 bn_poly_add(register struct bn_poly *sum, register const struct bn_poly *poly1, register const struct bn_poly *poly2)
 {
-    struct bn_poly result;
+    struct bn_poly tmp;
     register size_t i, offset;
 
-    offset = (poly1->dgr >= poly2->dgr) ?
-	poly1->dgr - poly2->dgr : poly2->dgr - poly1->dgr;
+    offset = labs((long)poly1->dgr - (long)poly2->dgr);
+
+    tmp = bn_Zero_poly;
 
     if (poly1->dgr >= poly2->dgr) {
-	result = *poly1;
+	*sum = *poly1;
 	for (i=0; i <= poly2->dgr; ++i) {
-	    result.cf[i+offset] += poly2->cf[i];
+	    tmp.cf[i+offset] = poly2->cf[i];
 	}
     } else {
-	result = *poly2;
+	*sum = *poly2;
 	for (i=0; i <= poly1->dgr; ++i) {
-	    result.cf[i+offset] += poly1->cf[i];
+	    tmp.cf[i+offset] = poly1->cf[i];
 	}
     }
 
-    result.magic = BN_POLY_MAGIC;
-    *sum = result;
+    for (i=0; i <= sum->dgr; ++i) {
+	sum->cf[i] += tmp.cf[i];
+    }
     return sum;
 }
 
@@ -149,30 +139,30 @@ bn_poly_add(register struct bn_poly *sum, register const struct bn_poly *poly1,
 struct bn_poly *
 bn_poly_sub(register struct bn_poly *diff, register const struct bn_poly *poly1, register const struct bn_poly *poly2)
 {
-    struct bn_poly result;
+    struct bn_poly tmp;
     register size_t i, offset;
 
-    offset = (poly1->dgr >= poly2->dgr) ?
-	poly1->dgr - poly2->dgr : poly2->dgr - poly1->dgr;
+    offset = labs((long)poly1->dgr - (long)poly2->dgr);
+
+    *diff = bn_Zero_poly;
+    tmp = bn_Zero_poly;
 
     if (poly1->dgr >= poly2->dgr) {
-	result = *poly1;
+	*diff = *poly1;
 	for (i=0; i <= poly2->dgr; ++i) {
-	    result.cf[i+offset] -= poly2->cf[i];
+	    tmp.cf[i+offset] = poly2->cf[i];
 	}
     } else {
-	result = bn_Zero_poly;
-	result.dgr = poly2->dgr;
+	diff->dgr = poly2->dgr;
 	for (i=0; i <= poly1->dgr; ++i) {
-	    result.cf[i+offset] = poly1->cf[i];
-	}
-	for (i=0; i <= poly2->dgr; ++i) {
-	    result.cf[i] -= poly2->cf[i];
+	    diff->cf[i+offset] = poly1->cf[i];
 	}
+	tmp = *poly2;
     }
 
-    result.magic = BN_POLY_MAGIC;
-    *diff = result;
+    for (i=0; i <= diff->dgr; ++i) {
+	diff->cf[i] -= tmp.cf[i];
+    }
     return diff;
 }
 
@@ -187,20 +177,12 @@ bn_poly_synthetic_division(struct bn_poly *quo, struct bn_poly *rem, const struc
     *rem = bn_Zero_poly; /* struct copy */
 
     if (dvsor->dgr > dvdend->dgr) {
-	*rem = *dvdend;
-	*quo = bn_Zero_poly;
-	return;
+	quo->dgr = -1;
+    } else {
+	quo->dgr = dvdend->dgr - dvsor->dgr;
     }
-
-    if (dvsor->dgr == 0) {
-	for (n=0; n <= quo->dgr; ++n) {
-	    quo->cf[n] /= dvsor->cf[0];
-	}
-	return;
-    }
-
-    quo->dgr = dvdend->dgr - dvsor->dgr;
-    rem->dgr = dvsor->dgr - 1;
+    if ((rem->dgr = dvsor->dgr - 1) > dvdend->dgr)
+	rem->dgr = dvdend->dgr;
 
     for (n=0; n <= quo->dgr; ++n) {
 	quo->cf[n] /= dvsor->cf[0];
@@ -218,11 +200,10 @@ bn_poly_synthetic_division(struct bn_poly *quo, struct bn_poly *rem, const struc
 int
 bn_poly_quadratic_roots(register struct bn_complex *roots, register const struct bn_poly *quadrat)
 {
-    struct bn_poly monic;
     fastf_t discrim, denom, rad;
     const fastf_t small = SMALL_FASTF;
 
-    if (ZERO(quadrat->cf[0]) && fpclassify(quadrat->cf[0]) == FP_ZERO) {
+    if (NEAR_ZERO(quadrat->cf[0], small)) {
 	/* root = -cf[2] / cf[1] */
 	if (NEAR_ZERO(quadrat->cf[1], small)) {
 	    /* No solution.  Now what? */
@@ -235,12 +216,6 @@ bn_poly_quadratic_roots(register struct bn_complex *roots, register const struct
 	return 1;	/* OK - repeated root */
     }
 
-    if (!NEAR_EQUAL(quadrat->cf[0], 1.0, small)) {
-	monic = *quadrat;
-	bn_poly_scale(&monic, 1.0 / monic.cf[0]);
-	quadrat = &monic;
-	}
-
     discrim = quadrat->cf[1]*quadrat->cf[1] - 4.0* quadrat->cf[0]*quadrat->cf[2];
     denom = 0.5 / quadrat->cf[0];
 
@@ -289,7 +264,7 @@ bn_poly_cubic_roots(register struct bn_complex *roots, register const struct bn_
     fastf_t a, b, c1, c1_3rd, delta;
     register int i;
 
-    if (ZERO(eqn->cf[0]) && fpclassify(eqn->cf[0]) == FP_ZERO) return 0;
+    if (ZERO(eqn->cf[0])) return 0;
 
     /* Cardano's formula below is expressed for a monic polynomial. */
     if (!NEAR_EQUAL(eqn->cf[0], 1.0, SMALL_FASTF)) {
@@ -383,7 +358,7 @@ bn_poly_quartic_roots(register struct bn_complex *roots, register const struct b
 
 #define Max3(a, b, c) ((c)>((a)>(b)?(a):(b)) ? (c) : ((a)>(b)?(a):(b)))
 
-    if (ZERO(eqn->cf[0]) && fpclassify(eqn->cf[0]) == FP_ZERO) return 0;
+    if (ZERO(eqn->cf[0])) return 0;
 
     /* Ferrari's formula below is expressed for a monic polynomial. */
     if (!NEAR_EQUAL(eqn->cf[0], 1.0, SMALL_FASTF)) {

src/libbn/qmath.c

@@ -174,14 +174,7 @@ quat_double(quat_t qout, const quat_t q1, const quat_t q2)
 void
 quat_bisect(quat_t qout, const quat_t q1, const quat_t q2)
 {
-    quat_t qsum;
-
-    QADD2(qsum, q1, q2);
-    if (QMAGSQ(qsum) < VDIVIDE_TOL * VDIVIDE_TOL) {
-	quat_slerp(qout, q1, q2, 0.5);
-	return;
-    }
-    QMOVE(qout, qsum);
+    QADD2( qout, q1, q2 );
     QUNITIZE( qout );
 }
 
@@ -309,12 +302,9 @@ quat_log(quat_t out, const quat_t in)
     fastf_t	theta;
     fastf_t	scale;
 
-    scale = MAGNITUDE(in);
-    if (scale > VDIVIDE_TOL) {
+    if ( (scale = MAGNITUDE(in)) > VDIVIDE_TOL )  {
 	theta = atan2( scale, in[W] );
 	scale = theta/scale;
-    } else {
-	scale = 0.0;
     }
 
     VSCALE( out, in, scale );

src/libbn/tests/test_mat.c

@@ -33,22 +33,6 @@ vect_close_or_neg(const vect_t a, const vect_t b, double tol)
 }
 
 
-static int
-lookat_is_valid(const vect_t direction)
-{
-    vect_t expected = {0.0, 0.0, -1.0};
-    vect_t output = VINIT_ZERO;
-    mat_t matrix = MAT_INIT_ZERO;
-
-    bn_mat_lookat(matrix, direction, 0);
-    MAT4X3VEC(output, matrix, direction);
-    VUNITIZE(output);
-
-    return finite_vec(output) && vect_close(output, expected, 1.0e-12)
-	&& orthonormal_rotation(matrix, 1.0e-12);
-}
-
-
 static int
 test_mat_basic(void)
 {
@@ -815,13 +799,6 @@ test_mat_orientation(void)
     int failures = 0;
     const char *test = "mat_orientation";
     struct bn_tol tol = BN_TOL_INIT_TOL;
-    struct bn_tol angular_tol = BN_TOL_INIT_TOL;
-    static const vect_t lookat_directions[] = {
-	{0.0, 0.0, -1.0},
-	{0.0, 0.0, 1.0},
-	{0.0, 0.0, -5.0},
-	{0.0, 0.0, 5.0}
-    };
     vect_t input = {1.0, 2.0, 3.0};
     vect_t perp = VINIT_ZERO;
     vect_t expected_perp = {0.0, 0.0, 1.0};
@@ -829,14 +806,9 @@ test_mat_orientation(void)
     vect_t to = {0.0, 1.0, 0.0};
     vect_t opposite = {-1.0, 0.0, 0.0};
     vect_t dir = {1.0, 1.0, -2.0};
-    vect_t near_from = {1.0, 0.0, 0.0};
-    vect_t near_to = {1.0, 0.1, 0.0};
-    vect_t near_to_unit = VINIT_ZERO;
-    vect_t zero_dir = VINIT_ZERO;
     vect_t out = VINIT_ZERO;
     hvect_t homogeneous = HINIT_ZERO;
     mat_t m = MAT_INIT_ZERO;
-    size_t i;
 
     if (!HZERO(homogeneous)) {
 	report_failure(test, "HZERO failed for a zero homogeneous vector");
@@ -872,18 +844,6 @@ test_mat_orientation(void)
 	failures++;
     }
 
-    angular_tol.dist = 1.0;
-    angular_tol.dist_sq = 1.0;
-    bn_mat_fromto(m, near_from, near_to, &angular_tol);
-    MAT4X3VEC(out, m, near_from);
-    VUNITIZE(out);
-    VMOVE(near_to_unit, near_to);
-    VUNITIZE(near_to_unit);
-    if (VDOT(out, near_to_unit) < 1.0 - 1.0e-12 || !orthonormal_rotation(m, 1.0e-12)) {
-	report_failure(test, "bn_mat_fromto used distance tolerance for angular classification");
-	failures++;
-    }
-
     VUNITIZE(dir);
     bn_mat_lookat(m, dir, 0);
     MAT4X3VEC(out, m, dir);
@@ -894,19 +854,6 @@ test_mat_orientation(void)
 	failures++;
     }
 
-    for (i = 0; i < sizeof(lookat_directions) / sizeof(lookat_directions[0]); i++) {
-	if (!lookat_is_valid(lookat_directions[i])) {
-	    report_failure(test, "bn_mat_lookat failed for an axial direction");
-	    failures++;
-	}
-    }
-
-    bn_mat_lookat(m, zero_dir, 0);
-    if (!mat_close(m, bn_mat_identity, 0.0)) {
-	report_failure(test, "bn_mat_lookat did not return identity for a zero direction");
-	failures++;
-    }
-
     return failures;
 }
 
@@ -917,7 +864,6 @@ test_mat_transform(void)
     int failures = 0;
     const char *test = "mat_transform";
     const double legacy_tol = BN_TOL_DIST;
-    struct bn_tol tol = BN_TOL_INIT_TOL;
     static const struct {
 	double sinv;
 	double cosv;
@@ -973,14 +919,8 @@ test_mat_transform(void)
     point_t p = {2.0, 2.0, 3.0};
     point_t axis_point = {1.0, 2.0, 10.0};
     point_t expected = {1.0, 3.0, 3.0};
-    point_t pivot = {1.0, 2.0, 3.0};
-    point_t pivot_offset = {2.0, 2.0, 3.0};
-    point_t pivot_expected = {1.0, 3.0, 3.0};
     point_t out = VINIT_ZERO;
-    vect_t pivot_direction = {0.0, 0.0, 1.0};
     mat_t m = MAT_INIT_ZERO;
-    mat_t change = MAT_INIT_ZERO;
-    mat_t input = MAT_INIT_ZERO;
     int i;
 
     bn_mat_arb_rot(m, anchor, axis, M_PI_2);
@@ -996,20 +936,6 @@ test_mat_transform(void)
 	failures++;
     }
 
-    bn_mat_zrot(change, 1.0, 0.0);
-    MAT_IDN(input);
-    bn_wrt_point_direc(m, change, input, pivot, pivot_direction, &tol);
-    MAT4X3PNT(out, m, pivot);
-    if (!vect_close(out, pivot, 1.0e-12)) {
-	report_failure(test, "bn_wrt_point_direc moved its pivot point");
-	failures++;
-    }
-    MAT4X3PNT(out, m, pivot_offset);
-    if (!vect_close(out, pivot_expected, 1.0e-12)) {
-	report_failure(test, "bn_wrt_point_direc did not rotate around its pivot point");
-	failures++;
-    }
-
     MAT_IDN(m);
     if (bn_mat_is_non_unif(m) != 0) {
 	report_failure(test, "bn_mat_is_non_unif misclassified the identity matrix");

src/libbn/tests/test_poly.c

@@ -199,153 +199,6 @@ test_poly_ops(void)
 }
 
 
-static int
-test_poly_edge_cases(void)
-{
-    int failures = 0;
-    const char *test = "poly_edge_cases";
-    const double linear_coeffs[] = {1.0, -1.0};
-    const double quadratic_coeffs[] = {1.0, 0.0, -4.0};
-    const double aliased_sum_coeffs[] = {1.0, 1.0, -5.0};
-    const double aliased_difference_coeffs[] = {-1.0, 1.0, 3.0};
-    const double aliased_product_coeffs[] = {1.0, -1.0, -4.0, 4.0};
-    const double dividend_coeffs[] = {1.0, -3.0, 2.0};
-    const double constant_divisor_coeffs[] = {2.0};
-    const double constant_quotient_coeffs[] = {0.5, -1.5, 1.0};
-    const double higher_divisor_coeffs[] = {1.0, 0.0, 1.0};
-    const double degree_six_coeffs[] = {1.0, 0.0, 0.0, 0.0, 0.0, 0.0, 0.0};
-    const double untouched_product_coeffs[] = {42.0};
-    const double zero_coeffs[] = {0.0};
-    const double scaled_quadratic_coeffs[] = {1.0e-12, -5.0e-12, 6.0e-12};
-    const double scaled_cubic_coeffs[] = {1.0e-12, -6.0e-12, 11.0e-12, -6.0e-12};
-    const double scaled_quartic_coeffs[] = {1.0e-12, 0.0, -10.0e-12, 0.0, 9.0e-12};
-    bn_poly_t linear = poly_from_coeffs(1, linear_coeffs);
-    bn_poly_t quadratic = poly_from_coeffs(2, quadratic_coeffs);
-    bn_poly_t dividend = poly_from_coeffs(2, dividend_coeffs);
-    bn_poly_t constant_divisor = poly_from_coeffs(0, constant_divisor_coeffs);
-    bn_poly_t higher_divisor = poly_from_coeffs(2, higher_divisor_coeffs);
-    bn_poly_t degree_six = poly_from_coeffs(6, degree_six_coeffs);
-    bn_poly_t rejected_product = poly_from_coeffs(0, untouched_product_coeffs);
-    bn_poly_t quotient = BN_POLY_INIT_ZERO;
-    bn_poly_t remainder = BN_POLY_INIT_ZERO;
-    bn_poly_t scaled_quadratic = poly_from_coeffs(2, scaled_quadratic_coeffs);
-    bn_poly_t scaled_cubic = poly_from_coeffs(3, scaled_cubic_coeffs);
-    bn_poly_t scaled_quartic = poly_from_coeffs(4, scaled_quartic_coeffs);
-    bn_complex_t roots[4];
-
-    if (!bn_poly_add(&linear, &linear, &quadratic) ||
-	!poly_close(&linear, 2, aliased_sum_coeffs, 0.0)) {
-	report_failure(test, "bn_poly_add did not support output aliasing a lower-degree input");
-	failures++;
-    }
-
-    linear = poly_from_coeffs(1, linear_coeffs);
-    if (!bn_poly_sub(&linear, &linear, &quadratic) ||
-	!poly_close(&linear, 2, aliased_difference_coeffs, 0.0)) {
-	report_failure(test, "bn_poly_sub did not support output aliasing a lower-degree input");
-	failures++;
-    }
-
-    linear = poly_from_coeffs(1, linear_coeffs);
-    if (!bn_poly_mul(&linear, &linear, &quadratic) ||
-	!poly_close(&linear, 3, aliased_product_coeffs, 0.0)) {
-	report_failure(test, "bn_poly_mul did not support output aliasing an input");
-	failures++;
-    }
-
-    if (bn_poly_mul(&rejected_product, &degree_six, &quadratic) ||
-	!poly_close(&rejected_product, 0, untouched_product_coeffs, 0.0)) {
-	report_failure(test, "bn_poly_mul modified its output after a degree-limit failure");
-	failures++;
-    }
-
-    linear = poly_from_coeffs(1, linear_coeffs);
-    bn_poly_synthetic_division(&quotient, &remainder, &dividend, &constant_divisor);
-    if (!poly_close(&quotient, 2, constant_quotient_coeffs, 0.0) ||
-	!poly_close(&remainder, 0, zero_coeffs, 0.0)) {
-	report_failure(test, "bn_poly_synthetic_division failed for a constant divisor");
-	failures++;
-    }
-
-    bn_poly_synthetic_division(&quotient, &remainder, &linear, &higher_divisor);
-    if (!poly_close(&quotient, 0, zero_coeffs, 0.0) ||
-	!poly_close(&remainder, 1, linear_coeffs, 0.0)) {
-	report_failure(test, "bn_poly_synthetic_division mishandled a higher-degree divisor");
-	failures++;
-    }
-
-    if (!bn_poly_quadratic_roots(roots, &scaled_quadratic) ||
-	!has_real_root(roots, 2, 2.0, 1.0e-10) ||
-	!has_real_root(roots, 2, 3.0, 1.0e-10)) {
-	report_failure(test, "bn_poly_quadratic_roots rejected a scaled quadratic");
-	failures++;
-    }
-
-    if (!bn_poly_cubic_roots(roots, &scaled_cubic) ||
-	!has_real_root(roots, 3, 1.0, 1.0e-10) ||
-	!has_real_root(roots, 3, 2.0, 1.0e-10) ||
-	!has_real_root(roots, 3, 3.0, 1.0e-10)) {
-	report_failure(test, "bn_poly_cubic_roots rejected a scaled cubic");
-	failures++;
-    }
-
-    if (!bn_poly_quartic_roots(roots, &scaled_quartic) ||
-	!has_real_root(roots, 4, -3.0, 1.0e-8) ||
-	!has_real_root(roots, 4, -1.0, 1.0e-8) ||
-	!has_real_root(roots, 4, 1.0, 1.0e-8) ||
-	!has_real_root(roots, 4, 3.0, 1.0e-8)) {
-	report_failure(test, "bn_poly_quartic_roots rejected a scaled quartic");
-	failures++;
-    }
-
-    return failures;
-}
-
-
-static int
-test_multipoly_ops(void)
-{
-    int failures = 0;
-    const char *test = "multipoly_ops";
-    struct bn_multipoly *p1 = bn_multipoly_new(1, 1);
-    struct bn_multipoly *p2 = bn_multipoly_new(3, 2);
-    struct bn_multipoly *sum;
-    struct bn_multipoly *product;
-
-    if (!p1 || !p2 || !bn_multipoly_set(p1, 1, 2, 3.0) ||
-	!bn_multipoly_set(p2, 0, 0, 2.0) ||
-	!bn_multipoly_set(p2, 2, 1, 5.0)) {
-	report_failure(test, "could not construct bivariate polynomial operands");
-	bn_multipoly_free(p1);
-	bn_multipoly_free(p2);
-	return failures + 1;
-    }
-
-    sum = bn_multipoly_add(p1, p2);
-    product = bn_multipoly_mul(p1, p2);
-    if (!sum || sum->dgrs != 3 || sum->dgrt != 3 ||
-	!scalar_close(sum->cf[0][0], 2.0, 0.0) ||
-	!scalar_close(sum->cf[1][2], 3.0, 0.0) ||
-	!scalar_close(sum->cf[2][1], 5.0, 0.0)) {
-	report_failure(test, "bn_multipoly_add did not preserve differently sized operands");
-	failures++;
-    }
-
-    if (!product || product->dgrs != 4 || product->dgrt != 4 ||
-	!scalar_close(product->cf[1][2], 6.0, 0.0) ||
-	!scalar_close(product->cf[3][3], 15.0, 0.0)) {
-	report_failure(test, "bn_multipoly_mul did not accumulate coefficient products");
-	failures++;
-    }
-
-    bn_multipoly_free(product);
-    bn_multipoly_free(sum);
-    bn_multipoly_free(p2);
-    bn_multipoly_free(p1);
-    return failures;
-}
-
-
 static int
 test_poly_legacy(void)
 {
@@ -700,8 +553,6 @@ test_poly_roots(void)
 
 static const struct bn_api_case poly_cases[] = {
     {"ops", test_poly_ops},
-    {"edge", test_poly_edge_cases},
-    {"multipoly", test_multipoly_ops},
     {"legacy", test_poly_legacy},
     {"roots", test_poly_roots},
     {NULL, NULL}

src/libbn/tests/test_qmath.c

@@ -244,12 +244,6 @@ test_qmath_interp(void)
 	failures++;
     }
 
-    quat_bisect(out, qid, qanti);
-    if (!quat_is_unit_finite(out, 1.0e-12)) {
-	report_failure(test, "quat_bisect antipodal branch failed to return a finite unit quaternion");
-	failures++;
-    }
-
     quat_double(exact, qdouble_same_in, qdouble_same_in);
     if (!hvect_close(exact, qdouble_same_expected, 1.0e-3)) {
 	report_failure(test, "quat_double legacy same-input case failed");
@@ -332,8 +326,6 @@ test_qmath_logexp(void)
     quat_t v = {0.2, -0.1, 0.3, 0.0};
     quat_t q = HINIT_ZERO;
     quat_t out = HINIT_ZERO;
-    quat_t qidentity = {0.0, 0.0, 0.0, 1.0};
-    quat_t qzero = HINIT_ZERO;
     quat_t qin = {0.3, 0.4, 0.1, 0.85};
     int i;
 
@@ -355,12 +347,6 @@ test_qmath_logexp(void)
 	failures++;
     }
 
-    quat_log(out, qidentity);
-    if (!hvect_close(out, qzero, 0.0)) {
-	report_failure(test, "quat_log did not map identity to the zero quaternion");
-	failures++;
-    }
-
     for (i = 0; i < (int)(sizeof(exp_cases) / sizeof(exp_cases[0])); i++) {
 	quat_exp(q, exp_cases[i].in);
 	if (!hvect_close(q, exp_cases[i].expected, 1.0e-3)) {

src/libbrep/tools/tools_util.cpp

@@ -250,28 +250,22 @@ brep_translate_scv(
         return -1;
     }
 
-    if (!nurbsSurface)
-        return -2;
-
-    ON_3dPoint point;
-    if (!nurbsSurface->GetCV(i, j, point))
-        return -3;
-
-    point.x += dx;
-    point.y += dy;
-    point.z += dz;
-
-    bool updated;
-    if (nurbsSurface->IsRational()) {
-        const double weight = nurbsSurface->Weight(i, j);
-        updated = nurbsSurface->SetCV(i, j,
-            ON_4dPoint(point.x * weight, point.y * weight,
-                point.z * weight, weight));
+    double *cv = NULL;
+    if (nurbsSurface) {
+        cv = nurbsSurface->CV(i, j);
     } else {
-        updated = nurbsSurface->SetCV(i, j, point);
+        return -2;
     }
-    if (!updated)
+
+    if (cv) {
+        ON_3dPoint newPt;
+        newPt.x = cv[X] + dx;
+        newPt.y = cv[Y] + dy;
+        newPt.z = cv[Z] + dz;
+        nurbsSurface->SetCV(i, j, newPt);
+    } else {
         return -3;
+    }
 
     return 0;
 }

src/libbu/CMakeLists.txt

@@ -234,7 +234,7 @@ set(
   mime.cmake
   parallel.h
   parallel_cpp11thread.cpp
-  process_private.h
+  process.h
   sha1.h
   struetype.h
   vfont.h

src/libbu/env.c

@@ -388,44 +388,30 @@ mem_sysctl(int type, size_t *memsz)
 	return -2;
 
 #if defined(__FreeBSD__) && defined(HAVE_SYS_SYSCTL_H) && defined(HAVE_SYSCTL)
+    static const char *const page_size_name = "hw.pagesize";
     static const char *const total_memory_name = "hw.physmem";
-    static const char *const available_page_names[] = {
-	"vm.stats.vm.v_free_count",
-	"vm.stats.vm.v_inactive_count",
-	"vm.stats.vm.v_cache_count"
-    };
+    static const char *const free_pages_name = "vm.stats.vm.v_free_count";
 
+    uint64_t page_size = 0;
+    size_t value_size = sizeof(page_size);
+    if (sysctlbyname(page_size_name, &page_size, &value_size, NULL, 0) != 0 ||
+	    page_size == 0)
+	return -1;
     if (type == BU_MEM_PAGE_SIZE)
-	return mem_page_size(memsz);
+	return mem_size_from_uint64(page_size, memsz);
 
     uint64_t memory = 0;
+    value_size = sizeof(memory);
+    const char *memory_name = total_memory_name;
     if (type == BU_MEM_AVAIL) {
-	/* FreeBSD's free queue omits clean inactive and cache pages that the VM
-	 * can reclaim without paging another process.  Counting only v_free_count
-	 * makes an otherwise idle system appear memory-starved and needlessly
-	 * disables memory-aware parallel work. */
-	for (size_t i = 0; i < sizeof(available_page_names) / sizeof(available_page_names[0]); i++) {
-	    uint32_t pages = 0;
-	    size_t value_size = sizeof(pages);
-	    if (sysctlbyname(available_page_names[i], &pages, &value_size,
-		    NULL, 0) != 0 || value_size != sizeof(pages)) {
-		/* v_free_count is required.  Cache accounting is absent on some
-		 * supported FreeBSD versions, so supplementary queues are optional. */
-		if (i == 0)
-		    return -1;
-		continue;
-	    }
-	    if ((uint64_t)pages > UINT64_MAX - memory)
-		return -1;
-	    memory += (uint64_t)pages;
-	}
-	return mem_pages_to_bytes(memory, memsz);
-    }
-
-    size_t value_size = sizeof(memory);
-    if (sysctlbyname(total_memory_name, &memory, &value_size, NULL, 0) != 0 ||
-	    (value_size != sizeof(uint32_t) && value_size != sizeof(uint64_t)))
+	memory_name = free_pages_name;
+	if (sysctlbyname(memory_name, &memory, &value_size, NULL, 0) != 0 ||
+		memory > UINT64_MAX / page_size)
+	    return -1;
+	memory *= page_size;
+    } else if (sysctlbyname(memory_name, &memory, &value_size, NULL, 0) != 0) {
 	return -1;
+    }
 
     return mem_size_from_uint64(memory, memsz);
 #endif

src/libbu/parallel.c

@@ -24,9 +24,6 @@
 #include <ctype.h>
 #include <math.h>
 #include <string.h>
-#if !defined(_WIN32) || defined(__CYGWIN__)
-#  include <stdatomic.h>
-#endif
 
 #ifdef HAVE_SYS_TYPES_H
 #  include <sys/types.h>
@@ -133,36 +130,6 @@ void parallel_cpp11thread(void (*func)(int, void *), size_t ncpu, void *arg);
 
 int BU_SEM_THREAD = BU_SEM_ID_THREAD;
 
-#if defined(_WIN32) && !defined(__CYGWIN__)
-static LONG bu_cpu_limit = 0;
-
-static size_t
-cpu_limit_get(void)
-{
-    return (size_t)InterlockedCompareExchange(&bu_cpu_limit, 0, 0);
-}
-
-static void
-cpu_limit_set(size_t ncpu)
-{
-    (void)InterlockedExchange(&bu_cpu_limit, (LONG)ncpu);
-}
-#else
-static atomic_size_t bu_cpu_limit = ATOMIC_VAR_INIT(0);
-
-static size_t
-cpu_limit_get(void)
-{
-    return atomic_load_explicit(&bu_cpu_limit, memory_order_acquire);
-}
-
-static void
-cpu_limit_set(size_t ncpu)
-{
-    atomic_store_explicit(&bu_cpu_limit, ncpu, memory_order_release);
-}
-#endif
-
 
 typedef enum {
     PARALLEL_GET = 0,
@@ -388,9 +355,7 @@ bu_avail_cpus(void)
     }
 
     if (LIKELY(ncpu > 0)) {
-	size_t cpu_limit = cpu_limit_get();
-	return (cpu_limit && cpu_limit < (size_t)ncpu) ? cpu_limit :
-	    (size_t)ncpu;
+	return ncpu;
     }
 
     /* non-PARALLEL */
@@ -398,13 +363,6 @@ bu_avail_cpus(void)
 }
 
 
-void
-bu_avail_cpus_set(size_t ncpu)
-{
-    cpu_limit_set((ncpu > MAX_PSW) ? MAX_PSW : ncpu);
-}
-
-
 /**********************************************************************/
 
 
@@ -580,10 +538,6 @@ parallel_interface_arg_stub(struct thread_data *user_thread_data)
 void
 bu_parallel(void (*func)(int, void *), size_t ncpu, void *arg)
 {
-    size_t cpu_limit = cpu_limit_get();
-    if (ncpu && cpu_limit && ncpu > cpu_limit)
-	ncpu = cpu_limit;
-
 #ifndef PARALLEL
 
     if (!func)

src/libbu/process.c

@@ -49,7 +49,7 @@
 #include "bu/str.h"
 #include "bu/datetime.h"
 #include "bu/vls.h"
-#include "./process_private.h"
+#include "./process.h"
 
 #ifndef HAVE_KILL
 #  include <TlHelp32.h>
@@ -1077,17 +1077,11 @@ bu_process_poll(struct bu_process *pinfo, int *exit_status)
     }
 
 #if defined(_WIN32)
-    /* An exit code can be available before process teardown releases
-     * inherited files and pipes.  Only report completion once signaled. */
-    DWORD wait_result = WaitForSingleObject(pinfo->hProcess, 0);
-    if (wait_result == WAIT_TIMEOUT)
-	return 0;
-    if (wait_result != WAIT_OBJECT_0)
-	return -1;
-
     DWORD status = 0;
     if (!GetExitCodeProcess(pinfo->hProcess, &status))
 	return -1;
+    if (status == STILL_ACTIVE)
+	return 0;
 
     pinfo->exit_status = (status == BU_MSVC_ABORT_EXIT) ?
 	ERROR_PROCESS_ABORTED : (int)status;

src/libbu/process.h

@@ -1,4 +1,4 @@
-/*              P R O C E S S _ P R I V A T E . H
+/*                      P R O C E S S . H
  * BRL-CAD
  *
  * Copyright (c) 2013-2026 United States Government as represented by
@@ -20,8 +20,8 @@
 
 /* Private libbu process related definitions shared between multiple files */
 
-#ifndef LIBBU_PROCESS_PRIVATE_H
-#define LIBBU_PROCESS_PRIVATE_H
+#ifndef LIBBU_PROCESS_H
+#define LIBBU_PROCESS_H
 
 /* Apparently the termination code on Windows is arbitrary and somewhat
  * ill-defined - see https://bugs.python.org/issue31863 for more info.  Try our
@@ -29,7 +29,7 @@
  * abort identification. */
 #define BU_MSVC_ABORT_EXIT 97101  /* ascii - a == 97 && e == 101 */
 
-#endif /* LIBBU_PROCESS_PRIVATE_H */
+#endif /* LIBBU_PROCESS_H */
 
 /*
  * Local Variables:

src/libbu/scan.c

@@ -22,54 +22,59 @@
 
 #include <stdio.h>
 #include <stdarg.h>
-#include <stdlib.h>
 #include <string.h>
 #include "vmath.h"
 
 #include "bu/log.h"
+#include "bu/malloc.h"
+#include "bu/str.h"
 
 int
 bu_scan_fastf_t(int *c, const char *src, const char *delim, size_t n, ...)
 {
     va_list ap;
     int offset = 0;
-    int current_n = 0;
+    int current_n = 0, part_n = 0;
+    int len, delim_len;
     size_t i;
+    char *delim_fmt;
 
-    if (c) {
-	*c = 0;
-    }
-
-
-    if (UNLIKELY(!delim || !*delim || n < 1)) {
+    if (UNLIKELY(!delim || n < 1)) {
 	return 0;
     }
 
     va_start(ap, n);
 
+    /* TODO: we should just simply skip all occurrences of delim chars
+     * after reading a fastf_t, avoid dynamic memory allocation and
+     * avoid scanf/sscanf (we don't need to scan the delimiter, just
+     * skip chars in a loop until none are found.
+     */
+
+    delim_len = (int)strlen(delim);
+    /* + 3 here to make room for the two characters '%' and 'n' as
+     * well as the terminating '\0'
+     */
+    delim_fmt = (char *)bu_malloc(delim_len + 3, "bu_scan_fastf_t");
+    bu_strlcpy(delim_fmt, delim, delim_len + 1);
+    bu_strlcat(delim_fmt, "%n", delim_len + 3);
+
     for (i = 0; i < n; i++) {
-	double scan = 0.0;
+	/* Read in the next fastf_t */
+	double scan = 0;
 	fastf_t *arg;
 
-	if (src) {
-	    const char *input = src + offset;
-	    char *end;
+	if (src)
+	    part_n = sscanf(src + offset, "%lf%n", &scan, &len);
+	else
+	    part_n = scanf("%lf%n", &scan, &len);
 
-	    scan = strtod(input, &end);
-	    if (end == input) {
-		break;
-	    }
-	    offset += (int)(end - input);
-	} else {
-	    int len = 0;
-
-	    if (scanf("%lf%n", &scan, &len) != 1) {
-		break;
-	    }
-	    offset += len;
+	current_n += part_n;
+	offset += len;
+	if (part_n != 1) {
+	    break;
 	}
 
-	current_n++;
 	arg = va_arg(ap, fastf_t *);
 	if (arg) {
 	    *arg = scan;
@@ -79,35 +84,25 @@ bu_scan_fastf_t(int *c, const char *src, const char *delim, size_t n, ...)
 	    break;
 	}
 
-	if (src) {
-	    const char *input = src + offset;
+	/* Make sure that a delimiter is present */
+	if (src)
+	    part_n = sscanf(src + offset, delim_fmt, &len);
+	else
+	    part_n = scanf(delim_fmt, &len);
 
-	    while (*input && strchr(delim, *input)) {
-		input++;
-	    }
-	    if (input == src + offset) {
-		break;
-	    }
-	    offset += (int)(input - (src + offset));
-	} else {
-	    int character;
-	    int delimiter_count = 0;
+	offset += len;
 
-	    while ((character = fgetc(stdin)) != EOF) {
-		if (!strchr(delim, character)) {
-		    (void)ungetc(character, stdin);
-		    break;
-		}
-		delimiter_count++;
-		offset++;
-	    }
-	    if (!delimiter_count) {
-		break;
-	    }
+	/* as delim_fmt should only have a %n and that doesn't get
+	 * counted in the scanf return, make sure the return is 0 as
+	 * no values should be scanned.
+	 */
+	if (part_n != 0 || len != delim_len) {
+	    break;
 	}
     }
 
     va_end(ap);
+    bu_free(delim_fmt, "bu_scan_fastf_t");
 
     if (c) {
 	*c = offset;

src/libbu/temp.c

@@ -210,7 +210,7 @@ mkstemp(char *file_template)
 	for (i=(int)start; i>=(int)end; i--) {
 	    file_template[i] = replace[(int)(replacelen * ((double)rand() / (double)RAND_MAX))];
 	}
-	fd = open(file_template, O_CREAT | O_EXCL | O_TRUNC | O_RDWR | O_BINARY, S_IRUSR | S_IWUSR);
+	fd = open(file_template, O_CREAT | O_EXCL | O_TRUNC | O_RDWR, S_IRUSR | S_IWUSR);
     } while ((fd == -1) && (counter++ < 1000));
 
     return fd;
@@ -285,15 +285,6 @@ bu_temp_file(char *filepath, size_t len)
 	return NULL;
     }
 
-    /* Ensure the descriptor is binary before associating it with a stream. */
-    if (UNLIKELY(setmode(fd, O_BINARY) == -1)) {
-	perror("setmode");
-	close(fd);
-	bu_file_delete(tempfile);
-	bu_log(_TF_FAIL);
-	return NULL;
-    }
-
     if (filepath) {
 	if (UNLIKELY(len < strlen(tempfile))) {
 	    bu_log("INTERNAL ERROR: bu_temp_file filepath buffer size is insufficient (%zu < %zu)\n", len, strlen(tempfile));

src/libbu/tests/CMakeLists.txt

@@ -42,7 +42,6 @@ set(
   test_process.c
   test_ptbl.c
   test_realpath.c
-  test_scan.c
   test_semaphore.c
   test_snooze.c
   test_sort.c
@@ -128,7 +127,6 @@ brlcad_add_test(NAME bu_list_empty COMMAND bu_test test_list 0)
 brlcad_add_test(NAME bu_list_single COMMAND bu_test test_list 1)
 brlcad_add_test(NAME bu_list_many COMMAND bu_test test_list 16)
 brlcad_add_test(NAME bu_sscanf_compare COMMAND bu_sscanf)
-brlcad_add_test(NAME bu_scan_fastf_t COMMAND bu_test test_scan)
 brlcad_add_test(NAME bu_gethostname_lookup COMMAND bu_gethostname)
 
 
@@ -200,7 +198,6 @@ brlcad_add_test(NAME bu_file_mime_png   COMMAND bu_test test_file_mime png 3 BU_
 #      bu_temp_filename testing    #
 ####################################
 brlcad_add_test(NAME bu_temp_filename  COMMAND bu_test test_temp_filename "single")
-brlcad_add_test(NAME bu_temp_binary    COMMAND bu_test test_temp_filename "binary")
 #BRLCAD_ADD_TEST(NAME bu_temp_filename  COMMAND bu_test test_temp_filename "parallel")
 
 #

src/libbu/tests/test_env.c

@@ -40,7 +40,7 @@
 
 #include "bio.h"
 #include "bresource.h"
-#if (defined(__APPLE__) || defined(__FreeBSD__)) && defined(HAVE_SYS_SYSCTL_H)
+#if defined(__APPLE__) && defined(HAVE_SYS_SYSCTL_H)
 #  include <sys/sysctl.h>
 #endif
 
@@ -214,12 +214,8 @@ mem_test_failure(const char *query, ssize_t result, const size_t *output,
 
 
 static int
-platform_mem_tests(ssize_t all_mem, ssize_t avail_mem, ssize_t page_mem)
+platform_mem_tests(ssize_t all_mem)
 {
-    (void)all_mem;
-    (void)avail_mem;
-    (void)page_mem;
-
 #if defined(__APPLE__) && defined(HAVE_SYS_SYSCTL_H)
     uint64_t native_total = 0;
     size_t value_size = sizeof(native_total);
@@ -234,51 +230,8 @@ platform_mem_tests(ssize_t all_mem, ssize_t avail_mem, ssize_t page_mem)
 	    "reported %llu\n", all_mem, (unsigned long long)native_total);
 	return -2;
     }
-#elif defined(__FreeBSD__) && defined(HAVE_SYS_SYSCTL_H)
-    uint64_t native_total = 0;
-    size_t value_size = sizeof(native_total);
-    if (sysctlbyname("hw.physmem", &native_total, &value_size, NULL, 0) != 0 ||
-	    (value_size != sizeof(uint32_t) && value_size != sizeof(uint64_t))) {
-	bu_log("bu_mem platform test: unable to query hw.physmem\n");
-	return -1;
-    }
-    if (native_total != (uint64_t)all_mem) {
-	bu_log("bu_mem platform test: BU_MEM_ALL returned %zd; hw.physmem "
-	    "reported %llu\n", all_mem, (unsigned long long)native_total);
-	return -2;
-    }
-
-    uint64_t reclaimable_pages = 0;
-    const char *const page_names[] = {
-	"vm.stats.vm.v_free_count",
-	"vm.stats.vm.v_inactive_count",
-	"vm.stats.vm.v_cache_count"
-    };
-    for (size_t i = 0; i < sizeof(page_names) / sizeof(page_names[0]); i++) {
-	uint32_t pages = 0;
-	value_size = sizeof(pages);
-	if (sysctlbyname(page_names[i], &pages, &value_size, NULL, 0) != 0 ||
-		value_size != sizeof(pages)) {
-	    if (i == 0)
-		return -3;
-	    continue;
-	}
-	reclaimable_pages += pages;
-    }
-    /* VM counters may change between the bu_mem and direct sysctl queries.
-     * A one-percent allowance is ample for that race while still detecting
-     * the former free-pages-only implementation. */
-    uint64_t native_available = reclaimable_pages * (uint64_t)page_mem;
-    uint64_t allowance = native_total / 100u;
-    uint64_t available_difference = ((uint64_t)avail_mem > native_available) ?
-	(uint64_t)avail_mem - native_available :
-	native_available - (uint64_t)avail_mem;
-    if (available_difference > allowance) {
-	bu_log("bu_mem platform test: BU_MEM_AVAIL returned %zd; FreeBSD "
-	    "reclaimable queues reported %llu\n", avail_mem,
-	    (unsigned long long)native_available);
-	return -4;
-    }
+#else
+    (void)all_mem;
 #endif
     return 0;
 }
@@ -492,7 +445,7 @@ main(int ac, char *av[])
     if (avail_mem > all_mem)
 	return mem_test_failure("BU_MEM_AVAIL exceeds BU_MEM_ALL", avail_mem,
 	    NULL, -5);
-    if (platform_mem_tests(all_mem, avail_mem, page_mem) != 0)
+    if (platform_mem_tests(all_mem) != 0)
 	return -6;
     ssize_t process_mem = bu_mem(BU_MEM_PROCESS_AVAIL, NULL);
     ssize_t resident_mem = bu_mem(BU_MEM_PROCESS_RESIDENT, NULL);

src/libbu/tests/test_parallel.c

@@ -121,30 +121,6 @@ main(int argc, char *argv[])
     if (bu_getprogname()[0] == '\0')
 	bu_setprogname(argv[0]);
 
-    {
-	size_t detected_cpus = bu_avail_cpus();
-	size_t requested_cpus = (detected_cpus > MAX_PSW) ? MAX_PSW :
-	    detected_cpus;
-	struct parallel_data limit_data = {1, NULL};
-	bu_avail_cpus_set(1);
-	if (bu_avail_cpus() != 1) {
-	    bu_log("bu_avail_cpus process limit [FAIL]\n");
-	    return 1;
-	}
-	memset(counter, 0, sizeof(counter));
-	bu_parallel(callback, requested_cpus, &limit_data);
-	if (tally(MAX_PSW) != 1) {
-	    bu_log("bu_parallel process limit [FAIL]\n");
-	    return 1;
-	}
-	bu_avail_cpus_set(0);
-	if (bu_avail_cpus() != detected_cpus) {
-	    bu_log("bu_avail_cpus process limit reset [FAIL]\n");
-	    return 1;
-	}
-	bu_log("bu_avail_cpus and bu_parallel process limit [PASS]\n");
-    }
-
     while ((c = bu_getopt(argc, argv, "P:!:")) != -1) {
 	switch (c) {
 	    case 'P':
@@ -161,9 +137,8 @@ main(int argc, char *argv[])
     }
 
     /* test calling without a hook function */
-    memset(counter, 0, sizeof(counter));
     bu_parallel(NULL, ncpu, NULL);
-    if (tally(MAX_PSW) != 0) {
+    if (tally(ncpu) != 0) {
 	bu_log("bu_parallel zero callback [FAIL]\n");
 	return 1;
     }

src/libbu/tests/test_scan.c

@@ -1,173 +0,0 @@
-/*                     T E S T _ S C A N . C
- * BRL-CAD
- *
- * Copyright (c) 2026 United States Government as represented by
- * the U.S. Army Research Laboratory.
- *
- * This library is free software; you can redistribute it and/or
- * modify it under the terms of the GNU Lesser General Public License
- * version 2.1 as published by the Free Software Foundation.
- *
- * This library is distributed in the hope that it will be useful, but
- * WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this file; see the file named COPYING for more
- * information.
- */
-/** @file test_scan.c
- *
- */
-
-#include "common.h"
-
-#include <string.h>
-
-#include "test_api.h"
-
-
-static int
-scan_fastf_repeated_delimiters(void)
-{
-    const char *input = "0.0,,0.0,1.0";
-    fastf_t first = -1.0;
-    fastf_t second = -1.0;
-    fastf_t third = -1.0;
-    int chars = -1;
-
-    return bu_scan_fastf_t(&chars, input, ",", 3,
-	&first, &second, &third) == 3
-	&& chars == (int)strlen(input)
-	&& ZERO(first)
-	&& ZERO(second)
-	&& EQUAL(third, 1.0);
-}
-
-
-static int
-scan_fastf_mixed_delimiters(void)
-{
-    const char *input = "1, ;2,, 3";
-    fastf_t first = -1.0;
-    fastf_t second = -1.0;
-    fastf_t third = -1.0;
-    int chars = -1;
-
-    return bu_scan_fastf_t(&chars, input, ",; ", 3,
-	&first, &second, &third) == 3
-	&& chars == (int)strlen(input)
-	&& EQUAL(first, 1.0)
-	&& EQUAL(second, 2.0)
-	&& EQUAL(third, 3.0);
-}
-
-
-static int
-scan_fastf_percent_delimiter(void)
-{
-    const char *input = "1%2%%3";
-    fastf_t first = -1.0;
-    fastf_t second = -1.0;
-    fastf_t third = -1.0;
-    int chars = -1;
-
-    return bu_scan_fastf_t(&chars, input, "%", 3,
-	&first, &second, &third) == 3
-	&& chars == (int)strlen(input)
-	&& EQUAL(first, 1.0)
-	&& EQUAL(second, 2.0)
-	&& EQUAL(third, 3.0);
-}
-
-
-static int
-scan_fastf_reports_consumed_prefix(void)
-{
-    fastf_t first = -1.0;
-    fastf_t second = -1.0;
-    int chars = -1;
-
-    return bu_scan_fastf_t(&chars, "1,not-a-number", ",", 2,
-	&first, &second) == 1
-	&& chars == 2
-	&& EQUAL(first, 1.0)
-	&& EQUAL(second, -1.0);
-}
-
-
-static int
-scan_fastf_accepts_null_destinations(void)
-{
-    fastf_t second = -1.0;
-    int chars = -1;
-
-    return bu_scan_fastf_t(&chars, "1,2", ",", 2,
-	NULL, &second) == 2
-	&& chars == 3
-	&& EQUAL(second, 2.0);
-}
-
-
-static int
-scan_fastf_rejects_invalid_configuration(void)
-{
-    fastf_t value = -1.0;
-    int chars = -1;
-
-    if (bu_scan_fastf_t(&chars, "1", NULL, 1, &value) != 0
-	|| chars != 0 || !EQUAL(value, -1.0))
-	return 0;
-
-    chars = -1;
-    if (bu_scan_fastf_t(&chars, "1", "", 1, &value) != 0
-	|| chars != 0 || !EQUAL(value, -1.0))
-	return 0;
-
-    chars = -1;
-    return bu_scan_fastf_t(&chars, "1", ",", 0) == 0 && chars == 0;
-}
-
-
-static int
-test_scan(void)
-{
-    int errors = 0;
-
-    TEST_API_CHECK(scan_fastf_repeated_delimiters(),
-	"bu_scan_fastf_t should skip repeated delimiters");
-    TEST_API_CHECK(scan_fastf_mixed_delimiters(),
-	"bu_scan_fastf_t should treat delim as a character set");
-    TEST_API_CHECK(scan_fastf_percent_delimiter(),
-	"bu_scan_fastf_t should treat percent as delimiter data");
-    TEST_API_CHECK(scan_fastf_reports_consumed_prefix(),
-	"bu_scan_fastf_t should report the deterministic consumed prefix");
-    TEST_API_CHECK(scan_fastf_accepts_null_destinations(),
-	"bu_scan_fastf_t should accept NULL value destinations");
-    TEST_API_CHECK(scan_fastf_rejects_invalid_configuration(),
-	"bu_scan_fastf_t should reset c for invalid configuration");
-
-    return errors ? BRLCAD_ERROR : BRLCAD_OK;
-}
-
-
-int
-main(int UNUSED(argc), char *argv[])
-{
-    if (bu_getprogname()[0] == '\0') {
-	bu_setprogname(argv[0]);
-    }
-
-    return test_scan();
-}
-
-/*
- * Local Variables:
- * tab-width: 8
- * mode: C
- * indent-tabs-mode: t
- * c-file-style: "stroustrup"
- * End:
- * ex: shiftwidth=4 tabstop=8 cino=N-s
- */

src/libbu/tests/test_temp_filename.c

@@ -35,57 +35,6 @@
 
 #include "common.h"
 
-#include <string.h>
-
-#include "bio.h"
-#include "bu/app.h"
-#include "bu/file.h"
-
-
-static int
-temp_file_binary(void)
-{
-    /* LF and DOS EOF expose text-mode translation on Windows. */
-    const unsigned char expected[] = {0x00, 0x0a, 0x1a, 0x0d, 0xff};
-    unsigned char actual[sizeof(expected) + 1] = {0};
-    char path[MAXPATHLEN] = {0};
-    size_t count;
-    FILE *fp = bu_temp_file(path, sizeof(path));
-
-    if (!fp) {
-	bu_log("temp_filename failure: cannot create temporary file\n");
-	return 1;
-    }
-
-    count = fwrite(expected, 1, sizeof(expected), fp);
-    if (fclose(fp) != 0 || count != sizeof(expected)) {
-	bu_log("temp_filename failure: cannot write binary data\n");
-	bu_file_delete(path);
-	return 1;
-    }
-
-    fp = fopen(path, "rb");
-    if (!fp) {
-	bu_log("temp_filename failure: cannot reopen temporary file\n");
-	bu_file_delete(path);
-	return 1;
-    }
-
-    count = fread(actual, 1, sizeof(actual), fp);
-    if (fclose(fp) != 0 || count != sizeof(expected) || memcmp(actual, expected, sizeof(expected))) {
-	bu_log("temp_filename failure: binary data changed (%zu bytes read, expected %zu)\n", count, sizeof(expected));
-	bu_file_delete(path);
-	return 1;
-    }
-
-    if (!bu_file_delete(path)) {
-	bu_log("temp_filename failure: cannot delete temporary file\n");
-	return 1;
-    }
-
-    return 0;
-}
-
 
 static void
 temp_filename_thread(int cpu, void* ptr)
@@ -147,9 +96,6 @@ main(int argc, char *argv[])
 	    if (strlen(under_size) != 4)    /* buffer size -1 */
 		bu_exit(EXIT_FAILURE, "temp_filename failure: expected size [%d], got [%ld]]\n", 4, strlen(under_size));
 
-	} else if (!bu_strcmp(curr, "binary")) {
-	    if (temp_file_binary())
-		return EXIT_FAILURE;
 	} else if (!bu_strcmp(curr, "parallel")) {
 	    // test parallel / threaded -
 	    uint8_t threads = bu_avail_cpus();

src/libbu/vfont.c

@@ -26,10 +26,11 @@
 #include "bu/app.h"
 #include "bu/malloc.h"
 #include "bu/vfont.h"
-#include "bu/vls.h"
 
 #define FONTDIR2 "/usr/lib/vfont"
 #define DEFAULT_FONT "nonie.r.12"
+#define FONTNAMESZ 128
+
 #include "./vfont.h"
 
 
@@ -126,7 +127,7 @@ vfont_get(char *font)
     register struct vfont *vfp = VFONT_NULL;
     register FILE *fp = NULL;
     register int i;
-    struct bu_vls fname = BU_VLS_INIT_ZERO;
+    char fname[FONTNAMESZ] = {'\0'};
     unsigned char header[2*5];		/* 5 16-bit vax shorts */
     unsigned char dispatch[10*256];	/* 256 10-byte structs */
     uint16_t magic;
@@ -134,24 +135,21 @@ vfont_get(char *font)
     const char *const_font;
 
     const_font = (font == NULL) ? DEFAULT_FONT : (const char *)font;
-    bu_vls_strcpy(&fname, const_font);
 
     /* Open the file and read in the header information. */
     if ((fp = fopen(const_font, "rb")) == NULL) {
-	bu_vls_sprintf(&fname, "%s/%s", bu_dir(NULL, 0, BU_DIR_DATA, "vfont", NULL), const_font);
-	if ((fp = fopen(bu_vls_addr(&fname), "rb")) == NULL) {
-	    bu_vls_sprintf(&fname, "%s/%s", FONTDIR2, const_font);
-	    if ((fp = fopen(bu_vls_addr(&fname), "rb")) == NULL) {
-		bu_vls_free(&fname);
+	snprintf(fname, FONTNAMESZ, "%s/%s", bu_dir(NULL, 0, BU_DIR_DATA, "vfont", NULL), const_font);
+	if ((fp = fopen(fname, "rb")) == NULL) {
+	    snprintf(fname, FONTNAMESZ, "%s/%s", FONTDIR2, const_font);
+	    if ((fp = fopen(fname, "rb")) == NULL) {
 		return VFONT_NULL;
 	    }
 	}
     }
     if (fread((char *)header, sizeof(header), 1, fp) != 1 ||
 	fread((char *)dispatch, sizeof(dispatch), 1, fp) != 1) {
-	fprintf(stderr, "vfont_get(%s):  header read error\n", bu_vls_addr(&fname));
+	fprintf(stderr, "vfont_get(%s):  header read error\n", fname);
 	fclose(fp);
-	bu_vls_free(&fname);
 	return VFONT_NULL;
     }
     magic = _vax_gshort(&header[0*2]) & 0xFFFF;
@@ -159,9 +157,8 @@ vfont_get(char *font)
 
     if (UNLIKELY(magic != 0436)) {
 	fprintf(stderr, "vfont_get(%s):  bad magic number 0%o\n",
-		bu_vls_addr(&fname), magic);
+		fname, magic);
 	fclose(fp);
-	bu_vls_free(&fname);
 	return VFONT_NULL;
     }
 
@@ -169,11 +166,10 @@ vfont_get(char *font)
     BU_ALLOC(vfp, struct vfont);
     vfp->vf_bits = (char *)bu_malloc((size_t)size, "vfont bits");
     if (fread(vfp->vf_bits, (size_t)size, 1, fp) != 1) {
-	fprintf(stderr, "vfont_get(%s):  bitmap read error\n", bu_vls_addr(&fname));
+	fprintf(stderr, "vfont_get(%s):  bitmap read error\n", fname);
 	fclose(fp);
 	bu_free(vfp->vf_bits, "vfont bits");
 	bu_free((char *)vfp, "vfont");
-	bu_vls_free(&fname);
 	return VFONT_NULL;
     }
 
@@ -198,7 +194,6 @@ vfont_get(char *font)
 	vdp->vd_width = _vax_gshort(&cp[8]);
     }
     fclose(fp);
-    bu_vls_free(&fname);
     return vfp;
 }
 

src/libdm/glx/dm-ogl.c

@@ -891,8 +891,8 @@ Done:
 int
 ogl_share_dlist(struct dm *dmp1, struct dm *dmp2)
 {
-    struct gl_vars *mvars;
-    struct pogl_vars *privars;
+    struct gl_vars *mvars = (struct gl_vars *)dmp1->i->m_vars;
+    struct pogl_vars *privars = (struct pogl_vars *)dmp1->i->dm_vars.priv_vars;
     GLfloat backgnd[4];
     GLfloat vf;
     GLXContext old_glxContext;
@@ -900,9 +900,6 @@ ogl_share_dlist(struct dm *dmp1, struct dm *dmp2)
     if (dmp1 == (struct dm *)NULL)
 	return BRLCAD_ERROR;
 
-    mvars = (struct gl_vars *)dmp1->i->m_vars;
-    privars = (struct pogl_vars *)dmp1->i->dm_vars.priv_vars;
-
     if (dmp2 == (struct dm *)NULL) {
 	/* create a new graphics context for dmp1 with private display lists */
 
@@ -1056,11 +1053,6 @@ ogl_share_dlist(struct dm *dmp1, struct dm *dmp2)
 	glXDestroyContext(((struct dm_glxvars *)dmp2->i->dm_vars.pub_vars)->dpy, old_glxContext);
     }
 
-    struct dm *target_dmp = dmp2 ? dmp2 : dmp1;
-    struct gl_vars *target_mvars = (struct gl_vars *)target_dmp->i->m_vars;
-    gl_setZBuffer(target_dmp, target_mvars->zbuffer_on);
-    gl_setLight(target_dmp, target_mvars->lighting_on);
-
     return BRLCAD_OK;
 }
 

src/libdm/qtgl/dm-qtgl.cpp

@@ -254,9 +254,15 @@ qtgl_open(void *ctx, void *UNUSED(interp), int argc, const char **argv)
     if (bu_vls_strlen(&dmp->i->dm_pathName) == 0)
 	bu_vls_printf(&dmp->i->dm_pathName, ".dm_qtgl%d", count);
     ++count;
-    /* The supplied QOpenGLWidget determines the Qt display.  Keep dm_dName
-     * empty unless the caller supplied -d; DISPLAY is an X11 setting and
-     * cannot identify a Qt context on every supported platform. */
+    if (bu_vls_strlen(&dmp->i->dm_dName) == 0) {
+	char *dp;
+
+	dp = getenv("DISPLAY");
+	if (dp)
+	    bu_vls_strcpy(&dmp->i->dm_dName, dp);
+	else
+	    bu_vls_strcpy(&dmp->i->dm_dName, ":0.0");
+    }
 
     /* initialize dm specific variables */
     pubvars->devmotionnotify = 0;

src/libdm/swrast/dm-swrast.cpp

@@ -246,9 +246,15 @@ swrast_open(void *ctx, void *UNUSED(interp), int argc, const char **argv)
     if (bu_vls_strlen(&dmp->i->dm_pathName) == 0)
 	bu_vls_printf(&dmp->i->dm_pathName, ".dm_swrast%d", count);
     ++count;
-    /* OSMesa is offscreen and has no display to discover.  Leave dm_dName
-     * empty unless the caller supplied -d; a window-system wrapper can then
-     * select its own initialized display without inheriting X11 state. */
+    if (bu_vls_strlen(&dmp->i->dm_dName) == 0) {
+	char *dp;
+
+	dp = getenv("DISPLAY");
+	if (dp)
+	    bu_vls_strcpy(&dmp->i->dm_dName, dp);
+	else
+	    bu_vls_strcpy(&dmp->i->dm_dName, ":0.0");
+    }
 
     /* initialize dm specific variables */
     pubvars->devmotionnotify = 0;