BRL-CAD/Clipper2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix linking to m.lib on Windows (#1080)

Browse Source 
We separate configuring warnings and linking to the math library. This way, it works for clang on Windows when using Microsoft's standard library.
This commit is contained in:
Cem GEÇGEL
2026-03-21 08:07:31 +10:00
committed by GitHub
parent 46f639177f
commit c324e7bdcb
1 changed files with 23 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CPP/CMakeLists.txt
+23 -9
View File
@@ -77,12 +77,19 @@ if (NOT (CLIPPER2_USINGZ STREQUAL "ONLY"))
$<INSTALL_INTERFACE:include>
)
if (MSVC)
# Configure the warning flags.
if (CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC")
target_compile_options(Clipper2 PRIVATE /W4 /WX)
else()
elseif (CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "GNU")
target_compile_options(Clipper2 PRIVATE -Wall -Wextra -Wpedantic -Werror)
else ()
message(AUTHOR_WARNING "Clipper2: cannot configure warnings for the unrecognized C++ compiler front end ${CMAKE_CXX_COMPILER_FRONTEND_VARIANT}")
endif ()
# On Windows, if using Microsoft's the standard library, there is no `m.lib`.
if (NOT WIN32 OR MINGW)
target_link_libraries(Clipper2 PUBLIC -lm)
endif()
endif ()
endif()
# secondary Clipper2 library with USINGZ defined (if required)
@@ -102,12 +109,19 @@ if (NOT (CLIPPER2_USINGZ STREQUAL "OFF"))
$<INSTALL_INTERFACE:include>
)
if (MSVC)
target_compile_options(Clipper2Z PRIVATE /W4 /WX)
else()
target_compile_options(Clipper2Z PRIVATE -Wall -Wextra -Wpedantic -Werror)
target_link_libraries(Clipper2Z PUBLIC -lm)
endif()
# Configure the warning flags.
if (CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "MSVC")
target_compile_options(Clipper2 PRIVATE /W4 /WX)
elseif (CMAKE_CXX_COMPILER_FRONTEND_VARIANT STREQUAL "GNU")
target_compile_options(Clipper2 PRIVATE -Wall -Wextra -Wpedantic -Werror)
else ()
message(AUTHOR_WARNING "Clipper2: cannot configure warnings for the unrecognized C++ compiler front end ${CMAKE_CXX_COMPILER_FRONTEND_VARIANT}")
endif ()
# On Windows, if using Microsoft's the standard library, there is no `m.lib`.
if (NOT WIN32 OR MINGW)
target_link_libraries(Clipper2 PUBLIC -lm)
endif ()
endif()
set_target_properties(${CLIPPER2_LIBS} PROPERTIES FOLDER Libraries