Files
assimp/code/PostProcessing/GenBoundingBoxesProcess.cpp
3a38cd1e87 GenBoundingBoxes: fix AABB for meshes with coordinates beyond +/-999999 (#6756)
* GenBoundingBoxes: fix AABB for meshes with coordinates beyond +/-999999

The min/max accumulators were initialized with +/-999999 sentinel values.
Meshes with any coordinate beyond that range (e.g. projected geographic
coordinate systems like Swiss LV95 with eastings around 2.6e6, or
millimeter-unit CAD files) produced wildly wrong bounding boxes because
the accumulators never moved past the sentinels.

Initialize with std::numeric_limits<ai_real>::max() instead, and skip
meshes without vertices so their AABB stays at the default zero value
rather than being filled with sentinels.

Assisted-by: Claude
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Address review: kMaxVal/kOffset naming, negative-offset and empty-mesh coverage

Assisted-by: Claude
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Address review: PascalCase test names

Assisted-by: Claude
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Kim Kulling <kimkulling@users.noreply.github.com>
2026-08-05 09:25:09 +02:00

110 lines
3.4 KiB
C++

/*
---------------------------------------------------------------------------
Open Asset Import Library (assimp)
---------------------------------------------------------------------------
Copyright (c) 2006-2026, assimp team
All rights reserved.
Redistribution and use of this software in source and binary forms,
with or without modification, are permitted provided that the following
conditions are met:
* Redistributions of source code must retain the above
copyright notice, this list of conditions and the
following disclaimer.
* Redistributions in binary form must reproduce the above
copyright notice, this list of conditions and the
following disclaimer in the documentation and/or other
materials provided with the distribution.
* Neither the name of the assimp team, nor the names of its
contributors may be used to endorse or promote products
derived from this software without specific prior
written permission of the assimp team.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
---------------------------------------------------------------------------
*/
#ifndef ASSIMP_BUILD_NO_GENBOUNDINGBOXES_PROCESS
#include "PostProcessing/GenBoundingBoxesProcess.h"
#include <assimp/postprocess.h>
#include <assimp/scene.h>
#include <limits>
namespace Assimp {
bool GenBoundingBoxesProcess::IsActive(unsigned int pFlags) const {
return 0 != ( pFlags & aiProcess_GenBoundingBoxes );
}
void checkMesh(aiMesh* mesh, aiVector3D& min, aiVector3D& max) {
ai_assert(nullptr != mesh);
if (0 == mesh->mNumVertices) {
return;
}
for (unsigned int i = 0; i < mesh->mNumVertices; ++i) {
const aiVector3D &pos = mesh->mVertices[i];
if (pos.x < min.x) {
min.x = pos.x;
}
if (pos.y < min.y) {
min.y = pos.y;
}
if (pos.z < min.z) {
min.z = pos.z;
}
if (pos.x > max.x) {
max.x = pos.x;
}
if (pos.y > max.y) {
max.y = pos.y;
}
if (pos.z > max.z) {
max.z = pos.z;
}
}
}
void GenBoundingBoxesProcess::Execute(aiScene* pScene) {
if (nullptr == pScene) {
return;
}
for (unsigned int i = 0; i < pScene->mNumMeshes; ++i) {
aiMesh* mesh = pScene->mMeshes[i];
if (nullptr == mesh || 0 == mesh->mNumVertices) {
continue;
}
constexpr ai_real kMaxVal = std::numeric_limits<ai_real>::max();
aiVector3D min(kMaxVal, kMaxVal, kMaxVal), max(-kMaxVal, -kMaxVal, -kMaxVal);
checkMesh(mesh, min, max);
mesh->mAABB.mMin = min;
mesh->mAABB.mMax = max;
}
}
} // Namespace Assimp
#endif // ASSIMP_BUILD_NO_GENBOUNDINGBOXES_PROCESS