BRL-CAD/OpenColorIO
3
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
RELEASE
OpenColorIO/tests/cpu/DynamicProperty_tests.cpp
T
doug-walkerPatrick HodoulBernard LefebvreBernard Lefebvre
 cfc206886d Adsk Contrib - Fix grading inversion (#1245) 
* Fix grading op inversion

Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>

* Fix dyn prop equality

Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>

* RGB curve inverse

Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>

* Add curve slopes

Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>

* Add serialization test

Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>

* Add frozen python docs

Signed-off-by: Doug Walker <Doug.Walker@autodesk.com>

* Adjust tests after merge from master (v2 is using from_scene_reference instead of from_reference)

Signed-off-by: Bernard Lefebvre <bernard.lefebvre@autodesk.com>

Co-authored-by: Patrick Hodoul <patrick.hodoul@autodesk.com>
Co-authored-by: Bernard Lefebvre <bernard.lefebvre@autodesk.com>
Co-authored-by: Bernard Lefebvre <37628108+BernardLefebvre@users.noreply.github.com>
2021-01-06 12:31:58 -05:00

425 lines
16 KiB
C++
Raw Permalink Blame History

// SPDX-License-Identifier: BSD-3-Clause
// Copyright Contributors to the OpenColorIO Project.
#include <sstream>
#include "DynamicProperty.cpp"
#include "testutils/UnitTest.h"
#include "UnitTestUtils.h"
namespace OCIO = OCIO_NAMESPACE;
OCIO_ADD_TEST(DynamicPropertyImpl, basic)
{
OCIO::DynamicPropertyDoubleImplRcPtr dp =
std::make_shared<OCIO::DynamicPropertyDoubleImpl>(OCIO::DYNAMIC_PROPERTY_EXPOSURE, 1.0, false);
OCIO_REQUIRE_ASSERT(dp);
OCIO_REQUIRE_EQUAL(dp->getValue(), 1.0);
dp->setValue(2.0);
OCIO_CHECK_EQUAL(dp->getValue(), 2.0);
OCIO::DynamicPropertyDoubleImplRcPtr dpImpl =
std::make_shared<OCIO::DynamicPropertyDoubleImpl>(OCIO::DYNAMIC_PROPERTY_EXPOSURE, 1.0, false);
OCIO_REQUIRE_ASSERT(dpImpl);
OCIO_CHECK_ASSERT(!dpImpl->isDynamic());
OCIO_CHECK_EQUAL(dpImpl->getValue(), 1.0);
dpImpl->makeDynamic();
OCIO_CHECK_ASSERT(dpImpl->isDynamic());
dpImpl->setValue(2.0);
OCIO_CHECK_EQUAL(dpImpl->getValue(), 2.0);
}
OCIO_ADD_TEST(DynamicPropertyImpl, equal_double)
{
OCIO::DynamicPropertyDoubleImplRcPtr dpImpl0 =
std::make_shared<OCIO::DynamicPropertyDoubleImpl>(OCIO::DYNAMIC_PROPERTY_EXPOSURE, 1.0, false);
OCIO::DynamicPropertyRcPtr dp0 = dpImpl0;
OCIO::DynamicPropertyDoubleImplRcPtr dpImpl1 =
std::make_shared<OCIO::DynamicPropertyDoubleImpl>(OCIO::DYNAMIC_PROPERTY_EXPOSURE, 1.0, false);
OCIO::DynamicPropertyRcPtr dp1 = dpImpl1;
// Both not dynamic, same value.
OCIO_CHECK_ASSERT(*dp0 == *dp1);
// Both not dynamic, diff values.
dpImpl0->setValue(2.0);
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Same value.
dpImpl1->setValue(2.0);
OCIO_CHECK_ASSERT(*dp0 == *dp1);
// One dynamic, not the other, same value.
dpImpl0->makeDynamic();
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Both dynamic, same value. Equality is used to optimized, so if values are dynamic they
// might or not be the same, but they are considered different so that they are not optimized.
dpImpl1->makeDynamic();
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Both dynamic, different values.
dpImpl1->setValue(3.0);
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
}
namespace
{
OCIO::ConstProcessorRcPtr LoadTransformFile(const std::string & fileName)
{
const std::string filePath(OCIO::GetTestFilesDir() + "/" + fileName);
// Create a FileTransform.
OCIO::FileTransformRcPtr pFileTransform
= OCIO::FileTransform::Create();
pFileTransform->setDirection(OCIO::TRANSFORM_DIR_FORWARD);
pFileTransform->setSrc(filePath.c_str());
// Create empty Config to use.
OCIO::ConfigRcPtr pConfig = OCIO::Config::Create();
// Get the processor corresponding to the transform.
return pConfig->getProcessor(pFileTransform);
}
}
// Test several aspects of dynamic properties, especially the ability to set
// values via the processor.
OCIO_ADD_TEST(DynamicProperty, get_dynamic_via_cpu_processor)
{
const std::string ctfFile("exposure_contrast_video_dp.ctf");
OCIO::ConstProcessorRcPtr processor;
OCIO_CHECK_NO_THROW(processor = LoadTransformFile(ctfFile));
OCIO::ConstCPUProcessorRcPtr cpuProcessor;
OCIO_CHECK_NO_THROW(cpuProcessor = processor->getDefaultCPUProcessor());
float pixel[3] = { 0.5f, 0.4f, 0.2f };
cpuProcessor->applyRGB(pixel);
float error = 1e-5f;
OCIO_CHECK_CLOSE(pixel[0], 0.57495f, error);
OCIO_CHECK_CLOSE(pixel[1], 0.43988f, error);
OCIO_CHECK_CLOSE(pixel[2], 0.19147f, error);
const OCIO::DynamicPropertyType dpt = OCIO::DYNAMIC_PROPERTY_EXPOSURE;
OCIO::DynamicPropertyRcPtr dp;
OCIO_CHECK_NO_THROW(dp = cpuProcessor->getDynamicProperty(dpt));
auto dpDouble = OCIO_DYNAMIC_POINTER_CAST<OCIO::DynamicPropertyDouble>(dp);
const double fileValue = dpDouble->getValue();
dpDouble->setValue(0.4);
pixel[0] = 0.5f;
pixel[1] = 0.4f;
pixel[2] = 0.2f;
cpuProcessor->applyRGB(pixel);
// Adjust error for SSE approximation.
OCIO_CHECK_CLOSE(pixel[0], 0.62966f, error*2.0f);
OCIO_CHECK_CLOSE(pixel[1], 0.48175f, error);
OCIO_CHECK_CLOSE(pixel[2], 0.20969f, error);
// Restore file value.
dpDouble->setValue(fileValue);
pixel[0] = 0.5f;
pixel[1] = 0.4f;
pixel[2] = 0.2f;
cpuProcessor->applyRGB(pixel);
OCIO_CHECK_CLOSE(pixel[0], 0.57495f, error);
OCIO_CHECK_CLOSE(pixel[1], 0.43988f, error);
OCIO_CHECK_CLOSE(pixel[2], 0.19147f, error);
// Note: The CTF does not define gamma as being dynamic.
OCIO_CHECK_THROW_WHAT(cpuProcessor->getDynamicProperty(OCIO::DYNAMIC_PROPERTY_GAMMA),
OCIO::Exception,
"Cannot find dynamic property");
// Get optimized CPU processor without dynamic properties.
OCIO_CHECK_NO_THROW(cpuProcessor = processor->getOptimizedCPUProcessor(OCIO::OPTIMIZATION_ALL));
// Now the dynamic property can't be found.
OCIO_CHECK_THROW_WHAT(cpuProcessor->getDynamicProperty(dpt),
OCIO::Exception,
"Cannot find dynamic property");
}
OCIO_ADD_TEST(DynamicPropertyImpl, equal_grading_primary)
{
OCIO::GradingPrimary gplog{ OCIO::GRADING_LOG };
gplog.m_brightness = OCIO::GradingRGBM{ -10., 45., -5., 50. };
gplog.m_contrast = OCIO::GradingRGBM{ 0.9, 1.4, 0.7, 0.75 };
gplog.m_gamma = OCIO::GradingRGBM{ 1.1, 0.7, 1.05, 1.15 };
gplog.m_saturation = 1.21;
gplog.m_pivot = -0.3;
gplog.m_pivotBlack = 0.05;
gplog.m_pivotWhite = 0.9;
gplog.m_clampBlack = -0.05;
gplog.m_clampWhite = 1.5;
OCIO::DynamicPropertyGradingPrimaryImplRcPtr dpImpl0 =
std::make_shared<OCIO::DynamicPropertyGradingPrimaryImpl>(OCIO::GRADING_LOG,
OCIO::TRANSFORM_DIR_FORWARD,
gplog, false);
OCIO::DynamicPropertyRcPtr dp0 = dpImpl0;
OCIO::DynamicPropertyGradingPrimaryImplRcPtr dpImpl1 =
std::make_shared<OCIO::DynamicPropertyGradingPrimaryImpl>(OCIO::GRADING_LOG,
OCIO::TRANSFORM_DIR_FORWARD,
gplog, false);
OCIO::DynamicPropertyRcPtr dp1 = dpImpl1;
// Both not dynamic, same value.
OCIO_CHECK_ASSERT(*dp0 == *dp1);
// Both not dynamic, diff values.
gplog.m_clampWhite = 1.4;
dpImpl0->setValue(gplog);
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Same value.
dpImpl1->setValue(gplog);
OCIO_CHECK_ASSERT(*dp0 == *dp1);
// One dynamic, not the other, same value.
dpImpl0->makeDynamic();
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Both dynamic, same value.
dpImpl1->makeDynamic();
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Both dynamic, different values.
gplog.m_clampWhite = 1.3;
dpImpl1->setValue(gplog);
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Different value types.
OCIO::DynamicPropertyDoubleImplRcPtr dpImplDouble =
std::make_shared<OCIO::DynamicPropertyDoubleImpl>(OCIO::DYNAMIC_PROPERTY_EXPOSURE, 1.0, true);
OCIO_CHECK_ASSERT(!(*dp0 == *dpImplDouble));
}
OCIO_ADD_TEST(DynamicPropertyImpl, equal_grading_rgb_curve)
{
auto curveEdit = OCIO::GradingBSplineCurve::Create(2);
OCIO::ConstGradingBSplineCurveRcPtr curve = curveEdit;
OCIO::ConstGradingRGBCurveRcPtr rgbCurve = OCIO::GradingRGBCurve::Create(curve, curve, curve, curve);
OCIO::DynamicPropertyGradingRGBCurveImplRcPtr dpImpl0 =
std::make_shared<OCIO::DynamicPropertyGradingRGBCurveImpl>(rgbCurve, false);
OCIO::DynamicPropertyRcPtr dp0 = dpImpl0;
OCIO::DynamicPropertyGradingRGBCurveImplRcPtr dpImpl1 =
std::make_shared<OCIO::DynamicPropertyGradingRGBCurveImpl>(rgbCurve, false);
OCIO::DynamicPropertyRcPtr dp1 = dpImpl1;
// Both not dynamic, same value.
OCIO_CHECK_ASSERT(*dp0 == *dp1);
// Both not dynamic, diff values.
curveEdit->setNumControlPoints(3);
OCIO::ConstGradingRGBCurveRcPtr rgbCurve1 = OCIO::GradingRGBCurve::Create(curve, curve, curve, curve);
dpImpl0->setValue(rgbCurve1);
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Same value.
dpImpl1->setValue(rgbCurve1);
OCIO_CHECK_ASSERT(*dp0 == *dp1);
// One dynamic, not the other, same value.
dpImpl0->makeDynamic();
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Both dynamic, same value.
dpImpl1->makeDynamic();
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Both dynamic, different values.
dpImpl1->setValue(rgbCurve);
OCIO_CHECK_ASSERT(!(*dp0 == *dp1));
// Different value types.
OCIO::DynamicPropertyDoubleImplRcPtr dpImplDouble =
std::make_shared<OCIO::DynamicPropertyDoubleImpl>(OCIO::DYNAMIC_PROPERTY_EXPOSURE, 1.0, true);
OCIO_CHECK_ASSERT(!(*dp0 == *dpImplDouble));
}
OCIO_ADD_TEST(DynamicPropertyImpl, grading_rgb_curve_knots)
{
auto curve11 = OCIO::GradingBSplineCurve::Create({ { 0.f, 10.f },{ 2.f, 10.f },{ 3.f, 10.f },
{ 5.f, 10.f },{ 6.f, 10.f },{ 8.f, 10.f },{ 9.f, 10.5f },{ 11.f, 15.f },{ 12.f, 50.f },
{ 14.f, 60.f },{ 15.f, 85.f } });
// Identity curve.
auto curve = OCIO::GradingBSplineCurve::Create({ { 0.f, 0.f },{ 1.f, 1.f } });
// 1 curve with 11 control points used for green.
auto curves = OCIO::GradingRGBCurve::Create(curve, curve11, curve, curve);
OCIO::DynamicPropertyGradingRGBCurveImplRcPtr dp =
std::make_shared<OCIO::DynamicPropertyGradingRGBCurveImpl>(curves, false);
const int * coefsOffsets = dp->getCoefsOffsetsArray();
const int * knotsOffsets = dp->getKnotsOffsetsArray();
OCIO_CHECK_EQUAL(-1, coefsOffsets[0]); // Offset for red
OCIO_CHECK_EQUAL(0, coefsOffsets[1]); // Count for red
OCIO_CHECK_EQUAL(0, coefsOffsets[2]); // Offset for green
OCIO_CHECK_EQUAL(45, coefsOffsets[3]); // Count for green
OCIO_CHECK_EQUAL(-1, coefsOffsets[4]); // Offset for blue
OCIO_CHECK_EQUAL(0, coefsOffsets[5]); // Count for blue
OCIO_CHECK_EQUAL(-1, coefsOffsets[6]); // Offset for master
OCIO_CHECK_EQUAL(0, coefsOffsets[7]); // Count for master
OCIO_CHECK_EQUAL(-1, knotsOffsets[0]); // Offset for red
OCIO_CHECK_EQUAL(0, knotsOffsets[1]); // Count for red
OCIO_CHECK_EQUAL(0, knotsOffsets[2]); // Offset for green
OCIO_CHECK_EQUAL(16, knotsOffsets[3]); // Count for green
OCIO_CHECK_EQUAL(-1, knotsOffsets[4]); // Offset for blue
OCIO_CHECK_EQUAL(0, knotsOffsets[5]); // Count for blue
OCIO_CHECK_EQUAL(-1, knotsOffsets[6]); // Offset for master
OCIO_CHECK_EQUAL(0, knotsOffsets[7]); // Count for master
OCIO_CHECK_EQUAL(45, dp->getNumCoefs());
OCIO_CHECK_EQUAL(16, dp->getNumKnots());
const float * coefs = dp->getCoefsArray();
const float * knots = dp->getKnotsArray();
static constexpr float error = 1e-6f;
OCIO_CHECK_CLOSE(0.f, coefs[0], error);
OCIO_CHECK_CLOSE(0.f, coefs[1], error);
OCIO_CHECK_CLOSE(0.f, coefs[2], error);
OCIO_CHECK_CLOSE(0.f, coefs[3], error);
OCIO_CHECK_CLOSE(0.f, coefs[4], error);
OCIO_CHECK_CLOSE(0.337645531f, coefs[5], error);
OCIO_CHECK_CLOSE(2.74714088f, coefs[6], error);
OCIO_CHECK_CLOSE(0.081863299f, coefs[7], error);
OCIO_CHECK_CLOSE(643.661987f, coefs[8], error);
OCIO_CHECK_CLOSE(17.7471409f, coefs[9], error);
OCIO_CHECK_CLOSE(-37.0891609f, coefs[10], error);
OCIO_CHECK_CLOSE(-5.69135284f, coefs[11], error);
OCIO_CHECK_CLOSE(3.83422971f, coefs[12], error);
OCIO_CHECK_CLOSE(59.0043716f, coefs[13], error);
OCIO_CHECK_CLOSE(1.69310224f, coefs[14], error);
OCIO_CHECK_CLOSE(0.f, coefs[15], error);
OCIO_CHECK_CLOSE(0.f, coefs[16], error);
OCIO_CHECK_CLOSE(0.f, coefs[17], error);
OCIO_CHECK_CLOSE(0.f, coefs[18], error);
OCIO_CHECK_CLOSE(0.f, coefs[19], error);
OCIO_CHECK_CLOSE(0.f, coefs[20], error);
OCIO_CHECK_CLOSE(0.499999881f, coefs[21], error);
OCIO_CHECK_CLOSE(1.92619848f, coefs[22], error);
OCIO_CHECK_CLOSE(2.25f, coefs[23], error);
OCIO_CHECK_CLOSE(30.9619350f, coefs[24], error);
OCIO_CHECK_CLOSE(48.7090759f, coefs[25], error);
OCIO_CHECK_CLOSE(11.6199141f, coefs[26], error);
OCIO_CHECK_CLOSE(0.237208843f, coefs[27], error);
OCIO_CHECK_CLOSE(7.90566826f, coefs[28], error);
OCIO_CHECK_CLOSE(24.9999962f, coefs[29], error);
OCIO_CHECK_CLOSE(10.f, coefs[30], error);
OCIO_CHECK_CLOSE(10.f, coefs[31], error);
OCIO_CHECK_CLOSE(10.f, coefs[32], error);
OCIO_CHECK_CLOSE(10.f, coefs[33], error);
OCIO_CHECK_CLOSE(10.f, coefs[34], error);
OCIO_CHECK_CLOSE(10.f, coefs[35], error);
OCIO_CHECK_CLOSE(10.1851053f, coefs[36], error);
OCIO_CHECK_CLOSE(10.5f, coefs[37], error);
OCIO_CHECK_CLOSE(14.6296263f, coefs[38], error);
OCIO_CHECK_CLOSE(15.f, coefs[39], error);
OCIO_CHECK_CLOSE(34.9177551f, coefs[40], error);
OCIO_CHECK_CLOSE(50.f, coefs[41], error);
OCIO_CHECK_CLOSE(55.9285622f, coefs[42], error);
OCIO_CHECK_CLOSE(60.f, coefs[43], error);
OCIO_CHECK_CLOSE(62.3833008f, coefs[44], error);
OCIO_CHECK_CLOSE(0.f, knots[0], error);
OCIO_CHECK_CLOSE(2.f, knots[1], error);
OCIO_CHECK_CLOSE(3.f, knots[2], error);
OCIO_CHECK_CLOSE(5.f, knots[3], error);
OCIO_CHECK_CLOSE(6.f, knots[4], error);
OCIO_CHECK_CLOSE(8.f, knots[5], error);
OCIO_CHECK_CLOSE(8.74042130f, knots[6], error);
OCIO_CHECK_CLOSE(9.f, knots[7], error);
OCIO_CHECK_CLOSE(10.9776964f, knots[8], error);
OCIO_CHECK_CLOSE(11.f, knots[9], error);
OCIO_CHECK_CLOSE(11.5f, knots[10], error);
OCIO_CHECK_CLOSE(12.f, knots[11], error);
OCIO_CHECK_CLOSE(13.f, knots[12], error);
OCIO_CHECK_CLOSE(14.f, knots[13], error);
OCIO_CHECK_CLOSE(14.1448565f, knots[14], error);
OCIO_CHECK_CLOSE(15.f, knots[15], error);
// Using the 11 control points curve twice.
curves = OCIO::GradingRGBCurve::Create(curve11, curve, curve11, curve);
auto dp2 = std::make_shared<OCIO::DynamicPropertyGradingRGBCurveImpl>(curves, false);
coefsOffsets = dp2->getCoefsOffsetsArray();
knotsOffsets = dp2->getKnotsOffsetsArray();
OCIO_CHECK_EQUAL(0, coefsOffsets[0]); // Offset for red
OCIO_CHECK_EQUAL(45, coefsOffsets[1]); // Count for red
OCIO_CHECK_EQUAL(-1, coefsOffsets[2]); // Offset for green
OCIO_CHECK_EQUAL(0, coefsOffsets[3]); // Count for green
OCIO_CHECK_EQUAL(45, coefsOffsets[4]); // Offset for blue
OCIO_CHECK_EQUAL(45, coefsOffsets[5]); // Count for blue
OCIO_CHECK_EQUAL(-1, coefsOffsets[6]); // Offset for master
OCIO_CHECK_EQUAL(0, coefsOffsets[7]); // Count for master
OCIO_CHECK_EQUAL(90, dp2->getNumCoefs());
OCIO_CHECK_EQUAL(32, dp2->getNumKnots());
const float * coefs2 = dp2->getCoefsArray();
const float * knots2 = dp2->getKnotsArray();
for (int c = 0; c < 45; ++c)
{
OCIO_CHECK_EQUAL(coefs[c], coefs2[c]);
OCIO_CHECK_EQUAL(coefs[c], coefs2[45 + c]);
}
for (int k = 0; k < 16; ++k)
{
OCIO_CHECK_EQUAL(knots[k], knots2[k]);
OCIO_CHECK_EQUAL(knots[k], knots2[16 + k]);
}
// Verify that pointer does not change when setting data.
auto dpPointer = dp.get();
dp->setValue(curves);
OCIO_CHECK_EQUAL(dp2->getNumCoefs(), dp->getNumCoefs());
OCIO_CHECK_EQUAL(dp2->getNumKnots(), dp->getNumKnots());
auto dpPointerAfterSet = dp.get();
OCIO_CHECK_EQUAL(dpPointer, dpPointerAfterSet);
}
OCIO_ADD_TEST(DynamicPropertyImpl, get_as)
{
OCIO::GradingPrimary gplog{ OCIO::GRADING_LOG };
gplog.m_saturation = 1.21;
OCIO::DynamicPropertyGradingPrimaryImplRcPtr dpImpl0 =
std::make_shared<OCIO::DynamicPropertyGradingPrimaryImpl>(OCIO::GRADING_LOG,
OCIO::TRANSFORM_DIR_FORWARD,
gplog, false);
OCIO::DynamicPropertyRcPtr dp0 = dpImpl0;
OCIO_CHECK_THROW_WHAT(OCIO::DynamicPropertyValue::AsDouble(dp0), OCIO::Exception,
"Dynamic property value is not a double");
OCIO_CHECK_THROW_WHAT(OCIO::DynamicPropertyValue::AsGradingTone(dp0), OCIO::Exception,
"Dynamic property value is not a grading tone");
OCIO::DynamicPropertyGradingPrimaryRcPtr asPrimary;
OCIO_CHECK_NO_THROW(asPrimary = OCIO::DynamicPropertyValue::AsGradingPrimary(dp0));
OCIO_REQUIRE_ASSERT(asPrimary);
OCIO_CHECK_EQUAL(asPrimary->getValue(), gplog);
gplog.m_pivot = 0.12;
asPrimary->setValue(gplog);
OCIO_CHECK_EQUAL(dpImpl0->getValue(), gplog);
}
Reference in new issue View Git Blame Copy Permalink